On Wed, 17 Jul 2019 14:00:55 +0200, Petr Mladek wrote:
Adding Jiri into CC to be sure that we really solved the original problem.
The patch looks good to me, the runner expects 4 as an indication that the test was skipped.
I get the following output when livepatching is not configured:
$> make run_tests TAP version 13 1..4 # selftests: livepatch: test-livepatch.sh # TEST: basic function patching ... SKIP: Failed modprobe --dry-run of module: test_klp_livepatch not ok 1 selftests: livepatch: test-livepatch.sh # SKIP # selftests: livepatch: test-callbacks.sh # TEST: target module before livepatch ... SKIP: Failed modprobe --dry-run of module: test_klp_callbacks_mod not ok 2 selftests: livepatch: test-callbacks.sh # SKIP # selftests: livepatch: test-shadow-vars.sh # TEST: basic shadow variable API ... SKIP: Failed modprobe --dry-run of module: test_klp_shadow_vars not ok 3 selftests: livepatch: test-shadow-vars.sh # SKIP # selftests: livepatch: test-state.sh # TEST: system state modification ... SKIP: Failed modprobe --dry-run of module: test_klp_state not ok 4 selftests: livepatch: test-state.sh # SKIP
Jiri, is it acceptable solution for you, please?
It looks correct. My reading of the TAP 13 specification is that it should be returned as "ok" instead of "not ok" but that is not a problem of this patch.
Otherwise, the patch looks fine to me. If Jiri is fine then feel free to use:
Reviewed-by: Petr Mladek pmladek@suse.com
Sure.
Acked-by: Jiri Benc jbenc@redhat.com
Thanks!
Jiri