On Thu, Jul 1, 2021 at 10:52 AM Rae Moar rmoar@google.com wrote:
This patch addresses misleading error messages reported by kunit_tool in two cases. First, in the case of TAP output having an incorrect header format or missing a header, the parser used to output an error message of 'no tests run!'. Now the parser outputs an error message of 'could not parse test results!'.
As an example:
Before: $ ./tools/testing/kunit/kunit.py parse /dev/null [ERROR] no tests run! ...
After: $ ./tools/testing/kunit/kunit.py parse /dev/null [ERROR] could not parse test results! ...
Second, in the case of TAP output with the correct header but no tests, the parser used to output an error message of 'could not parse test results!'. Now the parser outputs an error message of 'no tests run!'.
As an example:
Before: $ echo -e 'TAP version 14\n1..0' | ./tools/testing/kunit/kunit.py parse [ERROR] could not parse test results!
After: $ echo -e 'TAP version 14\n1..0' | ./tools/testing/kunit/kunit.py parse [ERROR] no tests run!
Additionally, this patch also corrects the tests in kunit_tool_test.py and adds a test to check the error in the case of TAP output with the correct header but no tests.
Signed-off-by: Rae Moar rmoar@google.com Reviewed-by: David Gow davidgow@google.com Reviewed-by: Daniel Latypov dlatypov@google.com
Reviewed-by: Brendan Higgins brendanhiggins@google.com