Re: [PATCH v2 19/24] selftests/resctrl: Pass the real number of tests to show_cache_info()

Hi Ilpo,

On 4/18/2023 4:45 AM, Ilpo Järvinen wrote:

Some results include warm-up tests which are discarded before passing the sum to show_cache_info(). Currently, show_cache_info() handles this

Please drop "Currently".

by subtracting one from the number of tests in divisor. It is a trappy construct to have sum and number of tests parameters to disagree like this.

A more logical place for subtracting the skipped tests is where the sum is calculated so move it there. Pass the correct number of tests to show_cache_info() soit can use directly as the divisor for calculating the average.

This is not clear to me. How about "soit can use directly" -> "so it can be used directly"?

Reinette