On Fri, 21 Apr 2023, Reinette Chatre wrote:
On 4/18/2023 4:44 AM, Ilpo Järvinen wrote:
CAT test only validates that the number of CBM bits is not too large but it could be too small too.
Could you please elaborate how this scenario could occur?
Check and return error before starting the CAT test if the number of CBM bits is too small.
Fixes: 09a67934625a ("selftests/resctrl: Don't hard code value of "no_of_bits" variable")
This fix is not clear to me. This commit being fixed already contains an explicit test that will bail out of no_of_bits <= 0. It is not clear to me why it is necessary to adding a test for < 1 as a fix for this commit.
Ah, indeed, it's checked on the higher level so this fix is unnecessary. I missed it entirely while taking this change out from a more complex change and even failed to make the connection when I stared at the very if <= 0 check not so many days ago.