On Tue, Feb 4, 2020 at 1:18 PM Frank Rowand firstname.lastname@example.org wrote:
On 1/30/20 5:08 PM, Brendan Higgins wrote:
This patchset adds a centralized executor to dispatch tests rather than relying on late_initcall to schedule each test suite separately along with a couple of new features that depend on it.
And the "couple of new features" are .... ?
Sorry, I thought I addressed that in the next section, specifically by calling out: printing the test plan, and adding the new kernel command line option. I will call these out here in any future cover letters.
## What am I trying to do?
Conceptually, I am trying to provide a mechanism by which test suites can be grouped together so that they can be reasoned about collectively. The last two of three patches in this series add features which depend on this:
PATCH 5/7 Prints out a test plan right before KUnit tests are run; this is valuable because it makes it possible for a test harness to detect whether the number of tests run matches the number of tests expected to be run, ensuring that no tests silently failed.
PATCH 6/7 Add a new kernel command-line option which allows the user to specify that the kernel poweroff, halt, or reboot after completing all KUnit tests; this is very handy for running KUnit tests on UML or a VM so that the UML/VM process exits cleanly immediately after running all tests without needing a special initramfs.
In addition, by dispatching tests from a single location, we can guarantee that all KUnit tests run after late_init is complete, which
That the tests will run after late init (and are guaranteed to do such) needs to be added to the documentation.
Yeah, that's reasonable. I am not sure where I should put this in the documentation, however. This seems kind of a technical detail, and all the pages I have now are more of how-tos, I think.
Maybe I should send a patch which adds a page detailing how KUnit works?
I would like to get some other people's thoughts on this. Such a technical guide wouldn't provide me a lot of value, at least not now, so I want to make sure that something like that would be valuable to others.