Y2038

y2038@lists.linaro.org

1135 discussions

[PATCH net-next 1/5] pppoe: fix PPPOEIOCSFWD compat handling

by Arnd Bergmann

Support for handling the PPPOEIOCSFWD ioctl in compat mode was added in linux-2.5.69 along with hundreds of other commands, but was always broken sincen only the structure is compatible, but the command number is not, due to the size being sizeof(size_t), or at first sizeof(sizeof((struct sockaddr_pppox)), which is different on 64-bit architectures. Fix it by defining a separate command code that matches the 32-bit version, and marking that one as compatible. This should apply to all stable kernels. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- drivers/net/ppp/pppoe.c | 4 ++++ fs/compat_ioctl.c | 2 +- include/linux/if_pppox.h | 2 ++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c index ce61231e96ea..d1c3f9292c54 100644 --- a/drivers/net/ppp/pppoe.c +++ b/drivers/net/ppp/pppoe.c @@ -57,6 +57,7 @@ * */ +#include <linux/compat.h> #include <linux/string.h> #include <linux/module.h> #include <linux/kernel.h> @@ -780,6 +781,9 @@ static int pppoe_ioctl(struct socket *sock, unsigned int cmd, err = 0; break; +#ifdef CONFIG_COMPAT + case PPPOEIOCSFWD32: +#endif case PPPOEIOCSFWD: { struct pppox_sock *relay_po; diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c index a9b00942e87d..a8bb193fdfd5 100644 --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c @@ -895,7 +895,7 @@ COMPATIBLE_IOCTL(PPPIOCATTCHAN) COMPATIBLE_IOCTL(PPPIOCGCHAN) COMPATIBLE_IOCTL(PPPIOCGL2TPSTATS) /* PPPOX */ -COMPATIBLE_IOCTL(PPPOEIOCSFWD) +COMPATIBLE_IOCTL(PPPOEIOCSFWD32) COMPATIBLE_IOCTL(PPPOEIOCDFWD) /* Big A */ /* sparc only */ diff --git a/include/linux/if_pppox.h b/include/linux/if_pppox.h index ba7a9b0c7c57..d221f1465f41 100644 --- a/include/linux/if_pppox.h +++ b/include/linux/if_pppox.h @@ -85,6 +85,8 @@ extern void unregister_pppox_proto(int proto_num); extern void pppox_unbind_sock(struct sock *sk);/* delete ppp-channel binding */ extern int pppox_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg); +#define PPPOEIOCSFWD32 _IOW(0xB1 ,0, compat_size_t) + /* PPPoX socket states */ enum { PPPOX_NONE = 0, /* initial state */ -- 2.18.0

6 years, 10 months

[PATCH 00/14] y2038 syscall changes for 4.20

by Arnd Bergmann

Hi Thomas, I've rebased the syscall changes on top of 4.19-rc1, and the old_time32 rename. This is the first set of those patches, the ones that I hope are all uncontroversial and obvious now. I'm still in the process of reorganizing and testing the next set batch top, and plan to send them after you've merged these. The first three patches are new here, the other ones have been posted before a few times. Arnd Arnd Bergmann (14): y2038: remove unused time interfaces y2038: make do_gettimeofday() and get_seconds() inline y2038: globally rename compat_time to old_time32 y2038: Remove newstat family from default syscall set y2038: Remove stat64 family from default syscall set asm-generic: Move common compat types to asm-generic/compat.h asm-generic: Remove unneeded __ARCH_WANT_SYS_LLSEEK macro asm-generic: Remove empty asm/unistd.h y2038: Change sys_utimensat() to use __kernel_timespec y2038: Compile utimes()/futimesat() conditionally y2038: utimes: Rework #ifdef guards for compat syscalls y2038: sched: Change sched_rr_get_interval to use __kernel_timespec y2038: socket: Change recvmmsg to use __kernel_timespec y2038: signal: Change rt_sigtimedwait to use __kernel_timespec arch/alpha/include/asm/unistd.h | 2 + arch/arc/include/uapi/asm/unistd.h | 1 + arch/arm/include/asm/unistd.h | 4 +- arch/arm64/include/asm/compat.h | 26 ++---- arch/arm64/include/asm/stat.h | 2 +- arch/arm64/include/asm/unistd.h | 2 +- arch/arm64/include/uapi/asm/unistd.h | 1 + arch/c6x/include/uapi/asm/unistd.h | 1 + arch/h8300/include/uapi/asm/unistd.h | 1 + arch/hexagon/include/uapi/asm/unistd.h | 1 + arch/ia64/include/asm/unistd.h | 3 + arch/m68k/include/asm/unistd.h | 2 +- arch/microblaze/include/asm/unistd.h | 2 +- arch/mips/include/asm/compat.h | 28 ++----- arch/mips/include/asm/unistd.h | 3 +- arch/mips/kernel/binfmt_elfn32.c | 14 ++-- arch/mips/kernel/binfmt_elfo32.c | 14 ++-- arch/nds32/include/uapi/asm/unistd.h | 1 + arch/nios2/include/uapi/asm/unistd.h | 1 + arch/openrisc/include/uapi/asm/unistd.h | 1 + arch/parisc/include/asm/compat.h | 24 ++---- arch/parisc/include/asm/unistd.h | 3 +- arch/powerpc/include/asm/compat.h | 24 ++---- arch/powerpc/include/asm/unistd.h | 3 +- arch/powerpc/kernel/asm-offsets.c | 8 +- arch/powerpc/oprofile/backtrace.c | 2 +- arch/s390/include/asm/compat.h | 18 +--- arch/s390/include/asm/unistd.h | 3 +- arch/sh/include/asm/unistd.h | 2 +- arch/sparc/include/asm/compat.h | 25 ++---- arch/sparc/include/asm/unistd.h | 3 +- arch/unicore32/include/uapi/asm/unistd.h | 1 + arch/x86/include/asm/compat.h | 19 +---- arch/x86/include/asm/unistd.h | 3 +- arch/xtensa/include/asm/unistd.h | 2 +- fs/aio.c | 8 +- fs/compat_binfmt_elf.c | 2 +- fs/read_write.c | 2 +- fs/select.c | 20 ++--- fs/stat.c | 3 + fs/timerfd.c | 12 +-- fs/utimes.c | 73 ++++++++-------- include/asm-generic/compat.h | 24 +++++- include/asm-generic/unistd.h | 13 --- include/linux/compat.h | 101 +++++++++++------------ include/linux/compat_time.h | 32 ------- include/linux/elfcore-compat.h | 8 +- include/linux/restart_block.h | 4 +- include/linux/socket.h | 4 +- include/linux/syscalls.h | 21 +++-- include/linux/time32.h | 78 ++++++++--------- include/linux/timekeeping.h | 12 --- include/linux/timekeeping32.h | 53 ++---------- include/uapi/asm-generic/unistd.h | 2 + ipc/mqueue.c | 8 +- ipc/msg.c | 6 +- ipc/sem.c | 10 +-- ipc/shm.c | 6 +- ipc/syscall.c | 2 +- ipc/util.h | 2 +- kernel/compat.c | 8 +- kernel/futex_compat.c | 2 +- kernel/sched/core.c | 8 +- kernel/signal.c | 19 +++-- kernel/time/hrtimer.c | 8 +- kernel/time/posix-stubs.c | 18 ++-- kernel/time/posix-timers.c | 30 +++---- kernel/time/time.c | 97 +++++++++------------- kernel/time/timekeeping.c | 24 ------ net/compat.c | 10 +-- net/socket.c | 18 ++-- 71 files changed, 397 insertions(+), 601 deletions(-) delete mode 100644 include/asm-generic/unistd.h delete mode 100644 include/linux/compat_time.h -- 2.18.0

6 years, 10 months

[PATCH 1/2] rtc: mips: default to rtc-cmos on mips

by Arnd Bergmann

The old rtc driver is getting in the way of some compat_ioctl simplification. Looking up the loongson64 git history, it seems that everyone uses the more modern but compatible RTC_CMOS driver anyway, so let's remove the special case for loongson64. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- arch/mips/Kconfig | 2 +- drivers/char/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 35511999156a..c695825d9377 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -75,7 +75,7 @@ config MIPS select MODULES_USE_ELF_RELA if MODULES && 64BIT select MODULES_USE_ELF_REL if MODULES select PERF_USE_VMALLOC - select RTC_LIB if !MACH_LOONGSON64 + select RTC_LIB select SYSCTL_EXCEPTION_TRACE select VIRT_TO_BUS diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig index ce277ee0a28a..131b4c300050 100644 --- a/drivers/char/Kconfig +++ b/drivers/char/Kconfig @@ -268,7 +268,7 @@ if RTC_LIB=n config RTC tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)" - depends on ALPHA || (MIPS && MACH_LOONGSON64) + depends on ALPHA ---help--- If you say Y here and create a character special file /dev/rtc with major number 10 and minor number 135 using mknod ("man mknod"), you -- 2.18.0

6 years, 10 months

Patch "posix-timers: Fix nanosleep_copyout() for CONFIG_COMPAT_32BIT_TIME" has been added to the 4.17-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled posix-timers: Fix nanosleep_copyout() for CONFIG_COMPAT_32BIT_TIME to the 4.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: posix-timers-fix-nanosleep_copyout-for-config_compat_32bit_time.patch and it can be found in the queue-4.17 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Wed Aug 22 09:16:55 CEST 2018 From: Arnd Bergmann <arnd(a)arndb.de> Date: Mon, 18 Jun 2018 16:07:59 +0200 Subject: posix-timers: Fix nanosleep_copyout() for CONFIG_COMPAT_32BIT_TIME From: Arnd Bergmann <arnd(a)arndb.de> [ Upstream commit 0fe2795516b9e1c59b58b02bdf8658698117ec4e ] Commit b5793b0d92c9 added support for building the nanosleep compat system call on 32-bit architectures, but missed one change in nanosleep_copyout(), which would trigger a BUG() as soon as any architecture is switched over to use it. Use the proper config symbol to enable the code path. Fixes: Commit b5793b0d92c9 ("posix-timers: Make compat syscalls depend on CONFIG_COMPAT_32BIT_TIME") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Cc: y2038(a)lists.linaro.org Cc: Anna-Maria Gleixner <anna-maria(a)linutronix.de> Cc: Deepa Dinamani <deepa.kernel(a)gmail.com> Cc: "Rafael J. Wysocki" <rafael.j.wysocki(a)intel.com> Link: https://lkml.kernel.org/r/20180618140811.2998503-1-arnd@arndb.de Signed-off-by: Sasha Levin <alexander.levin(a)microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- kernel/time/hrtimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/time/hrtimer.c +++ b/kernel/time/hrtimer.c @@ -1659,7 +1659,7 @@ EXPORT_SYMBOL_GPL(hrtimer_init_sleeper); int nanosleep_copyout(struct restart_block *restart, struct timespec64 *ts) { switch(restart->nanosleep.type) { -#ifdef CONFIG_COMPAT +#ifdef CONFIG_COMPAT_32BIT_TIME case TT_COMPAT: if (compat_put_timespec64(ts, restart->nanosleep.compat_rmtp)) return -EFAULT; Patches currently in stable-queue which might be from arnd(a)arndb.de are queue-4.17/posix-timers-fix-nanosleep_copyout-for-config_compat_32bit_time.patch queue-4.17/ieee802154-mcr20a-add-missing-includes.patch queue-4.17/drm-sun4i-link-in-front-end-code-if-needed.patch

6 years, 10 months

[PATCH] y2038: provide aliases for compat helpers

by Arnd Bergmann

As part of the system call rework for 64-bit time_t, we are restructuring the way that compat syscalls deal with 32-bit time_t, reusing the implementation for 32-bit architectures. Christoph Hellwig suggested a rename of the associated types and interfaces to avoid the confusing usage of the 'compat' prefix for 32-bit architectures. To prepare for doing that in linux-4.20, this adds a set of macros that lets us convert subsystems separately to the new names and avoid some of the nastier merge conflicts. Link: https://lore.kernel.org/lkml/20180713133204.3123939-1-arnd@arndb.de/ Cc: Christoph Hellwig <hch(a)lst.de> Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- The patch I posted originally was ready but didn't see proper linux-next testing as I did not get to finalize it before my summer vacation, so this is the minimal replacement I'd still like to get into 4.19-rc1, in order to base patches for system calls, sound, networking, media and file systems on top of. I have put it into linux-next now after realizing that it would be a problem to do all my other planned changes for the 4.20 merge window. Please let me know if you have concerns about the approach, or provide an Ack if this is ok with you. --- include/linux/time32.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/include/linux/time32.h b/include/linux/time32.h index 0b14f936100a..d1ae43c13e25 100644 --- a/include/linux/time32.h +++ b/include/linux/time32.h @@ -207,4 +207,19 @@ static inline s64 timeval_to_ns(const struct timeval *tv) extern struct timeval ns_to_timeval(const s64 nsec); extern struct __kernel_old_timeval ns_to_kernel_old_timeval(s64 nsec); +/* + * New aliases for compat time functions. These will be used to replace + * the compat code so it can be shared between 32-bit and 64-bit builds + * both of which provide compatibility with old 32-bit tasks. + */ +#define old_time32_t compat_time_t +#define old_timeval32 compat_timeval +#define old_timespec32 compat_timespec +#define old_itimerspec32 compat_itimerspec +#define ns_to_old_timeval32 ns_to_compat_timeval +#define get_old_itimerspec32 get_compat_itimerspec64 +#define put_old_itimerspec32 put_compat_itimerspec64 +#define get_old_timespec32 compat_get_timespec64 +#define put_old_timespec32 compat_put_timespec64 + #endif -- 2.18.0

6 years, 10 months

Patch "posix-timers: Fix nanosleep_copyout() for CONFIG_COMPAT_32BIT_TIME" has been added to the 4.14-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled posix-timers: Fix nanosleep_copyout() for CONFIG_COMPAT_32BIT_TIME to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: posix-timers-fix-nanosleep_copyout-for-config_compat_32bit_time.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Wed Aug 22 09:33:46 CEST 2018 From: Arnd Bergmann <arnd(a)arndb.de> Date: Mon, 18 Jun 2018 16:07:59 +0200 Subject: posix-timers: Fix nanosleep_copyout() for CONFIG_COMPAT_32BIT_TIME From: Arnd Bergmann <arnd(a)arndb.de> [ Upstream commit 0fe2795516b9e1c59b58b02bdf8658698117ec4e ] Commit b5793b0d92c9 added support for building the nanosleep compat system call on 32-bit architectures, but missed one change in nanosleep_copyout(), which would trigger a BUG() as soon as any architecture is switched over to use it. Use the proper config symbol to enable the code path. Fixes: Commit b5793b0d92c9 ("posix-timers: Make compat syscalls depend on CONFIG_COMPAT_32BIT_TIME") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Cc: y2038(a)lists.linaro.org Cc: Anna-Maria Gleixner <anna-maria(a)linutronix.de> Cc: Deepa Dinamani <deepa.kernel(a)gmail.com> Cc: "Rafael J. Wysocki" <rafael.j.wysocki(a)intel.com> Link: https://lkml.kernel.org/r/20180618140811.2998503-1-arnd@arndb.de Signed-off-by: Sasha Levin <alexander.levin(a)microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- kernel/time/hrtimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/time/hrtimer.c +++ b/kernel/time/hrtimer.c @@ -1450,7 +1450,7 @@ EXPORT_SYMBOL_GPL(hrtimer_init_sleeper); int nanosleep_copyout(struct restart_block *restart, struct timespec64 *ts) { switch(restart->nanosleep.type) { -#ifdef CONFIG_COMPAT +#ifdef CONFIG_COMPAT_32BIT_TIME case TT_COMPAT: if (compat_put_timespec64(ts, restart->nanosleep.compat_rmtp)) return -EFAULT; Patches currently in stable-queue which might be from arnd(a)arndb.de are queue-4.14/posix-timers-fix-nanosleep_copyout-for-config_compat_32bit_time.patch

6 years, 10 months

Joie

by Gerald

I am so unlucky! My old bicycle is broken again. I am sure that it is not a big problem and any male can fix it quickly. Please, come and help me with my problem. I’ll pay you back with my superior body ;) http://www.odv-kac.si/377m71fuj8/jixzqvu.php?eTIwMzhAbGlzdHMubGluYXJvLm9yZw…

6 years, 10 months

[PATCH 0/6] System call table generation support

by Firoz Khan

The goal of this patch series is to easily add/modify/delete a system call by changing entry in syscall.tbl file. No need to manually edit many files. The another goal of this patch series is to to unify the system call implementation across all the architectures. ARM, s390 and x86 architecuture does have the similar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for ia64, m68k, microblaze, mips, parisc, powerpc, sh, sparc, and xtensa. But I started sending the patch for one architecuture for review. Below mentioned git repository contains more details. Git repo:- https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work for solving the Y2038 issue. We need to change two dozen of system calls to solve Y2038 issue. So this implementation will help to easily modify from existing system call to Y2038 compatible system calls. Firoz Khan (6): alpha: Move __IGNORE* entries to non uapi header alpha: Add CONFIG_OSF4_COMPAT for compat syscall support alpha: Unify the not-implemented system call entry name alpha: Replace NR_SYSCALLS macro from asm/unistd.h alpha: Add system call table generation support alpha: uapi header and system call table file generation arch/alpha/Makefile | 3 + arch/alpha/include/asm/Kbuild | 3 +- arch/alpha/include/asm/unistd.h | 7 +- arch/alpha/include/uapi/asm/Kbuild | 2 + arch/alpha/include/uapi/asm/unistd.h | 489 --------------------------- arch/alpha/kernel/Makefile | 2 +- arch/alpha/kernel/entry.S | 4 +- arch/alpha/kernel/osf_sys.c | 9 +- arch/alpha/kernel/syscall.S | 20 ++ arch/alpha/kernel/syscalls/Makefile | 37 +++ arch/alpha/kernel/syscalls/syscall.tbl | 450 +++++++++++++++++++++++++ arch/alpha/kernel/syscalls/syscallhdr.sh | 33 ++ arch/alpha/kernel/syscalls/syscalltbl.sh | 28 ++ arch/alpha/kernel/systbls.S | 552 ------------------------------- 14 files changed, 589 insertions(+), 1050 deletions(-) delete mode 100644 arch/alpha/include/uapi/asm/unistd.h create mode 100644 arch/alpha/kernel/syscall.S create mode 100644 arch/alpha/kernel/syscalls/Makefile create mode 100644 arch/alpha/kernel/syscalls/syscall.tbl create mode 100644 arch/alpha/kernel/syscalls/syscallhdr.sh create mode 100644 arch/alpha/kernel/syscalls/syscalltbl.sh delete mode 100644 arch/alpha/kernel/systbls.S -- 2.7.4

6 years, 10 months

[PATCH v3 0/7] Introduce struct __kernel_timex

by Deepa Dinamani

The series introduces struct __kernel_timex as a substitute for the non y2038 safe struct timex. The series is based on the original series posted by Arnd Bergmann in [1]. The overview of the series is as below: 1. Prepare for the compat timex interfaces to be used unconditionally. 2. Introduce struct __kernel_timex. 3. Use struct __kernel_timex in place of struct timex. 4. Switch syscalls to use struct __kernel_timex. [1] https://sourceware.org/ml/libc-alpha/2015-05/msg00070.html Changes since v2: * Use only generic compat.h for riscv Changes since v1: * Fix riscv asm/compat.h to pick up generic compat types Deepa Dinamani (7): arm64: Make basic compat_* types always available sparc: Make thread_info.h available directly riscv: Delete asm/compat.h timex: prepare compat helpers for y2038 changes time: Add struct __kernel_timex timex: use __kernel_timex internally timex: change syscalls to use struct __kernel_timex arch/alpha/kernel/osf_sys.c | 2 +- arch/arm64/include/asm/compat.h | 22 ++++----- arch/riscv/include/asm/Kbuild | 1 + arch/riscv/include/asm/compat.h | 29 ------------ arch/sparc/include/asm/compat.h | 2 + drivers/ptp/ptp_clock.c | 2 +- include/asm-generic/compat.h | 8 +++- include/linux/compat.h | 33 -------------- include/linux/compat_time.h | 34 ++++++++++++++ include/linux/posix-clock.h | 2 +- include/linux/syscalls.h | 5 +-- include/linux/timex.h | 9 +++- include/uapi/linux/timex.h | 41 +++++++++++++++++ kernel/compat.c | 63 -------------------------- kernel/time/ntp.c | 12 ++--- kernel/time/ntp_internal.h | 2 +- kernel/time/posix-clock.c | 2 +- kernel/time/posix-timers.c | 14 ++---- kernel/time/posix-timers.h | 2 +- kernel/time/time.c | 80 ++++++++++++++++++++++++++++++--- kernel/time/timekeeping.c | 4 +- 21 files changed, 199 insertions(+), 170 deletions(-) delete mode 100644 arch/riscv/include/asm/compat.h base-commit: 526674536360a4c508e84f67314c2028e45e1bf2 -- 2.17.1 Cc: catalin.marinas(a)arm.com Cc: davem(a)davemloft.net Cc: linux-alpha(a)vger.kernel.org Cc: linux-api(a)vger.kernel.org Cc: linux-arch(a)vger.kernel.org Cc: linux-riscv(a)lists.infradead.org Cc: netdev(a)vger.kernel.org Cc: palmer(a)sifive.com

6 years, 11 months

[PATCH 1/3] hfs: stop using timespec based interfaces

by Arnd Bergmann

The native HFS timestamps overflow in year 2040, two years after the Unix y2038 overflow. However, the way that the conversion between on-disk timestamps and in-kernel timestamps was implemented, 64-bit machines actually ended up converting negative UTC timestamps (1902 through 1969) into times between 2038 and 2106. Rather than making all machines faithfully represent timestamps in the ancient past but break after 2040, this changes the file system to always use the unsigned UTC interpretation, reading back times between 1970 and 2106. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- fs/hfs/hfs_fs.h | 6 ++++-- fs/hfs/inode.c | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/hfs/hfs_fs.h b/fs/hfs/hfs_fs.h index 6d0783e2e276..ff432931a5b1 100644 --- a/fs/hfs/hfs_fs.h +++ b/fs/hfs/hfs_fs.h @@ -245,6 +245,8 @@ extern void hfs_mark_mdb_dirty(struct super_block *sb); * Unix: unsigned lil-endian since 00:00 GMT, Jan. 1, 1970 * mac: unsigned big-endian since 00:00 GMT, Jan. 1, 1904 * + * We treat all timestamps before 1970 as times after 2038, so this + * actually works until year 2106 */ #define __hfs_u_to_mtime(sec) cpu_to_be32(sec + 2082844800U - sys_tz.tz_minuteswest * 60) #define __hfs_m_to_utime(sec) (be32_to_cpu(sec) - 2082844800U + sys_tz.tz_minuteswest * 60) @@ -252,9 +254,9 @@ extern void hfs_mark_mdb_dirty(struct super_block *sb); #define HFS_I(inode) (container_of(inode, struct hfs_inode_info, vfs_inode)) #define HFS_SB(sb) ((struct hfs_sb_info *)(sb)->s_fs_info) -#define hfs_m_to_utime(time) (struct timespec){ .tv_sec = __hfs_m_to_utime(time) } +#define hfs_m_to_utime(time) (struct timespec64){ .tv_sec = __hfs_m_to_utime(time) } #define hfs_u_to_mtime(time) __hfs_u_to_mtime((time).tv_sec) -#define hfs_mtime() __hfs_u_to_mtime(get_seconds()) +#define hfs_mtime() __hfs_u_to_mtime(ktime_get_real_seconds()) static inline const char *hfs_mdb_name(struct super_block *sb) { diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c index 2a16111d312f..b3309b83371a 100644 --- a/fs/hfs/inode.c +++ b/fs/hfs/inode.c @@ -351,7 +351,7 @@ static int hfs_read_inode(struct inode *inode, void *data) inode->i_mode &= ~hsb->s_file_umask; inode->i_mode |= S_IFREG; inode->i_ctime = inode->i_atime = inode->i_mtime = - timespec_to_timespec64(hfs_m_to_utime(rec->file.MdDat)); + hfs_m_to_utime(rec->file.MdDat); inode->i_op = &hfs_file_inode_operations; inode->i_fop = &hfs_file_operations; inode->i_mapping->a_ops = &hfs_aops; @@ -362,7 +362,7 @@ static int hfs_read_inode(struct inode *inode, void *data) HFS_I(inode)->fs_blocks = 0; inode->i_mode = S_IFDIR | (S_IRWXUGO & ~hsb->s_dir_umask); inode->i_ctime = inode->i_atime = inode->i_mtime = - timespec_to_timespec64(hfs_m_to_utime(rec->dir.MdDat)); + hfs_m_to_utime(rec->dir.MdDat); inode->i_op = &hfs_dir_inode_operations; inode->i_fop = &hfs_dir_operations; break; -- 2.9.0

6 years, 11 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

Y2038