Y2038

y2038@lists.linaro.org

1135 discussions

[PATCH v3] trace: Make trace_hwlat timestamp y2038 safe

by Deepa Dinamani

struct timespec is not y2038 safe on 32 bit machines and needs to be replaced by struct timespec64 in order to represent times beyond year 2038 on such machines. Fix all the timestamp representation in struct trace_hwlat and all the corresponding implementations. Signed-off-by: Deepa Dinamani <deepa.kernel(a)gmail.com> --- -Changes from v1 * Added long long casts to fix kbuild warning -Changes from v2 * Fixed style for struct hwlat_sample kernel/trace/trace_entries.h | 6 +++--- kernel/trace/trace_hwlat.c | 14 +++++++------- kernel/trace/trace_output.c | 9 ++++----- 3 files changed, 14 insertions(+), 15 deletions(-) diff --git a/kernel/trace/trace_entries.h b/kernel/trace/trace_entries.h index c203ac4..adcdbbe 100644 --- a/kernel/trace/trace_entries.h +++ b/kernel/trace/trace_entries.h @@ -348,14 +348,14 @@ FTRACE_ENTRY(hwlat, hwlat_entry, __field( u64, duration ) __field( u64, outer_duration ) __field( u64, nmi_total_ts ) - __field_struct( struct timespec, timestamp ) - __field_desc( long, timestamp, tv_sec ) + __field_struct( struct timespec64, timestamp ) + __field_desc( s64, timestamp, tv_sec ) __field_desc( long, timestamp, tv_nsec ) __field( unsigned int, nmi_count ) __field( unsigned int, seqnum ) ), - F_printk("cnt:%u\tts:%010lu.%010lu\tinner:%llu\touter:%llunmi-ts:%llu\tnmi-count:%u\n", + F_printk("cnt:%u\tts:%010llu.%010lu\tinner:%llu\touter:%llunmi-ts:%llu\tnmi-count:%u\n", __entry->seqnum, __entry->tv_sec, __entry->tv_nsec, diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c index 21ea6ae..d7c8e4e 100644 --- a/kernel/trace/trace_hwlat.c +++ b/kernel/trace/trace_hwlat.c @@ -79,12 +79,12 @@ static u64 last_tracing_thresh = DEFAULT_LAT_THRESHOLD * NSEC_PER_USEC; /* Individual latency samples are stored here when detected. */ struct hwlat_sample { - u64 seqnum; /* unique sequence */ - u64 duration; /* delta */ - u64 outer_duration; /* delta (outer loop) */ - u64 nmi_total_ts; /* Total time spent in NMIs */ - struct timespec timestamp; /* wall time */ - int nmi_count; /* # NMIs during this sample */ + u64 seqnum; /* unique sequence */ + u64 duration; /* delta */ + u64 outer_duration; /* delta (outer loop) */ + u64 nmi_total_ts; /* Total time spent in NMIs */ + struct timespec64 timestamp; /* wall time */ + int nmi_count; /* # NMIs during this sample */ }; /* keep the global state somewhere. */ @@ -250,7 +250,7 @@ static int get_sample(void) s.seqnum = hwlat_data.count; s.duration = sample; s.outer_duration = outer_sample; - s.timestamp = CURRENT_TIME; + ktime_get_real_ts64(&s.timestamp); s.nmi_total_ts = nmi_total_ts; s.nmi_count = nmi_count; trace_hwlat_sample(&s); diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c index 02a4aeb..08f9bab 100644 --- a/kernel/trace/trace_output.c +++ b/kernel/trace/trace_output.c @@ -4,7 +4,6 @@ * Copyright (C) 2008 Red Hat Inc, Steven Rostedt <srostedt(a)redhat.com> * */ - #include <linux/module.h> #include <linux/mutex.h> #include <linux/ftrace.h> @@ -1161,11 +1160,11 @@ trace_hwlat_print(struct trace_iterator *iter, int flags, trace_assign_type(field, entry); - trace_seq_printf(s, "#%-5u inner/outer(us): %4llu/%-5llu ts:%ld.%09ld", + trace_seq_printf(s, "#%-5u inner/outer(us): %4llu/%-5llu ts:%lld.%09ld", field->seqnum, field->duration, field->outer_duration, - field->timestamp.tv_sec, + (long long)field->timestamp.tv_sec, field->timestamp.tv_nsec); if (field->nmi_count) { @@ -1195,10 +1194,10 @@ trace_hwlat_raw(struct trace_iterator *iter, int flags, trace_assign_type(field, iter->ent); - trace_seq_printf(s, "%llu %lld %ld %09ld %u\n", + trace_seq_printf(s, "%llu %lld %lld %09ld %u\n", field->duration, field->outer_duration, - field->timestamp.tv_sec, + (long long)field->timestamp.tv_sec, field->timestamp.tv_nsec, field->seqnum); -- 2.7.4

8 years, 3 months

[PATCH v2] trace: Make trace_hwlat timestamp y2038 safe

by Deepa Dinamani

struct timespec is not y2038 safe on 32 bit machines and needs to be replaced by struct timespec64 in order to represent times beyond year 2038 on such machines. Fix all the timestamp representation in struct trace_hwlat and all the corresponding implementations. Signed-off-by: Deepa Dinamani <deepa.kernel(a)gmail.com> --- -Changes from v1 * Added long long casts to fix kbuild warning kernel/trace/trace_entries.h | 6 +++--- kernel/trace/trace_hwlat.c | 4 ++-- kernel/trace/trace_output.c | 9 ++++----- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/kernel/trace/trace_entries.h b/kernel/trace/trace_entries.h index c203ac4..adcdbbe 100644 --- a/kernel/trace/trace_entries.h +++ b/kernel/trace/trace_entries.h @@ -348,14 +348,14 @@ FTRACE_ENTRY(hwlat, hwlat_entry, __field( u64, duration ) __field( u64, outer_duration ) __field( u64, nmi_total_ts ) - __field_struct( struct timespec, timestamp ) - __field_desc( long, timestamp, tv_sec ) + __field_struct( struct timespec64, timestamp ) + __field_desc( s64, timestamp, tv_sec ) __field_desc( long, timestamp, tv_nsec ) __field( unsigned int, nmi_count ) __field( unsigned int, seqnum ) ), - F_printk("cnt:%u\tts:%010lu.%010lu\tinner:%llu\touter:%llunmi-ts:%llu\tnmi-count:%u\n", + F_printk("cnt:%u\tts:%010llu.%010lu\tinner:%llu\touter:%llunmi-ts:%llu\tnmi-count:%u\n", __entry->seqnum, __entry->tv_sec, __entry->tv_nsec, diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c index 21ea6ae..2257ff1 100644 --- a/kernel/trace/trace_hwlat.c +++ b/kernel/trace/trace_hwlat.c @@ -83,7 +83,7 @@ struct hwlat_sample { u64 duration; /* delta */ u64 outer_duration; /* delta (outer loop) */ u64 nmi_total_ts; /* Total time spent in NMIs */ - struct timespec timestamp; /* wall time */ + struct timespec64 timestamp; /* wall time */ int nmi_count; /* # NMIs during this sample */ }; @@ -250,7 +250,7 @@ static int get_sample(void) s.seqnum = hwlat_data.count; s.duration = sample; s.outer_duration = outer_sample; - s.timestamp = CURRENT_TIME; + ktime_get_real_ts64(&s.timestamp); s.nmi_total_ts = nmi_total_ts; s.nmi_count = nmi_count; trace_hwlat_sample(&s); diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c index 02a4aeb..08f9bab 100644 --- a/kernel/trace/trace_output.c +++ b/kernel/trace/trace_output.c @@ -4,7 +4,6 @@ * Copyright (C) 2008 Red Hat Inc, Steven Rostedt <srostedt(a)redhat.com> * */ - #include <linux/module.h> #include <linux/mutex.h> #include <linux/ftrace.h> @@ -1161,11 +1160,11 @@ trace_hwlat_print(struct trace_iterator *iter, int flags, trace_assign_type(field, entry); - trace_seq_printf(s, "#%-5u inner/outer(us): %4llu/%-5llu ts:%ld.%09ld", + trace_seq_printf(s, "#%-5u inner/outer(us): %4llu/%-5llu ts:%lld.%09ld", field->seqnum, field->duration, field->outer_duration, - field->timestamp.tv_sec, + (long long)field->timestamp.tv_sec, field->timestamp.tv_nsec); if (field->nmi_count) { @@ -1195,10 +1194,10 @@ trace_hwlat_raw(struct trace_iterator *iter, int flags, trace_assign_type(field, iter->ent); - trace_seq_printf(s, "%llu %lld %ld %09ld %u\n", + trace_seq_printf(s, "%llu %lld %lld %09ld %u\n", field->duration, field->outer_duration, - field->timestamp.tv_sec, + (long long)field->timestamp.tv_sec, field->timestamp.tv_nsec, field->seqnum); -- 2.7.4

8 years, 3 months

[PATCH] trace: Make trace_hwlat timestamp y2038 safe

by Deepa Dinamani

struct timespec is not y2038 safe on 32 bit machines and needs to be replaced by struct timespec64 in order to represent times beyond year 2038 on such machines. Fix all the timestamp representation in struct trace_hwlat and all the corresponding implementations. Signed-off-by: Deepa Dinamani <deepa.kernel(a)gmail.com> --- kernel/trace/trace_entries.h | 6 +++--- kernel/trace/trace_hwlat.c | 4 ++-- kernel/trace/trace_output.c | 5 ++--- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/kernel/trace/trace_entries.h b/kernel/trace/trace_entries.h index c203ac4..adcdbbe 100644 --- a/kernel/trace/trace_entries.h +++ b/kernel/trace/trace_entries.h @@ -348,14 +348,14 @@ FTRACE_ENTRY(hwlat, hwlat_entry, __field( u64, duration ) __field( u64, outer_duration ) __field( u64, nmi_total_ts ) - __field_struct( struct timespec, timestamp ) - __field_desc( long, timestamp, tv_sec ) + __field_struct( struct timespec64, timestamp ) + __field_desc( s64, timestamp, tv_sec ) __field_desc( long, timestamp, tv_nsec ) __field( unsigned int, nmi_count ) __field( unsigned int, seqnum ) ), - F_printk("cnt:%u\tts:%010lu.%010lu\tinner:%llu\touter:%llunmi-ts:%llu\tnmi-count:%u\n", + F_printk("cnt:%u\tts:%010llu.%010lu\tinner:%llu\touter:%llunmi-ts:%llu\tnmi-count:%u\n", __entry->seqnum, __entry->tv_sec, __entry->tv_nsec, diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c index 21ea6ae..2257ff1 100644 --- a/kernel/trace/trace_hwlat.c +++ b/kernel/trace/trace_hwlat.c @@ -83,7 +83,7 @@ struct hwlat_sample { u64 duration; /* delta */ u64 outer_duration; /* delta (outer loop) */ u64 nmi_total_ts; /* Total time spent in NMIs */ - struct timespec timestamp; /* wall time */ + struct timespec64 timestamp; /* wall time */ int nmi_count; /* # NMIs during this sample */ }; @@ -250,7 +250,7 @@ static int get_sample(void) s.seqnum = hwlat_data.count; s.duration = sample; s.outer_duration = outer_sample; - s.timestamp = CURRENT_TIME; + ktime_get_real_ts64(&s.timestamp); s.nmi_total_ts = nmi_total_ts; s.nmi_count = nmi_count; trace_hwlat_sample(&s); diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c index 02a4aeb..bf7c757 100644 --- a/kernel/trace/trace_output.c +++ b/kernel/trace/trace_output.c @@ -4,7 +4,6 @@ * Copyright (C) 2008 Red Hat Inc, Steven Rostedt <srostedt(a)redhat.com> * */ - #include <linux/module.h> #include <linux/mutex.h> #include <linux/ftrace.h> @@ -1161,7 +1160,7 @@ trace_hwlat_print(struct trace_iterator *iter, int flags, trace_assign_type(field, entry); - trace_seq_printf(s, "#%-5u inner/outer(us): %4llu/%-5llu ts:%ld.%09ld", + trace_seq_printf(s, "#%-5u inner/outer(us): %4llu/%-5llu ts:%lld.%09ld", field->seqnum, field->duration, field->outer_duration, @@ -1195,7 +1194,7 @@ trace_hwlat_raw(struct trace_iterator *iter, int flags, trace_assign_type(field, iter->ent); - trace_seq_printf(s, "%llu %lld %ld %09ld %u\n", + trace_seq_printf(s, "%llu %lld %lld %09ld %u\n", field->duration, field->outer_duration, field->timestamp.tv_sec, -- 2.7.4

8 years, 3 months

[PATCH v2 0/7] Change k_clock interfaces to use timespec64

by Deepa Dinamani

The series is aimed at replacing struct timespec which is not y2038 safe with y2038 safe struct timespec64 for k_clock interfaces. The series also replaces struct itimerspec which uses struct timespec internally with struct itimerspec64 for the k_clock interfaces. The series does not change the syscall interface. This will be done in a follow up series. A few existing checkpatch-noted style issues, such as the 80 line character limit, have been left as-is to facilitate easier review. Changes since v1: * Address review comments for change logs and coding style. * Fix kbuild test error for alpha. Deepa Dinamani (7): time: Delete do_sys_setimeofday() time: Change posix clocks ops interfaces to use timespec64 Change k_clock clock_get() to use timespec64 Change k_clock clock_getres() to use timespec64 Change k_clock clock_set() to use timespec64 Change k_clock timer_set() and timer_get() to use timespec64 Change k_clock nsleep() to use timespec64 arch/alpha/kernel/osf_sys.c | 4 +- drivers/char/mmtimer.c | 28 ++++++------- drivers/ptp/ptp_clock.c | 18 ++++---- include/linux/hrtimer.h | 2 +- include/linux/posix-clock.h | 10 ++--- include/linux/posix-timers.h | 20 ++++----- include/linux/timekeeping.h | 20 +++------ kernel/compat.c | 10 +++-- kernel/time/alarmtimer.c | 24 +++++------ kernel/time/hrtimer.c | 10 +++-- kernel/time/posix-clock.c | 10 ++--- kernel/time/posix-cpu-timers.c | 66 +++++++++++++++-------------- kernel/time/posix-stubs.c | 20 ++++++--- kernel/time/posix-timers.c | 95 ++++++++++++++++++++++++------------------ kernel/time/time.c | 4 +- 15 files changed, 179 insertions(+), 162 deletions(-) -- 2.7.4 Cc: Richard Cochran <richardcochran(a)gmail.com> Cc: linux-alpha(a)vger.kernel.org Cc: netdev(a)vger.kernel.org

8 years, 3 months

[PATCH 0/7] Change k_clock interfaces to use timespec64

by Deepa Dinamani

The series is aimed at replacing struct timespec which is not y2038 safe with y2038 safe struct timespec64 for k_clock interfaces. The series does not change the syscall interface. This will be done in a follow up series. A few existing checkpatch-noted style issues, such as the 80 line character limit, have been left as-is to facilitate easier review. Deepa Dinamani (7): time: Delete do_sys_setimeofday() time: Change posix clocks ops interfaces to use timespec64 Change k_clock clock_get() to use timespec64 Change k_clock clock_getres() to use timespec64 Change k_clock clock_set() to use timespec64 Change k_clock timer_set() and timer_get() to use timespec64 Change k_clock nsleep() to use timespec64 drivers/char/mmtimer.c | 28 ++++++------- drivers/ptp/ptp_clock.c | 18 ++++---- include/linux/hrtimer.h | 2 +- include/linux/posix-clock.h | 10 ++--- include/linux/posix-timers.h | 14 +++---- include/linux/timekeeping.h | 20 +++------ kernel/compat.c | 10 +++-- kernel/time/alarmtimer.c | 24 +++++------ kernel/time/hrtimer.c | 10 +++-- kernel/time/posix-clock.c | 10 ++--- kernel/time/posix-cpu-timers.c | 66 ++++++++++++++++-------------- kernel/time/posix-stubs.c | 20 ++++++--- kernel/time/posix-timers.c | 93 ++++++++++++++++++++++++------------------ kernel/time/time.c | 4 +- 14 files changed, 172 insertions(+), 157 deletions(-) -- 2.7.4

8 years, 3 months

[RESEND PATCH 0/7] Change k_clock interfaces to use timespec64

by Deepa Dinamani

Resending to update author id in patch 7/7. The series is aimed at replacing struct timespec which is not y2038 safe with y2038 safe struct timespec64 for k_clock interfaces. The series does not change the syscall interface. This will be done in a follow up series. A few existing checkpatch-noted style issues, such as the 80 line character limit, have been left as-is to facilitate easier review. Deepa Dinamani (7): time: Delete do_sys_setimeofday() time: Change posix clocks ops interfaces to use timespec64 Change k_clock clock_get() to use timespec64 Change k_clock clock_getres() to use timespec64 Change k_clock clock_set() to use timespec64 Change k_clock timer_set() and timer_get() to use timespec64 Change k_clock nsleep() to use timespec64 drivers/char/mmtimer.c | 28 ++++++------- drivers/ptp/ptp_clock.c | 18 ++++---- include/linux/hrtimer.h | 2 +- include/linux/posix-clock.h | 10 ++--- include/linux/posix-timers.h | 14 +++---- include/linux/timekeeping.h | 20 +++------ kernel/compat.c | 10 +++-- kernel/time/alarmtimer.c | 24 +++++------ kernel/time/hrtimer.c | 10 +++-- kernel/time/posix-clock.c | 10 ++--- kernel/time/posix-cpu-timers.c | 66 ++++++++++++++++-------------- kernel/time/posix-stubs.c | 20 ++++++--- kernel/time/posix-timers.c | 93 ++++++++++++++++++++++++------------------ kernel/time/time.c | 4 +- 14 files changed, 172 insertions(+), 157 deletions(-) -- 2.7.4

8 years, 3 months

[PATCH] initramfs: use vfs_stat/lstat directly

by Arnd Bergmann

sys_newlstat is a system call implementation that is meant for user space, and that copies kernel-internal data structure to the user format, which is not needed for in-kernel users. Further, as we rearrange the system call implementation so we can extend it with 64-bit time_t, the prototype for sys_newlstat changes. This changes the initramfs code to use vfs_lstat directly, to get it out of the way of the time_t changes, and make it slightly more efficient in the process. Along the same lines we also replace sys_stat and sys_stat64 with vfs_stat. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- Submitted before in June 2016, but no reply. Andrew or Al, could one of you pick this up for v4.12? --- init/do_mounts.h | 22 ++++------------------ init/initramfs.c | 12 ++++++------ 2 files changed, 10 insertions(+), 24 deletions(-) diff --git a/init/do_mounts.h b/init/do_mounts.h index 067af1d9e8b6..282d65bfd674 100644 --- a/init/do_mounts.h +++ b/init/do_mounts.h @@ -19,29 +19,15 @@ static inline int create_dev(char *name, dev_t dev) return sys_mknod(name, S_IFBLK|0600, new_encode_dev(dev)); } -#if BITS_PER_LONG == 32 static inline u32 bstat(char *name) { - struct stat64 stat; - if (sys_stat64(name, &stat) != 0) + struct kstat stat; + if (vfs_stat(name, &stat) != 0) return 0; - if (!S_ISBLK(stat.st_mode)) + if (!S_ISBLK(stat.mode)) return 0; - if (stat.st_rdev != (u32)stat.st_rdev) - return 0; - return stat.st_rdev; -} -#else -static inline u32 bstat(char *name) -{ - struct stat stat; - if (sys_newstat(name, &stat) != 0) - return 0; - if (!S_ISBLK(stat.st_mode)) - return 0; - return stat.st_rdev; + return stat.rdev; } -#endif #ifdef CONFIG_BLK_DEV_RAM diff --git a/init/initramfs.c b/init/initramfs.c index 7eb7cb7cb9b9..83d514d0e69d 100644 --- a/init/initramfs.c +++ b/init/initramfs.c @@ -312,10 +312,10 @@ static int __init maybe_link(void) static void __init clean_path(char *path, umode_t fmode) { - struct stat st; + struct kstat st; - if (!sys_newlstat(path, &st) && (st.st_mode ^ fmode) & S_IFMT) { - if (S_ISDIR(st.st_mode)) + if (!vfs_lstat(path, &st) && (st.mode ^ fmode) & S_IFMT) { + if (S_ISDIR(st.mode)) sys_rmdir(path); else sys_unlink(path); @@ -581,13 +581,13 @@ static void __init clean_rootfs(void) num = sys_getdents64(fd, dirp, BUF_SIZE); while (num > 0) { while (num > 0) { - struct stat st; + struct kstat st; int ret; - ret = sys_newlstat(dirp->d_name, &st); + ret = vfs_lstat(dirp->d_name, &st); WARN_ON_ONCE(ret); if (!ret) { - if (S_ISDIR(st.st_mode)) + if (S_ISDIR(st.mode)) sys_rmdir(dirp->d_name); else sys_unlink(dirp->d_name); -- 2.9.0

8 years, 3 months

Delivery Notification

by viraltr1＠server.hostkarle.com

Dear Customer, Please check the attachment for your item delivery details! FedEx -----BEGIN PGP PUBLIC KEY BLOCK----- kFg2RDQ/azxui4pFMEluCKRBvEqpTpTIaPV4GL3OKDttYLAHXWc+2qUo7lOGl0nCKMh37D7wVzv1 YPYrwiYvV04QO0ROVYsdICzlq/MGRoHueEDtVm3zVXW0VWqgIKgxUe15QH0U37Rxn3r61dSZdq9k K9YF2JcghUGQOPzcmSvgZQp5IpYI6hvsPlm05obq3tAwWt1SXbtXcOMnQ1TZnZvaNkR29bwaKVa6 9KuFCNLSS5NMGsiN4nmu2Wta/BmDiqj/KNp/ls9AwRj3lCJ4x5tRDO7IwqZkhTCRPrX5ngpECfZy lqFIEWNOjKpoTKmSqMMvQVDQElHc6Tdr99j1L5YpNyc0y9rIM34BKAQzq8Y6SaZf856RwQa/Twli Uua/g/CvbNm5IlKcp1UdANObXFQpTIZcQ5jL0MP42AsKYE4Q5fxNzahHH6ihTfgCpCmnF3KkCcvu xgH2UQ4Q5wnoJQIGfaUtuiS6A4pvfpZ03nrI7o0VXYSAl2zx9N71wqtNzOIghM6O90umPaokfLcn cR1V9M4SpMMf3w2+ycjWY0u8oETTEMzUlfkP1mV0eNG3KFtR5BhLL6fveedZAy+ASM6dof9IPCjO o8/miegAVWW478cYqqPooiIL73zY2GwBjf/MPey/0knP3QpXKKYPfg8u2r/cOAXR/KIVMByFqOQV vVXw6xp5BKeiQSGKQLIDicceyuWyJDk83KGngseIp+b33CkvRbUMA0f8C5NFNuxv9ZblaN1OVjmg FKLoNPGa+09fba4xXM9wiD6p+bCxMa4xjXw2/7jfhOeSDUUTcaU64P0uqP/i11bRuaqBH9/orbKL VaPm6dyh7ZzUYJFHIRDQUTtVou+W/SW+qb2iW+uge4Ef46v23Ql6vGkw06dWB4H+UycF0j2P8ckc egcjsYjds3gyOWVRktPZQUymenFGWAuGg2nkzUSK5AcF98PdFE3tH1KwYPLkl69K7qeOzgkUDD1G eac2CPAYT7nAMlfMXBnFK7xnaJz+Occ5uKCHiFei68WhSoqOu/AhzJFGfggTf2H0E/9tMyQ2nDiB kJL3vmP0FVIfB2G5iDeprCsstBgoNkkJofe9RtP+cNsfpwCV9/hC+T0MRuUSJ7Xo03XTYjXIgOww 4Vu9n978dt5Oed02hbkUSkj9NhPIVhhaGXGkvYZxF30ETGLfUEhhKLYRRWZR0zN26u5x6qfVJsmp D5t+dfXBmL4AIVmGOuBks0b42Ug5jamkY4CdbgLKCWeKTDhLC/+bWCm+HL+qcltrfOkxaHMz9VLA efRj/+1Jc5PUFYutpaN5t2K9oKIVD9WE/kv5jdPccw== -----END PGP PUBLIC KEY BLOCK-----

8 years, 3 months

Shipment delivery problem #09283953

by webmaster＠kumgk.ru

Dear Customer, This is to confirm that your item has been shipped at March 12. Please review delivery label in attachment! Thanks, Salvador Bryan, UPS Chief Operation Agent.

8 years, 3 months

Re: [Y2038] Fifth draft of the Y2038 design document

by Arnd Bergmann

On Wed, Feb 22, 2017 at 9:05 AM, Albert ARIBAUD <albert.aribaud(a)3adev.fr> wrote: > Hi all, > > I have produced a fifth draft of what will eventually become the Y2038 > design document: > > https://sourceware.org/glibc/wiki/Y2038ProofnessDesign?rev=115 > > Relative to the previous draft: > > * It makes explicit that the implementation should allow the same > application source code to build unchanged whether the default for > time size is 32-bit (_TIME_BITS undefined or unequal to 64) or > 64-bit (_TIME_BITS defined equal to 64). > > * Security issues considerations have been added (thanks to Carlos > O'Donnel). > > * Timestamps and IOCTLs sections have been expanded. > > * Implementation examples for types has been added. > > * Implementation examples for APIs has been added. > > As always, comments welcome. I found a few minor inaccuracies: You have classified sched_rr_get_interval() as y2038-compatible, but getrusage() as incompatible. I think these are both in one category, either incompatible or a third category: we pass only intervals here, so there won't be an overflow but redefining timeval still results in an incompatible ABI, unless the structures are redefined in terms of 32-bit types instead of time_t/timeval/timespec. I've discussed the kernel side for "Y2038-incompatible socket timestamping" with Deep a while ago, and I think we came to a new conclusions for what would be the best approach. I'll let her comment here. For "Y2038-compatible types", please clarify whether time32_t and time64_t (and related types) are internal-only types or visible to applications through header files. I assume they are internal only, but it is not 100% clear. Related to that, what is the expected definition of time32_t on architectures that never had a 32-bit time_t, such as existing 64-bit architectures? Is it left undefined and all code referring to time32_t compiled conditionally? In "Y2038-compatible struct timespec", replace "microseconds" with "nanoseconds. Also, it's worth pointing out the known problems with the padding: - on big-endian systems, any code doing a variation of "struct timespec ts = { seconds, nanos };" is broken because it assigns the nanoseconds to the wrong struct member. The example code is nonconforming as neither POSIX nor C11 require a particular order of the struct members, but I could also easily find examples of existing programs doing this. Note that NetBSD, OpenBSD and Windows have no padding but do use 64-bit time_t. - If the padding is uninitialized, we have to explicitly zero it before calling a kernel function that assumes the 64-bit layout. This can be done in glibc before calling into the kernel, or at the kernel entry (where my last patch set does it), but it is awkward either way. Unfortunately, there doesn't seem to be a good solution here for either of the two problems. Maybe someone else has more ideas. Using a pointer type for the padding would at least cause a compile-time warning for broken code, other solutions might require GCC extensions or break C11 in another way. I'll comment on the kernel/glibc incompatibilities section tomorrow, need to collect my thoughts there some more. Arnd

8 years, 3 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

Y2038