Re: [Y2038] [PATCH v1 06/14] time:Introduce the do_sys_settimeofday64() function with timespec64 type

OK, Thanks.

On 28 April 2015 at 17:44, Arnd Bergmann arnd@linaro.org wrote:

On Tuesday 28 April 2015 16:05:48 Baolin Wang wrote:

...

This patch introduces the do_sys_settimeofday64() function with

timespec64

...

type, that makes this function ready for 2038 issue when setting the

time of day.

...

Signed-off-by: Baolin Wang baolin.wang@linaro.org

The patch looks correct, just one cosmetic comment:

...

+int do_sys_settimeofday(const struct timespec *tv, const struct

timezone *tz)

...

+{

• struct timespec64 ts64;
  

• ts64 = timespec_to_timespec64(*tv);
  

• return do_sys_settimeofday64(&ts64, tz);
  

+}

I would put this function into the header file as a 'static inline' to replace the declaration, to make it more consistent with what we do for a lot of the other functions.

    Arnd