12 Dec
2019
12 Dec
'19
4:27 p.m.
On Thu, Dec 12, 2019 at 01:28:08AM +0100, Paolo Bonzini wrote:
I think it's because the only ioctl for virtio-blk is SG_IO. It makes sense to lump it in with scsi, but I wouldn't mind getting rid of CONFIG_VIRTIO_BLK_SCSI altogether.
CONFIG_VIRTIO_BLK_SCSI has been broken for about two years, as it never set the QUEUE_FLAG_SCSI_PASSTHROUGH flag after that was introduced. I actually have a patch that I plan to send to remove this support as it was a really idea to start with (speaking as the person who had that idea back in the day).