CoreSight July 2025

coresight@lists.linaro.org

9 participants
34 discussions

[PATCH v9 0/2] coresight: Add label sysfs node support

by Mao Jinlong

Change since V8: 1. Add label in all documentations of coresight components. 2. Add control of the visibility of the label sysfs attribute. V8 link: https://lkml.org/lkml/2025/7/3/985 Change since V7: 1. Update the conflict when apply to coresight next. 2. Update the Date and version in ABI file. V7 link: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20250226121926.… Change since V6: 1. Update the date and verison in ABI file. Change since V5: 1. Update the kernel version of ABI files. 2. Add link of different patch versions. V5 link: https://patchwork.kernel.org/project/linux-arm-msm/cover/20241210122253.319… Change since V4: 1. Add label in DT and add label sysfs node for each coresight device. V4 link: https://patchwork.kernel.org/project/linux-arm-msm/cover/20240703122340.268… Change since V3: 1. Change device-name to arm,cs-dev-name. 2. Add arm,cs-dev-name to only CTI and sources' dt-binding. V3 link: https://patchwork.kernel.org/project/linux-arm-msm/cover/20240131082628.628… Change since V2: 1. Fix the error in coresight core. drivers/hwtracing/coresight/coresight-core.c:1775:7: error: assigning to 'char *' from 'const char *' discards qualifiers 2. Fix the warning when run dtbinding check. Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml: device-name: missing type definition V2 link: https://patchwork.kernel.org/project/linux-arm-msm/cover/20240115164252.265… Change since V1: 1. Change coresight-name to device name. 2. Add the device-name in coresight dt bindings. V1 link: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20230208110716.… Mao Jinlong (2): dt-bindings: arm: Add label in the coresight components coresight: Add label sysfs node support .../testing/sysfs-bus-coresight-devices-cti | 6 ++ .../sysfs-bus-coresight-devices-dummy-source | 6 ++ .../testing/sysfs-bus-coresight-devices-etb10 | 6 ++ .../testing/sysfs-bus-coresight-devices-etm3x | 6 ++ .../testing/sysfs-bus-coresight-devices-etm4x | 6 ++ .../sysfs-bus-coresight-devices-funnel | 6 ++ .../testing/sysfs-bus-coresight-devices-stm | 6 ++ .../testing/sysfs-bus-coresight-devices-tmc | 6 ++ .../testing/sysfs-bus-coresight-devices-tpdm | 6 ++ .../testing/sysfs-bus-coresight-devices-trbe | 6 ++ .../bindings/arm/arm,coresight-cti.yaml | 4 ++ .../arm/arm,coresight-dummy-sink.yaml | 4 ++ .../arm/arm,coresight-dummy-source.yaml | 4 ++ .../arm/arm,coresight-dynamic-funnel.yaml | 4 ++ .../arm/arm,coresight-dynamic-replicator.yaml | 4 ++ .../bindings/arm/arm,coresight-etb10.yaml | 4 ++ .../bindings/arm/arm,coresight-etm.yaml | 4 ++ .../arm/arm,coresight-static-funnel.yaml | 4 ++ .../arm/arm,coresight-static-replicator.yaml | 4 ++ .../bindings/arm/arm,coresight-tmc.yaml | 4 ++ .../bindings/arm/arm,coresight-tpiu.yaml | 4 ++ .../bindings/arm/qcom,coresight-ctcu.yaml | 4 ++ .../arm/qcom,coresight-remote-etm.yaml | 4 ++ .../bindings/arm/qcom,coresight-tpda.yaml | 4 ++ .../bindings/arm/qcom,coresight-tpdm.yaml | 4 ++ drivers/hwtracing/coresight/coresight-sysfs.c | 71 ++++++++++++++++++- 26 files changed, 189 insertions(+), 2 deletions(-) -- 2.25.1

4 days, 21 hours

[PATCH v8 0/2] coresight: Add label sysfs node support

by Mao Jinlong

Change since V7: 1. Update the conflict when apply to coresight next. 2. Update the Date and version in ABI file. V7 link: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20250226121926.… Change since V6: 1. Update the date and verison in ABI file. Change since V5: 1. Update the kernel version of ABI files. 2. Add link of different patch versions. V5 link: https://patchwork.kernel.org/project/linux-arm-msm/cover/20241210122253.319… Change since V4: 1. Add label in DT and add label sysfs node for each coresight device. V4 link: https://patchwork.kernel.org/project/linux-arm-msm/cover/20240703122340.268… Change since V3: 1. Change device-name to arm,cs-dev-name. 2. Add arm,cs-dev-name to only CTI and sources' dt-binding. V3 link: https://patchwork.kernel.org/project/linux-arm-msm/cover/20240131082628.628… Change since V2: 1. Fix the error in coresight core. drivers/hwtracing/coresight/coresight-core.c:1775:7: error: assigning to 'char *' from 'const char *' discards qualifiers 2. Fix the warning when run dtbinding check. Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml: device-name: missing type definition V2 link: https://patchwork.kernel.org/project/linux-arm-msm/cover/20240115164252.265… Change since V1: 1. Change coresight-name to device name. 2. Add the device-name in coresight dt bindings. V1 link: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20230208110716.… Mao Jinlong (2): dt-bindings: arm: Add label in the coresight components coresight: Add label sysfs node support .../testing/sysfs-bus-coresight-devices-cti | 6 ++++ .../sysfs-bus-coresight-devices-funnel | 6 ++++ .../testing/sysfs-bus-coresight-devices-tpdm | 6 ++++ .../bindings/arm/arm,coresight-cti.yaml | 6 ++++ .../arm/arm,coresight-dummy-sink.yaml | 6 ++++ .../arm/arm,coresight-dummy-source.yaml | 6 ++++ .../arm/arm,coresight-dynamic-funnel.yaml | 6 ++++ .../arm/arm,coresight-dynamic-replicator.yaml | 6 ++++ .../arm/arm,coresight-static-funnel.yaml | 6 ++++ .../arm/arm,coresight-static-replicator.yaml | 6 ++++ .../bindings/arm/arm,coresight-tmc.yaml | 6 ++++ .../bindings/arm/qcom,coresight-tpda.yaml | 6 ++++ .../bindings/arm/qcom,coresight-tpdm.yaml | 6 ++++ drivers/hwtracing/coresight/coresight-sysfs.c | 32 +++++++++++++++++++ 14 files changed, 110 insertions(+) -- 2.17.1

5 days, 7 hours

Re: [PATCH v3 RESEND 01/10] coresight: core: Refactoring ctcu_get_active_port and make it generic

by Mike Leach

Hi, On Mon, 14 Jul 2025 at 07:31, Jie Gan <jie.gan(a)oss.qualcomm.com> wrote: > > Remove ctcu_get_active_port from CTCU module and add it to the core > framework. > > The port number is crucial for the CTCU device to identify which ETR > it serves. With the port number we can correctly get required parameters > of the CTCU device in TMC module. > > Signed-off-by: Jie Gan <jie.gan(a)oss.qualcomm.com> > --- > drivers/hwtracing/coresight/coresight-core.c | 24 +++++++++++++++++++ > .../hwtracing/coresight/coresight-ctcu-core.c | 19 +-------------- > drivers/hwtracing/coresight/coresight-priv.h | 2 ++ > 3 files changed, 27 insertions(+), 18 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 1accd7cbd54b..5297a5ff7921 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -580,6 +580,30 @@ struct coresight_device *coresight_get_sink(struct coresight_path *path) > } > EXPORT_SYMBOL_GPL(coresight_get_sink); > > +/** > + * coresight_get_port_helper: get the in-port number of the helper device > + * that is connected to the csdev. > + * As written this looks at all connections, not just those that are helpers. That is fine, so perhaps rename as such. e.g. coresight_get_in_port_dest and name the input parameters src , dest respectively. > + * @csdev: csdev of the device that is connected to helper. > + * @helper: csdev of the helper device. > + * > + * Return: port number upson success or -EINVAL for fail. sp: upon/upson > + */ > +int coresight_get_port_helper(struct coresight_device *csdev, > + struct coresight_device *helper) > +{ > + struct coresight_platform_data *pdata = helper->pdata; > + int i; > + > + for (i = 0; i < pdata->nr_inconns; ++i) { > + if (pdata->in_conns[i]->src_dev == csdev) > + return pdata->in_conns[i]->dest_port; > + } > + > + return -EINVAL; > +} > +EXPORT_SYMBOL_GPL(coresight_get_port_helper); > + > u32 coresight_get_sink_id(struct coresight_device *csdev) > { > if (!csdev->ea) > diff --git a/drivers/hwtracing/coresight/coresight-ctcu-core.c b/drivers/hwtracing/coresight/coresight-ctcu-core.c > index c6bafc96db96..28ea4a216345 100644 > --- a/drivers/hwtracing/coresight/coresight-ctcu-core.c > +++ b/drivers/hwtracing/coresight/coresight-ctcu-core.c > @@ -118,23 +118,6 @@ static int __ctcu_set_etr_traceid(struct coresight_device *csdev, u8 traceid, in > return 0; > } > > -/* > - * Searching the sink device from helper's view in case there are multiple helper devices > - * connected to the sink device. > - */ > -static int ctcu_get_active_port(struct coresight_device *sink, struct coresight_device *helper) > -{ > - struct coresight_platform_data *pdata = helper->pdata; > - int i; > - > - for (i = 0; i < pdata->nr_inconns; ++i) { > - if (pdata->in_conns[i]->src_dev == sink) > - return pdata->in_conns[i]->dest_port; > - } > - > - return -EINVAL; > -} > - > static int ctcu_set_etr_traceid(struct coresight_device *csdev, struct coresight_path *path, > bool enable) > { > @@ -147,7 +130,7 @@ static int ctcu_set_etr_traceid(struct coresight_device *csdev, struct coresight > return -EINVAL; > } > > - port_num = ctcu_get_active_port(sink, csdev); > + port_num = coresight_get_port_helper(sink, csdev); > if (port_num < 0) > return -EINVAL; > > diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h > index 33e22b1ba043..07a5f03de81d 100644 > --- a/drivers/hwtracing/coresight/coresight-priv.h > +++ b/drivers/hwtracing/coresight/coresight-priv.h > @@ -156,6 +156,8 @@ void coresight_remove_links(struct coresight_device *orig, > u32 coresight_get_sink_id(struct coresight_device *csdev); > void coresight_path_assign_trace_id(struct coresight_path *path, > enum cs_mode mode); > +int coresight_get_port_helper(struct coresight_device *csdev, > + struct coresight_device *helper); > rename here too > #if IS_ENABLED(CONFIG_CORESIGHT_SOURCE_ETM3X) > int etm_readl_cp14(u32 off, unsigned int *val); > -- > 2.34.1 > regards Mike -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK

5 days, 23 hours

Re: [PATCH v3] coresight: Replace scnprintf() with sysfs_emit() in sysfs show functions

by Mike Leach

Hi, If this change is to be made, which is a high degree of churn for no functional difference, then it should be comprehensive. The sysfs _show() functions in coresight_ /cti_sysfs.c / tmc_core.c / trbe.c / funnel.c, which all use sprintf in the show() function should be included On Wed, 9 Jul 2025 at 18:17, Chelsy Ratnawat <chelsyratnawat2001(a)gmail.com> wrote: > > Documentation/filesystems/sysfs.rst mentions that show() should only > use sysfs_emit() or sysfs_emit_at() when formating the value to be > returned to user space. So replace scnprintf() with sysfs_emit(). > > Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001(a)gmail.com> > Reviewed-by: James Clark <james.clark(a)linaro.org> > --- > Changes in v3: > - fixed warnings from checkpatch.pl > > .../hwtracing/coresight/coresight-etm-perf.c | 4 +- > .../coresight/coresight-etm3x-sysfs.c | 2 +- > .../coresight/coresight-etm4x-sysfs.c | 118 +++++++++--------- > drivers/hwtracing/coresight/coresight-stm.c | 8 +- > drivers/hwtracing/coresight/coresight-sysfs.c | 4 +- > 5 files changed, 68 insertions(+), 68 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c > index f1551c08ecb2..8cfdcbc2f8f6 100644 > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > @@ -851,7 +851,7 @@ static ssize_t etm_perf_sink_name_show(struct device *dev, > struct dev_ext_attribute *ea; > > ea = container_of(dattr, struct dev_ext_attribute, attr); > - return scnprintf(buf, PAGE_SIZE, "0x%lx\n", (unsigned long)(ea->var)); > + return sysfs_emit(buf, "0x%lx\n", (unsigned long)(ea->var)); > } > > static struct dev_ext_attribute * > @@ -943,7 +943,7 @@ static ssize_t etm_perf_cscfg_event_show(struct device *dev, > struct dev_ext_attribute *ea; > > ea = container_of(dattr, struct dev_ext_attribute, attr); > - return scnprintf(buf, PAGE_SIZE, "configid=0x%lx\n", (unsigned long)(ea->var)); > + return sysfs_emit(buf, "configid=0x%lx\n", (unsigned long)(ea->var)); > } > > int etm_perf_add_symlink_cscfg(struct device *dev, struct cscfg_config_desc *config_desc) > diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c > index 762109307b86..4868eb05a312 100644 > --- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c > @@ -1182,7 +1182,7 @@ static ssize_t cpu_show(struct device *dev, > struct etm_drvdata *drvdata = dev_get_drvdata(dev->parent); > > val = drvdata->cpu; > - return scnprintf(buf, PAGE_SIZE, "%d\n", val); > + return sysfs_emit(buf, "%d\n", val); > > } > static DEVICE_ATTR_RO(cpu); > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > index ab251865b893..4ddc0d344b61 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > @@ -63,7 +63,7 @@ static ssize_t nr_pe_cmp_show(struct device *dev, > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > > val = drvdata->nr_pe_cmp; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > static DEVICE_ATTR_RO(nr_pe_cmp); > > @@ -75,7 +75,7 @@ static ssize_t nr_addr_cmp_show(struct device *dev, > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > > val = drvdata->nr_addr_cmp; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > static DEVICE_ATTR_RO(nr_addr_cmp); > > @@ -87,7 +87,7 @@ static ssize_t nr_cntr_show(struct device *dev, > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > > val = drvdata->nr_cntr; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > static DEVICE_ATTR_RO(nr_cntr); > > @@ -99,7 +99,7 @@ static ssize_t nr_ext_inp_show(struct device *dev, > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > > val = drvdata->nr_ext_inp; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > static DEVICE_ATTR_RO(nr_ext_inp); > > @@ -111,7 +111,7 @@ static ssize_t numcidc_show(struct device *dev, > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > > val = drvdata->numcidc; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > static DEVICE_ATTR_RO(numcidc); > > @@ -123,7 +123,7 @@ static ssize_t numvmidc_show(struct device *dev, > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > > val = drvdata->numvmidc; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > static DEVICE_ATTR_RO(numvmidc); > > @@ -135,7 +135,7 @@ static ssize_t nrseqstate_show(struct device *dev, > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > > val = drvdata->nrseqstate; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > static DEVICE_ATTR_RO(nrseqstate); > > @@ -147,7 +147,7 @@ static ssize_t nr_resource_show(struct device *dev, > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > > val = drvdata->nr_resource; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > static DEVICE_ATTR_RO(nr_resource); > > @@ -159,7 +159,7 @@ static ssize_t nr_ss_cmp_show(struct device *dev, > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > > val = drvdata->nr_ss_cmp; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > static DEVICE_ATTR_RO(nr_ss_cmp); > > @@ -287,7 +287,7 @@ static ssize_t mode_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->mode; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t mode_store(struct device *dev, > @@ -453,7 +453,7 @@ static ssize_t pe_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->pe_sel; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t pe_store(struct device *dev, > @@ -488,7 +488,7 @@ static ssize_t event_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->eventctrl0; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t event_store(struct device *dev, > @@ -537,7 +537,7 @@ static ssize_t event_instren_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = FIELD_GET(TRCEVENTCTL1R_INSTEN_MASK, config->eventctrl1); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t event_instren_store(struct device *dev, > @@ -593,7 +593,7 @@ static ssize_t event_ts_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->ts_ctrl; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t event_ts_store(struct device *dev, > @@ -623,7 +623,7 @@ static ssize_t syncfreq_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->syncfreq; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t syncfreq_store(struct device *dev, > @@ -653,7 +653,7 @@ static ssize_t cyc_threshold_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->ccctlr; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t cyc_threshold_store(struct device *dev, > @@ -686,7 +686,7 @@ static ssize_t bb_ctrl_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->bb_ctrl; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t bb_ctrl_store(struct device *dev, > @@ -726,7 +726,7 @@ static ssize_t event_vinst_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = FIELD_GET(TRCVICTLR_EVENT_MASK, config->vinst_ctrl); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t event_vinst_store(struct device *dev, > @@ -758,7 +758,7 @@ static ssize_t s_exlevel_vinst_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = FIELD_GET(TRCVICTLR_EXLEVEL_S_MASK, config->vinst_ctrl); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t s_exlevel_vinst_store(struct device *dev, > @@ -793,7 +793,7 @@ static ssize_t ns_exlevel_vinst_show(struct device *dev, > > /* EXLEVEL_NS, bits[23:20] */ > val = FIELD_GET(TRCVICTLR_EXLEVEL_NS_MASK, config->vinst_ctrl); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t ns_exlevel_vinst_store(struct device *dev, > @@ -827,7 +827,7 @@ static ssize_t addr_idx_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->addr_idx; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t addr_idx_store(struct device *dev, > @@ -866,11 +866,11 @@ static ssize_t addr_instdatatype_show(struct device *dev, > raw_spin_lock(&drvdata->spinlock); > idx = config->addr_idx; > val = FIELD_GET(TRCACATRn_TYPE_MASK, config->addr_acc[idx]); > - len = scnprintf(buf, PAGE_SIZE, "%s\n", > - val == TRCACATRn_TYPE_ADDR ? "instr" : > - (val == TRCACATRn_TYPE_DATA_LOAD_ADDR ? "data_load" : > - (val == TRCACATRn_TYPE_DATA_STORE_ADDR ? "data_store" : > - "data_load_store"))); > + len = sysfs_emit(buf, "%s\n", > + val == TRCACATRn_TYPE_ADDR ? "instr" : > + (val == TRCACATRn_TYPE_DATA_LOAD_ADDR ? "data_load" : > + (val == TRCACATRn_TYPE_DATA_STORE_ADDR ? "data_store" : > + "data_load_store"))); > raw_spin_unlock(&drvdata->spinlock); > return len; > } > @@ -918,7 +918,7 @@ static ssize_t addr_single_show(struct device *dev, > } > val = (unsigned long)config->addr_val[idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t addr_single_store(struct device *dev, > @@ -974,7 +974,7 @@ static ssize_t addr_range_show(struct device *dev, > val1 = (unsigned long)config->addr_val[idx]; > val2 = (unsigned long)config->addr_val[idx + 1]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx %#lx\n", val1, val2); > + return sysfs_emit(buf, "%#lx %#lx\n", val1, val2); > } > > static ssize_t addr_range_store(struct device *dev, > @@ -1049,7 +1049,7 @@ static ssize_t addr_start_show(struct device *dev, > > val = (unsigned long)config->addr_val[idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t addr_start_store(struct device *dev, > @@ -1104,7 +1104,7 @@ static ssize_t addr_stop_show(struct device *dev, > > val = (unsigned long)config->addr_val[idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t addr_stop_store(struct device *dev, > @@ -1152,7 +1152,7 @@ static ssize_t addr_ctxtype_show(struct device *dev, > idx = config->addr_idx; > /* CONTEXTTYPE, bits[3:2] */ > val = FIELD_GET(TRCACATRn_CONTEXTTYPE_MASK, config->addr_acc[idx]); > - len = scnprintf(buf, PAGE_SIZE, "%s\n", val == ETM_CTX_NONE ? "none" : > + len = sysfs_emit(buf, "%s\n", val == ETM_CTX_NONE ? "none" : > (val == ETM_CTX_CTXID ? "ctxid" : > (val == ETM_CTX_VMID ? "vmid" : "all"))); > raw_spin_unlock(&drvdata->spinlock); > @@ -1219,7 +1219,7 @@ static ssize_t addr_context_show(struct device *dev, > /* context ID comparator bits[6:4] */ > val = FIELD_GET(TRCACATRn_CONTEXT_MASK, config->addr_acc[idx]); > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t addr_context_store(struct device *dev, > @@ -1262,7 +1262,7 @@ static ssize_t addr_exlevel_s_ns_show(struct device *dev, > idx = config->addr_idx; > val = FIELD_GET(TRCACATRn_EXLEVEL_MASK, config->addr_acc[idx]); > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t addr_exlevel_s_ns_store(struct device *dev, > @@ -1325,8 +1325,8 @@ static ssize_t addr_cmp_view_show(struct device *dev, > } > raw_spin_unlock(&drvdata->spinlock); > if (addr_type) { > - size = scnprintf(buf, PAGE_SIZE, "addr_cmp[%i] %s %#lx", idx, > - addr_type_names[addr_type], addr_v); > + size = sysfs_emit(buf, "addr_cmp[%i] %s %#lx", idx, > + addr_type_names[addr_type], addr_v); > if (addr_type == ETM_ADDR_TYPE_RANGE) { > size += scnprintf(buf + size, PAGE_SIZE - size, > " %#lx %s", addr_v2, > @@ -1335,7 +1335,7 @@ static ssize_t addr_cmp_view_show(struct device *dev, > size += scnprintf(buf + size, PAGE_SIZE - size, > " ctrl(%#lx)\n", addr_ctrl); > } else { > - size = scnprintf(buf, PAGE_SIZE, "addr_cmp[%i] unused\n", idx); > + size = sysfs_emit(buf, "addr_cmp[%i] unused\n", idx); > } > return size; > } > @@ -1352,7 +1352,7 @@ static ssize_t vinst_pe_cmp_start_stop_show(struct device *dev, > if (!drvdata->nr_pe_cmp) > return -EINVAL; > val = config->vipcssctlr; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > static ssize_t vinst_pe_cmp_start_stop_store(struct device *dev, > struct device_attribute *attr, > @@ -1383,7 +1383,7 @@ static ssize_t seq_idx_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->seq_idx; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t seq_idx_store(struct device *dev, > @@ -1419,7 +1419,7 @@ static ssize_t seq_state_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->seq_state; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t seq_state_store(struct device *dev, > @@ -1453,7 +1453,7 @@ static ssize_t seq_event_show(struct device *dev, > idx = config->seq_idx; > val = config->seq_ctrl[idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t seq_event_store(struct device *dev, > @@ -1486,7 +1486,7 @@ static ssize_t seq_reset_event_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->seq_rst; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t seq_reset_event_store(struct device *dev, > @@ -1516,7 +1516,7 @@ static ssize_t cntr_idx_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->cntr_idx; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t cntr_idx_store(struct device *dev, > @@ -1556,7 +1556,7 @@ static ssize_t cntrldvr_show(struct device *dev, > idx = config->cntr_idx; > val = config->cntrldvr[idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t cntrldvr_store(struct device *dev, > @@ -1594,7 +1594,7 @@ static ssize_t cntr_val_show(struct device *dev, > idx = config->cntr_idx; > val = config->cntr_val[idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t cntr_val_store(struct device *dev, > @@ -1632,7 +1632,7 @@ static ssize_t cntr_ctrl_show(struct device *dev, > idx = config->cntr_idx; > val = config->cntr_ctrl[idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t cntr_ctrl_store(struct device *dev, > @@ -1664,7 +1664,7 @@ static ssize_t res_idx_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->res_idx; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t res_idx_store(struct device *dev, > @@ -1708,7 +1708,7 @@ static ssize_t res_ctrl_show(struct device *dev, > idx = config->res_idx; > val = config->res_ctrl[idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t res_ctrl_store(struct device *dev, > @@ -1746,7 +1746,7 @@ static ssize_t sshot_idx_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->ss_idx; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t sshot_idx_store(struct device *dev, > @@ -1780,7 +1780,7 @@ static ssize_t sshot_ctrl_show(struct device *dev, > raw_spin_lock(&drvdata->spinlock); > val = config->ss_ctrl[config->ss_idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t sshot_ctrl_store(struct device *dev, > @@ -1815,7 +1815,7 @@ static ssize_t sshot_status_show(struct device *dev, > raw_spin_lock(&drvdata->spinlock); > val = config->ss_status[config->ss_idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > static DEVICE_ATTR_RO(sshot_status); > > @@ -1830,7 +1830,7 @@ static ssize_t sshot_pe_ctrl_show(struct device *dev, > raw_spin_lock(&drvdata->spinlock); > val = config->ss_pe_cmp[config->ss_idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t sshot_pe_ctrl_store(struct device *dev, > @@ -1864,7 +1864,7 @@ static ssize_t ctxid_idx_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->ctxid_idx; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t ctxid_idx_store(struct device *dev, > @@ -1911,7 +1911,7 @@ static ssize_t ctxid_pid_show(struct device *dev, > idx = config->ctxid_idx; > val = (unsigned long)config->ctxid_pid[idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t ctxid_pid_store(struct device *dev, > @@ -1972,7 +1972,7 @@ static ssize_t ctxid_masks_show(struct device *dev, > val1 = config->ctxid_mask0; > val2 = config->ctxid_mask1; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx %#lx\n", val1, val2); > + return sysfs_emit(buf, "%#lx %#lx\n", val1, val2); > } > > static ssize_t ctxid_masks_store(struct device *dev, > @@ -2090,7 +2090,7 @@ static ssize_t vmid_idx_show(struct device *dev, > struct etmv4_config *config = &drvdata->config; > > val = config->vmid_idx; > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t vmid_idx_store(struct device *dev, > @@ -2135,7 +2135,7 @@ static ssize_t vmid_val_show(struct device *dev, > raw_spin_lock(&drvdata->spinlock); > val = (unsigned long)config->vmid_val[config->vmid_idx]; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t vmid_val_store(struct device *dev, > @@ -2187,7 +2187,7 @@ static ssize_t vmid_masks_show(struct device *dev, > val1 = config->vmid_mask0; > val2 = config->vmid_mask1; > raw_spin_unlock(&drvdata->spinlock); > - return scnprintf(buf, PAGE_SIZE, "%#lx %#lx\n", val1, val2); > + return sysfs_emit(buf, "%#lx %#lx\n", val1, val2); > } > > static ssize_t vmid_masks_store(struct device *dev, > @@ -2303,7 +2303,7 @@ static ssize_t cpu_show(struct device *dev, > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > > val = drvdata->cpu; > - return scnprintf(buf, PAGE_SIZE, "%d\n", val); > + return sysfs_emit(buf, "%d\n", val); > > } > static DEVICE_ATTR_RO(cpu); > @@ -2461,7 +2461,7 @@ static ssize_t coresight_etm4x_reg_show(struct device *dev, > val = etmv4_cross_read(drvdata, offset); > pm_runtime_put_sync(dev->parent); > > - return scnprintf(buf, PAGE_SIZE, "0x%x\n", val); > + return sysfs_emit(buf, "0x%x\n", val); > } > > static bool > diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c > index e45c6c7204b4..fa09a43889d7 100644 > --- a/drivers/hwtracing/coresight/coresight-stm.c > +++ b/drivers/hwtracing/coresight/coresight-stm.c > @@ -470,7 +470,7 @@ static ssize_t hwevent_enable_show(struct device *dev, > struct stm_drvdata *drvdata = dev_get_drvdata(dev->parent); > unsigned long val = drvdata->stmheer; > > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t hwevent_enable_store(struct device *dev, > @@ -499,7 +499,7 @@ static ssize_t hwevent_select_show(struct device *dev, > struct stm_drvdata *drvdata = dev_get_drvdata(dev->parent); > unsigned long val = drvdata->stmhebsr; > > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t hwevent_select_store(struct device *dev, > @@ -534,7 +534,7 @@ static ssize_t port_select_show(struct device *dev, > spin_unlock(&drvdata->spinlock); > } > > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t port_select_store(struct device *dev, > @@ -581,7 +581,7 @@ static ssize_t port_enable_show(struct device *dev, > spin_unlock(&drvdata->spinlock); > } > > - return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); > + return sysfs_emit(buf, "%#lx\n", val); > } > > static ssize_t port_enable_store(struct device *dev, > diff --git a/drivers/hwtracing/coresight/coresight-sysfs.c b/drivers/hwtracing/coresight/coresight-sysfs.c > index feadaf065b53..547f4970e1e5 100644 > --- a/drivers/hwtracing/coresight/coresight-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-sysfs.c > @@ -315,7 +315,7 @@ static ssize_t enable_sink_show(struct device *dev, > { > struct coresight_device *csdev = to_coresight_device(dev); > > - return scnprintf(buf, PAGE_SIZE, "%u\n", csdev->sysfs_sink_activated); > + return sysfs_emit(buf, "%u\n", csdev->sysfs_sink_activated); > } > > static ssize_t enable_sink_store(struct device *dev, > @@ -343,7 +343,7 @@ static ssize_t enable_source_show(struct device *dev, > struct coresight_device *csdev = to_coresight_device(dev); > > guard(mutex)(&coresight_mutex); > - return scnprintf(buf, PAGE_SIZE, "%u\n", > + return sysfs_emit(buf, "%u\n", > coresight_get_mode(csdev) == CS_MODE_SYSFS); > } > > -- > 2.47.1 > Regards Mike -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK

6 days, 19 hours

[PATCH v2 00/28] CoreSight: Address CPU Power Management Issues

by Leo Yan

This series addresses CPU power management issues in the CoreSight drivers. For easier review, the patches are organized into two categories: o Patches 01 ~ 10 focus on CPU power management within the ETM drivers. These patches fix SMP-safe access to the mode, correct context synchronization, and refactor the CPU suspend/resume flows. o Patches 11 ~ 28 extend CPU power management to cover activated paths, including helpers, links, and sinks. These changes move CPU PM and hotplug notifiers from the ETMv4 driver into the CoreSight core layer. Summary of Changes: - Patches 01 ~ 03: Fix device mode access in the SMP mode. - Patch 04 : A minor fix for polling bit. - Patches 05 ~ 07: Improve the context synchronization based on the ETM specification (IHI0064H.b) and Arm ARM (ARM DDI 0487 L.a). - Patches 08 ~ 10: Refactor the context save/restore flow in the ETMv4 driver, in the end, the CPU PM callbacks reuse the normal enabling and disabling flows. - Patches 11 ~ 17: Move CPU PM code from ETMv4 driver to the core layer. - Patches 18 ~ 25: Enhance device mode handling in the CTI driver, distinguishes debug mode from trace modes (Perf or SysFS mode). Extend support activated paths during CPU idle. Support save and restore context for per-CPU sink (TRBE). - Patches 26 ~ 28: Move CPU hotplug notifier from the ETMv4 driver to the core layer. The full path is now managed in CPU hotplug. Verification: This series has been verified on the following platforms: - Hikey960, Juno-r0 and Juno-r2: Note that the firmware on Hikey960 and Juno-r0 is unstable. While no CoreSight failures were observed, but the CPU hotplug or CPU idle itself may fail intermittently. Juno-r2 is much stable and can pass 24+ hours stress test. - FVP RevC: Verified TRBE changes. Stress test script: #!/usr/bin/bash echo 1 > /sys/bus/coresight/devices/tmc_etr0/enable_sink while true; do echo 0 > /sys/devices/system/cpu/cpu2/online; echo 1 > /sys/devices/system/cpu/cpu2/online; done & while true; do echo 1 > /sys/bus/coresight/devices/etm2/enable_source; echo 0 > /sys/bus/coresight/devices/etm2/enable_source; done & --- Changes in v2: - Refactored ETMv4 suspend and resume for reusing the normal enabling and disabling flows (James). - Used a per-CPU structure to maintain path pointers (James). - Supported helpers in CPU PM flows (James). - Fixed the SMP-safe access to device mode. - Fixed the context synchronization in ETMv4x driver. - Link to v1: https://lore.kernel.org/linux-arm-kernel/20250516160742.1200904-1-leo.yan@a… Signed-off-by: Leo Yan <leo.yan(a)arm.com> --- Leo Yan (27): coresight: Change device mode to atomic type coresight: etm4x: Always set tracer's device mode on target CPU coresight: etm3x: Always set tracer's device mode on target CPU coresight: etm4x: Correct polling IDLE bit coresight: etm4x: Ensure context synchronization is not ignored coresight: etm4x: Add context synchronization before enabling trace coresight: etm4x: Properly control filter in CPU idle with FEAT_TRF coresight: etm4x: Remove the state_needs_restore flag coresight: etm4x: Add flag to control single-shot restart coresight: etm4x: Reuse normal enable and disable logic in CPU idle coresight: Populate CPU ID into the coresight_device structure coresight: sysfs: Validate CPU online status for per-CPU sources coresight: Set per CPU source pointer coresight: Register CPU PM notifier in core layer coresight: etm4x: Hook CPU PM callbacks coresight: Add callback to determine if context save/restore is needed coresight: etm4x: Remove redundant condition checks in save and restore coresight: cti: Fix race condition by using device mode coresight: cti: Introduce CS_MODE_DEBUG mode coresight: cti: Properly handle modes in CPU PM notifiers coresight: Add per-CPU path pointer coresight: Add 'in_idle' argument to path enable/disable functions coresight: Control path during CPU idle coresight: Add PM callbacks for percpu sink coresight: Take hotplug lock in enable_source_store() for Sysfs mode coresight: Move CPU hotplug callbacks to core layer coresight: Manage activated path during CPU hotplug Yabin Cui (1): coresight: trbe: Save and restore state across CPU low power state drivers/hwtracing/coresight/coresight-catu.c | 1 + drivers/hwtracing/coresight/coresight-core.c | 337 ++++++++++++-- drivers/hwtracing/coresight/coresight-ctcu-core.c | 1 + drivers/hwtracing/coresight/coresight-cti-core.c | 40 +- drivers/hwtracing/coresight/coresight-cti-sysfs.c | 2 +- drivers/hwtracing/coresight/coresight-dummy.c | 1 + drivers/hwtracing/coresight/coresight-etb10.c | 1 + drivers/hwtracing/coresight/coresight-etm3x-core.c | 61 ++- drivers/hwtracing/coresight/coresight-etm4x-core.c | 488 ++++++--------------- drivers/hwtracing/coresight/coresight-etm4x.h | 62 --- drivers/hwtracing/coresight/coresight-funnel.c | 1 + drivers/hwtracing/coresight/coresight-replicator.c | 1 + drivers/hwtracing/coresight/coresight-stm.c | 1 + drivers/hwtracing/coresight/coresight-sysfs.c | 10 + drivers/hwtracing/coresight/coresight-tmc-core.c | 1 + drivers/hwtracing/coresight/coresight-tpda.c | 1 + drivers/hwtracing/coresight/coresight-tpdm.c | 1 + drivers/hwtracing/coresight/coresight-tpiu.c | 1 + drivers/hwtracing/coresight/coresight-trbe.c | 85 ++++ drivers/hwtracing/coresight/ultrasoc-smb.c | 1 + include/linux/coresight.h | 55 ++- 21 files changed, 665 insertions(+), 487 deletions(-) --- base-commit: 66701750d5565c574af42bef0b789ce0203e3071 change-id: 20250611-arm_cs_pm_fix_v3-f4ae29bb7d81 Best regards, -- Leo Yan <leo.yan(a)arm.com>

1 week

[PATCH v11 0/2] coresight: Add Coresight Trace Network On Chip driver

by Yuanfang Zhang

The Trace Network On Chip (TNOC) is an integration hierarchy which is a hardware component that integrates the functionalities of TPDA and funnels. It collects trace from subsystems and transfers it to coresight sink. In addition to the generic TNOC mentioned above, there is also a special type of TNOC called Interconnect TNOC. Unlike the generic TNOC, the Interconnect TNOC doesn't need ATID. Its primary function is to connect the source of subsystems to the Aggregator TNOC. Its driver is different from this patch and will describe it and upstream its driver separately. Signed-off-by: Yuanfang Zhang <quic_yuanfang(a)quicinc.com> --- Changes in v11: - reorder of trace ID release and device unregister. - Link to v10: https://lore.kernel.org/r/20250611-trace-noc-v10-0-a83b5c63da34@quicinc.com Changes in v10: - Rebase to coresight/next branch. - Link to v9: https://lore.kernel.org/r/20250611-trace-noc-v9-0-4322d4cf8f4b@quicinc.com Changes in v9: - Mention the binding is only for Aggregator TNOC. - Link to v8: https://lore.kernel.org/r/20250606-trace-noc-v8-0-833f94712c57@quicinc.com Changes in v8: - Add sysfs node to expose atid. - Link to v7: https://lore.kernel.org/r/20250523-trace-noc-v7-0-d65edbab2997@quicinc.com Changes in v7: - Move the content in header file into coresight-tnoc.c. - Use scoped_guard() to replace spin_lock(). - Invoke coresight_trace_id_put_system_id() for registration failure. - Link to v6: https://lore.kernel.org/r/20250522-trace-noc-v6-0-f5a9bcae90ee@quicinc.com Changes in v6: - Add a newline after return statements. - Use 'x &= foo' to replace 'x = x & foo'. - Use 'x |= foo' to replace 'x = x | foo'. - Link to v5: https://lore.kernel.org/r/20250512-trace-noc-v5-0-f2ef070baee5@quicinc.com Changes in v5: - update cover-letter to describe the Interconnect TNOC. - Link to v4: https://lore.kernel.org/r/20250415-trace-noc-v4-0-979938fedfd8@quicinc.com Changes in v4: - Fix dt_binding warning. - update mask of trace_noc amba_id. - Modify driver comments. - rename TRACE_NOC_SYN_VAL to TRACE_NOC_SYNC_INTERVAL. - Link to v3: https://lore.kernel.org/r/20250411-trace-noc-v3-0-1f19ddf7699b@quicinc.com Changes in v3: - Remove unnecessary sysfs nodes. - update commit messages. - Use 'writel' instead of 'write_relaxed' when writing to the register for the last time. - Add trace_id ops. - Link to v2: https://lore.kernel.org/r/20250226-trace-noc-driver-v2-0-8afc6584afc5@quici… Changes in v2: - Modified the format of DT binging file. - Fix compile warnings. - Link to v1: https://lore.kernel.org/r/46643089-b88d-49dc-be05-7bf0bb21f847@quicinc.com --- Yuanfang Zhang (2): dt-bindings: arm: Add device Trace Network On Chip definition coresight: add coresight Trace Network On Chip driver .../bindings/arm/qcom,coresight-tnoc.yaml | 113 ++++++++++ drivers/hwtracing/coresight/Kconfig | 12 + drivers/hwtracing/coresight/Makefile | 1 + drivers/hwtracing/coresight/coresight-tnoc.c | 242 +++++++++++++++++++++ 4 files changed, 368 insertions(+) --- base-commit: 408c97c4a5e0b634dcd15bf8b8808b382e888164 change-id: 20250403-trace-noc-f8286b30408e Best regards, -- Yuanfang Zhang <quic_yuanfang(a)quicinc.com>

1 week

[PATCH v2 0/5] Refactoring finding CPU phandles in DT

by Alireza Sanaee

This series refactors the way CPU IDs are retrieved from the device tree. Usually, there is a for loop that goes over every single CPU that can be avoided. This also reduces the amount of NULL pointer checks in drivers. I have abstracted away that loop and introduced a new function (of_cpu_node_to_id) for this. This patchset is a subset of [1], where I removed content and patches relevant to hyper-threaded cores for DT. Based on the discussion, the code refactor is still useful, hence this patchset. Changes since v1 [2]: - Rebased on top of the latest mainline. - Addressed Krzysztof Kozlowski's comments -- Hopefully :-) - Addressed Jonathan Cameron's comments. [1] https://lore.kernel.org/all/20250512080715.82-1-alireza.sanaee@huawei.com/ [2] https://lore.kernel.org/all/20250707150414.620-1-alireza.sanaee@huawei.com/ Alireza Sanaee (5): of: add infra for finding CPU id from phandle arch_topology: update CPU map to use the new API coresight: cti: Use of_cpu_phandle_to_id for grabbing CPU id coresight: Use of_cpu_phandle_to_id for grabbing CPU id perf/arm-dsu: refactor cpu id retrieval via new API of_cpu_phandle_to_id drivers/base/arch_topology.c | 16 ++++---- .../coresight/coresight-cti-platform.c | 14 +------ .../hwtracing/coresight/coresight-platform.c | 15 +------ drivers/of/cpu.c | 40 +++++++++++++++++++ drivers/perf/arm_dsu_pmu.c | 8 +--- include/linux/of.h | 9 +++++ 6 files changed, 61 insertions(+), 41 deletions(-) -- 2.43.0

1 week, 3 days

[PATCH v10 0/2] coresight: Add Coresight Trace Network On Chip driver

by Yuanfang Zhang

The Trace Network On Chip (TNOC) is an integration hierarchy which is a hardware component that integrates the functionalities of TPDA and funnels. It collects trace from subsystems and transfers it to coresight sink. In addition to the generic TNOC mentioned above, there is also a special type of TNOC called Interconnect TNOC. Unlike the generic TNOC, the Interconnect TNOC doesn't need ATID. Its primary function is to connect the source of subsystems to the Aggregator TNOC. Its driver is different from this patch and will describe it and upstream its driver separately. Signed-off-by: Yuanfang Zhang <quic_yuanfang(a)quicinc.com> --- Changes in v10: - Rebase to coresight/next branch. - Link to v9: https://lore.kernel.org/r/20250611-trace-noc-v9-0-4322d4cf8f4b@quicinc.com Changes in v9: - Mention the binding is only for Aggregator TNOC. - Link to v8: https://lore.kernel.org/r/20250606-trace-noc-v8-0-833f94712c57@quicinc.com Changes in v8: - Add sysfs node to expose atid. - Link to v7: https://lore.kernel.org/r/20250523-trace-noc-v7-0-d65edbab2997@quicinc.com Changes in v7: - Move the content in header file into coresight-tnoc.c. - Use scoped_guard() to replace spin_lock(). - Invoke coresight_trace_id_put_system_id() for registration failure. - Link to v6: https://lore.kernel.org/r/20250522-trace-noc-v6-0-f5a9bcae90ee@quicinc.com Changes in v6: - Add a newline after return statements. - Use 'x &= foo' to replace 'x = x & foo'. - Use 'x |= foo' to replace 'x = x | foo'. - Link to v5: https://lore.kernel.org/r/20250512-trace-noc-v5-0-f2ef070baee5@quicinc.com Changes in v5: - update cover-letter to describe the Interconnect TNOC. - Link to v4: https://lore.kernel.org/r/20250415-trace-noc-v4-0-979938fedfd8@quicinc.com Changes in v4: - Fix dt_binding warning. - update mask of trace_noc amba_id. - Modify driver comments. - rename TRACE_NOC_SYN_VAL to TRACE_NOC_SYNC_INTERVAL. - Link to v3: https://lore.kernel.org/r/20250411-trace-noc-v3-0-1f19ddf7699b@quicinc.com Changes in v3: - Remove unnecessary sysfs nodes. - update commit messages. - Use 'writel' instead of 'write_relaxed' when writing to the register for the last time. - Add trace_id ops. - Link to v2: https://lore.kernel.org/r/20250226-trace-noc-driver-v2-0-8afc6584afc5@quici… Changes in v2: - Modified the format of DT binging file. - Fix compile warnings. - Link to v1: https://lore.kernel.org/r/46643089-b88d-49dc-be05-7bf0bb21f847@quicinc.com --- Yuanfang Zhang (2): dt-bindings: arm: Add device Trace Network On Chip definition coresight: add coresight Trace Network On Chip driver .../bindings/arm/qcom,coresight-tnoc.yaml | 113 ++++++++++ drivers/hwtracing/coresight/Kconfig | 12 + drivers/hwtracing/coresight/Makefile | 1 + drivers/hwtracing/coresight/coresight-tnoc.c | 242 +++++++++++++++++++++ 4 files changed, 368 insertions(+) --- base-commit: 408c97c4a5e0b634dcd15bf8b8808b382e888164 change-id: 20250403-trace-noc-f8286b30408e Best regards, -- Yuanfang Zhang <quic_yuanfang(a)quicinc.com>

1 week, 3 days

[PATCH v6 0/5] coresight: Add remote etm support

by Mao Jinlong

The system on chip (SoC) consists of main APSS(Applications processor subsytem) and additional processors like modem, lpass. There is coresight-etm driver for etm trace of APSS. Coresight remote etm driver is for enabling and disabling the etm trace of remote processors. It uses QMI interface to communicate with remote processors' software and uses coresight framework to configure the connection from remote etm source to TMC sinks. Example to capture the remote etm trace: Enable source: echo 1 > /sys/bus/coresight/devices/tmc_etf0/enable_sink echo 1 > /sys/bus/coresight/devices/remote_etm0/enable_source Capture the trace: cat /dev/tmc_etf0 > /data/remote_etm.bin Disable source: echo 0 > /sys/bus/coresight/devices/remote_etm0/enable_source Changes since V5: 1. Fix the warning and error when compile. 2. Add traceid for remote etm. 3. Change qcom,qmi-id tp qcom,qmi-instance-id. Changes since V4: 1. Add coresight QMI driver 2. Add coresight qmi node and qcom,qmi-id of modem-etm in msm8996 dtsi V5: https://lwn.net/ml/all/20250424115854.2328190-1-quic_jinlmao@quicinc.com/ Changes since V3: 1. Use different compatible for different remote etms in dt. 2. Get qmi instance id from the match table data in driver. Change since V2: 1. Change qcom,inst-id to qcom,qmi-id 2. Fix the error in code for type of remote_etm_remove 3. Depend on QMI helper in Kconfig Changes since V1: 1. Remove unused content 2. Use CORESIGHT_DEV_SUBTYPE_SOURCE_OTHERS as remote etm source type. 3. Use enabled instead of enable in driver data. 4. Validate instance id value where it's read from the DT. Mao Jinlong (5): dt-bindings: arm: Add CoreSight QMI component description coresight: Add coresight QMI driver dt-bindings: arm: Add qcom,qmi-id for remote etm coresight: Add remote etm support arm64: dts: qcom: msm8996: Add coresight qmi node .../bindings/arm/qcom,coresight-qmi.yaml | 65 +++++ .../arm/qcom,coresight-remote-etm.yaml | 9 + arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 + drivers/hwtracing/coresight/Kconfig | 23 ++ drivers/hwtracing/coresight/Makefile | 2 + drivers/hwtracing/coresight/coresight-qmi.c | 198 +++++++++++++ drivers/hwtracing/coresight/coresight-qmi.h | 101 +++++++ .../coresight/coresight-remote-etm.c | 262 ++++++++++++++++++ 8 files changed, 671 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/qcom,coresight-qmi.yaml create mode 100644 drivers/hwtracing/coresight/coresight-qmi.c create mode 100644 drivers/hwtracing/coresight/coresight-qmi.h create mode 100644 drivers/hwtracing/coresight/coresight-remote-etm.c -- 2.25.1

1 week, 3 days

[PATCH v5 0/5] coresight: Add remote etm support

by Mao Jinlong

The system on chip (SoC) consists of main APSS(Applications processor subsytem) and additional processors like modem, lpass. There is coresight-etm driver for etm trace of APSS. Coresight remote etm driver is for enabling and disabling the etm trace of remote processors. It uses QMI interface to communicate with remote processors' software and uses coresight framework to configure the connection from remote etm source to TMC sinks. Example to capture the remote etm trace: Enable source: echo 1 > /sys/bus/coresight/devices/tmc_etf0/enable_sink echo 1 > /sys/bus/coresight/devices/remote_etm0/enable_source Capture the trace: cat /dev/tmc_etf0 > /data/remote_etm.bin Disable source: echo 0 > /sys/bus/coresight/devices/remote_etm0/enable_source Changes since V4: 1. Add coresight QMI driver 2. Add coresight qmi node and qcom,qmi-id of modem-etm in msm8996 dtsi Changes since V3: 1. Use different compatible for different remote etms in dt. 2. Get qmi instance id from the match table data in driver. Change since V2: 1. Change qcom,inst-id to qcom,qmi-id 2. Fix the error in code for type of remote_etm_remove 3. Depend on QMI helper in Kconfig Changes since V1: 1. Remove unused content 2. Use CORESIGHT_DEV_SUBTYPE_SOURCE_OTHERS as remote etm source type. 3. Use enabled instead of enable in driver data. 4. Validate instance id value where it's read from the DT. Mao Jinlong (5): dt-bindings: arm: Add CoreSight QMI component description coresight: Add coresight QMI driver dt-bindings: arm: Add qcom,qmi-id for remote etm coresight: Add remote etm support arm64: dts: qcom: msm8996: Add coresight qmi node .../bindings/arm/qcom,coresight-qmi.yaml | 65 +++++ .../arm/qcom,coresight-remote-etm.yaml | 10 + arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 + drivers/hwtracing/coresight/Kconfig | 24 ++ drivers/hwtracing/coresight/Makefile | 2 + drivers/hwtracing/coresight/coresight-qmi.c | 209 +++++++++++++++ drivers/hwtracing/coresight/coresight-qmi.h | 107 ++++++++ .../coresight/coresight-remote-etm.c | 252 ++++++++++++++++++ 8 files changed, 680 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/qcom,coresight-qmi.yaml create mode 100644 drivers/hwtracing/coresight/coresight-qmi.c create mode 100644 drivers/hwtracing/coresight/coresight-qmi.h create mode 100644 drivers/hwtracing/coresight/coresight-remote-etm.c -- 2.25.1

1 week, 3 days

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

CoreSight July 2025