On Sun, 17 Mar 2019 at 21:06, Leo Yan leo.yan@linaro.org wrote:
On Wed, Mar 06, 2019 at 03:57:38PM -0700, Mathieu Poirier wrote:
When disabling a sink the reference counter ensures the operation goes through if nobody else is using it. As such if drvdata::mode is already set do CS_MODE_DISABLED, it is an error and should be reported as such.
I found the patch 0006 and 0007 for changing sink::disable() and for sink::update(), both of them don't touch tpiu driver. After look into the tpiu code, tpiu driver doesn't maintain the mode and without field 'drvdata->mode' in driver data structure.
Should we do the same thing (maintain the driver mode) for tpiu driver? I just bring up in case you miss it; if you think this question is not irrelative with cpu wide trace support, please ignore it.
The TPIU driver does not support the perf API. Since CPU-wide scenarios are only valid within the context of perf sessions, there is no point implementing anything.
Thanks for your comments, Mathieu
[...]
Thanks, Leo Yan