Re: [PATCH v10 02/10] Coresight: Add coresight TPDM source driver

On 11/06/2022 01:43, Mao Jinlong wrote:

Add driver to support Coresight device TPDM (Trace, Profiling and Diagnostics Monitor). TPDM is a monitor to collect data from different datasets. This change is to add probe/enable/disable functions for tpdm source.

Signed-off-by: Tao Zhang quic_taozha@quicinc.com Signed-off-by: Mao Jinlong quic_jinlmao@quicinc.com

---

drivers/hwtracing/coresight/Kconfig | 12 ++ drivers/hwtracing/coresight/Makefile | 1 + drivers/hwtracing/coresight/coresight-core.c | 5 +- drivers/hwtracing/coresight/coresight-tpdm.c | 149 +++++++++++++++++++ drivers/hwtracing/coresight/coresight-tpdm.h | 26 ++++ include/linux/coresight.h | 1 + 6 files changed, 193 insertions(+), 1 deletion(-) create mode 100644 drivers/hwtracing/coresight/coresight-tpdm.c create mode 100644 drivers/hwtracing/coresight/coresight-tpdm.h

diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig index 514a9b8086e3..b2b72a35e416 100644 --- a/drivers/hwtracing/coresight/Kconfig +++ b/drivers/hwtracing/coresight/Kconfig @@ -201,4 +201,16 @@ config CORESIGHT_TRBE To compile this driver as a module, choose M here: the module will be called coresight-trbe.

+config CORESIGHT_TPDM

• tristate "CoreSight Trace, Profiling & Diagnostics Monitor driver"
• select CORESIGHT_LINKS_AND_SINKS
• help

•  This driver provides support for configuring monitor. Monitors are
  

•  primarily responsible for data set collection and support the
  

•  ability to collect any permutation of data set types.
  

•  To compile this driver as a module, choose M here: the module will be
  

•  called coresight-tpdm.
  

• endif

diff --git a/drivers/hwtracing/coresight/Makefile b/drivers/hwtracing/coresight/Makefile index 329a0c704b87..6bb9b1746bc7 100644 --- a/drivers/hwtracing/coresight/Makefile +++ b/drivers/hwtracing/coresight/Makefile @@ -25,5 +25,6 @@ obj-$(CONFIG_CORESIGHT_CPU_DEBUG) += coresight-cpu-debug.o obj-$(CONFIG_CORESIGHT_CATU) += coresight-catu.o obj-$(CONFIG_CORESIGHT_CTI) += coresight-cti.o obj-$(CONFIG_CORESIGHT_TRBE) += coresight-trbe.o +obj-$(CONFIG_CORESIGHT_TPDM) += coresight-tpdm.o coresight-cti-y := coresight-cti-core.o coresight-cti-platform.o \ coresight-cti-sysfs.o diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c index 23ab16dd9b5d..1d2b5b84bb5d 100644 --- a/drivers/hwtracing/coresight/coresight-core.c +++ b/drivers/hwtracing/coresight/coresight-core.c @@ -1047,7 +1047,8 @@ static int coresight_validate_source(struct coresight_device *csdev, } if (subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_PROC &&

•    subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE) {
  

•    subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE &&
  

•    subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_OTHERS) {
  

  dev_err(&csdev->dev, "wrong device subtype in %s\n", function); return -EINVAL; }

@@ -1116,6 +1117,7 @@ int coresight_enable(struct coresight_device *csdev) per_cpu(tracer_path, cpu) = path; break; case CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE:

• case CORESIGHT_DEV_SUBTYPE_SOURCE_OTHERS: /*
  • Use the hash of source's device name as ID
  • and map the ID to the pointer of the path.

@@ -1165,6 +1167,7 @@ void coresight_disable(struct coresight_device *csdev) per_cpu(tracer_path, cpu) = NULL; break; case CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE:

• case CORESIGHT_DEV_SUBTYPE_SOURCE_OTHERS: hash = hashlen_hash(hashlen_string(NULL, dev_name(&csdev->dev))); /* Find the path by the hash. */ path = idr_find(&path_idr, hash);

diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c new file mode 100644 index 000000000000..eb8998affa90 --- /dev/null +++ b/drivers/hwtracing/coresight/coresight-tpdm.c @@ -0,0 +1,149 @@ +// SPDX-License-Identifier: GPL-2.0 +/*

• • Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
• */

+#include <linux/amba/bus.h> +#include <linux/bitmap.h> +#include <linux/coresight.h> +#include <linux/coresight-pmu.h> +#include <linux/device.h> +#include <linux/err.h> +#include <linux/fs.h> +#include <linux/io.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h>

+#include "coresight-priv.h" +#include "coresight-tpdm.h"

+DEFINE_CORESIGHT_DEVLIST(tpdm_devs, "tpdm");

+/* TPDM enable operations */ +static int tpdm_enable(struct coresight_device *csdev,

•        struct perf_event *event, u32 mode)
  

+{

• struct tpdm_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent);
• spin_lock(&drvdata->spinlock);
• if (drvdata->enable) {

• spin_unlock(&drvdata->spinlock);
  

• return -EBUSY;
  

• }
• drvdata->enable = true;
• spin_unlock(&drvdata->spinlock);
• dev_info(drvdata->dev, "TPDM tracing enabled\n");

Please make all of these dev_dbg(). We don't want these messages flooding the dmesg for everytime the device is turned on/off.

• return 0;

+}

+/* TPDM disable operations */ +static void tpdm_disable(struct coresight_device *csdev,

• 	 struct perf_event *event)
  

+{

• struct tpdm_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent);
• spin_lock(&drvdata->spinlock);
• if (!drvdata->enable) {

• spin_unlock(&drvdata->spinlock);
  

• return;
  

• }
• drvdata->enable = false;
• spin_unlock(&drvdata->spinlock);
• dev_info(drvdata->dev, "TPDM tracing disabled\n");

Same as above. Otherwise looks good to me.

Suzuki