On Mon, Sep 02, 2019 at 02:22:47PM +0100, Mike Leach wrote:
Hi Leo,
On Mon, 2 Sep 2019 at 08:44, Leo Yan leo.yan@linaro.org wrote:
On Mon, Aug 19, 2019 at 10:13:48PM +0100, Mike Leach wrote:
Adds sysfs access to the coresight management registers.
Signed-off-by: Mike Leach mike.leach@linaro.org
.../hwtracing/coresight/coresight-cti-sysfs.c | 67 ++++++++++++++++++- drivers/hwtracing/coresight/coresight-priv.h | 1 + 2 files changed, 66 insertions(+), 2 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c index a832b8c6b866..20a9b30c9755 100644 --- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c @@ -34,8 +34,7 @@ static ssize_t enable_show(struct device *dev, return size; }
-static ssize_t enable_store(struct device *dev,
struct device_attribute *attr,+static ssize_t enable_store(struct device *dev, struct device_attribute *attr,
Redundant change?
The rest code in this patch looks good to me.
Fixup for function parameter alignment mentioned in v3 comments
Ah, if so it's better to fixup in the first place in patch 01.
Thanks, Leo Yan