On 8/30/2024 12:20 AM, Leo Yan wrote:
On 8/29/24 18:39, Steve Clevenger wrote:>
On 8/29/2024 12:55 AM, Leo Yan wrote:
On 8/29/2024 12:17 AM, Steve Clevenger wrote:
Changes in V5: - In symbol-elf.c, branch to exit_close label if open file. - In trace_event_python.c, correct indentation. set_sym_in_dict call parameter "map_pgoff" renamed as "addr_map_pgoff" to match local naming.
For the series:
Reviewed-by: Leo Yan leo.yan@arm.com
Hi Steve,
Later when you respin a new version patches, it is better to amend the review and ACK tags you have received. (Just remind, b4 is your friend for helping do these things).
Thanks, Leo
Got it. Thanks, Leo. By the way, I noticed when I rebased to perf-tools-next the kernel version was 6.11-rc3. Is there any chance this patch gets into 6.11?
Linus' master branch now is 6.11-rc5, it is not far away from the 6.11.
I think we still have much chance to get it done before it. Added maintainers in case any missing.
Thanks, Leo
Hi Leo,
That's great. Unfortuantely, I need to submit a V6 for patch 4/4, which is the arm-cs-trace-disasm.py script. Kernel instruction trace requires zeroing map_pgoff. perf makes most offset decisions, but this one is in the script. It's a one liner.
I know you're a b4 fan, but I've never used it. If I'm able to make progress with it I'll use it to resubmit. Otherwise more of the same.
Steve
Steve