Hi Namhyung and Jiri,
-----Original Message----- From: Jiri Olsa jolsa@redhat.com Sent: Monday, December 7, 2020 10:29 PM To: Namhyung Kim namhyung@kernel.org Cc: Chanho Park chanho61.park@samsung.com; Will Deacon
Chanho Park parkch98@gmail.com; mathieu.poirier@linaro.org; suzuki.poulose@arm.com; coresight@lists.linaro.org; linux-arm- kernel@lists.infradead.org; linux-kernel linux-kernel@vger.kernel.org; Mike Leach mike.leach@linaro.org; Leo Yan leo.yan@linaro.org; John Garry john.garry@huawei.com; Peter Zijlstra peterz@infradead.org; Ingo Molnar mingo@redhat.com; Arnaldo Carvalho de Melo acme@kernel.org; Mark Rutland mark.rutland@arm.com; Khem Raj raj.khem@gmail.com Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc
On Mon, Dec 07, 2020 at 09:31:06PM +0900, Namhyung Kim wrote:
Hi Chanho,
On Mon, Dec 7, 2020 at 8:58 PM Chanho Park chanho61.park@samsung.com
wrote:
Hi Will,
Looks like other files just include this unconditionally, but have a comment explaining why. See util/branch.h and util/event.h. Maybe we should do the same for util/pmu.h, which is already
included here?
I found below files which perf includes <linux/perf_event.h>. Instead of doing same for all, we'd better put this only for tools/include/uapi/linux/perf_event.h.
It's a copy of the kernel header, I'm not sure we want to add something
there.
right, we want to copy that directly from kernel uapi so let's not do any changes in here
I tried to modify it from include/uapi/linux/perf_event.h but it didn't work. And then, I found perf tool tried to refer the header from tools/include/ directory. I should go include/uapi first and sync the change to tools/ directory. I'll re-spin this patch.
Best Regard, Chanho Park