Hi,
On Tue, 28 Oct 2025 at 09:09, Krzysztof Kozlowski krzk@kernel.org wrote:
On Mon, Oct 27, 2025 at 11:28:03PM -0700, Yuanfang Zhang wrote:
Add the following compatible strings to the bindings:
- arm,coresight-cpu-funnel
- arm,coresight-cpu-replicator
- arm,coresight-cpu-tmc
These are redundant - the actual hardware has not changed - what has is how the device is powered up / down on the system
We see that from the diff. Explain here the hardware instead.
Each requires 'power-domains' when used.
So why is this not used to adjust the power handling in the driver? Or another attribute. Look at the CTI bindings - these can be associated with a CPU or be a system CTI - we look at the cpu attribute to differentiate, not have two separate compatibles.
Regards
Mike
Signed-off-by: Yuanfang Zhang yuanfang.zhang@oss.qualcomm.com
.../bindings/arm/arm,coresight-dynamic-funnel.yaml | 23 +++++++++++++++++----- .../arm/arm,coresight-dynamic-replicator.yaml | 22 +++++++++++++++++---- .../devicetree/bindings/arm/arm,coresight-tmc.yaml | 22 +++++++++++++++++---- 3 files changed, 54 insertions(+), 13 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml index b74db15e5f8af2226b817f6af5f533b1bfc74736..8f32d4e3bbb750f5a6262db0032318875739cf81 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml @@ -28,19 +28,32 @@ select: properties: compatible: contains:
const: arm,coresight-dynamic-funnel
enum:- arm,coresight-dynamic-funnel- arm,coresight-cpu-funnelKeep alphabetical sorting. We asked this multiple times already.
required: - compatible
allOf:
- $ref: /schemas/arm/primecell.yaml#
- if:
properties:compatible:contains:const: arm,coresight-cpu-funnel- then:
required:- power-domainsJust move the allOf to the bottom like in example-schema.
properties: compatible:
- items:
- const: arm,coresight-dynamic-funnel- const: arm,primecellWhy do you remove this?
- oneOf:
- items:- const: arm,coresight-dynamic-funnel- const: arm,primecell- items:- const: arm,coresight-cpu-funnelHm? Why do you need custom select if this is not primecell? And nothing in commit msg explains why this is not primecell anymore.
You have entire commit msg to say something useful, WHY you are doing this, WHY you are doing it DIFFERENTLY. Don't say what you did - that's obvious, we are capable of reading diffs.
Best regards, Krzysztof