On Tue, 21 Apr 2020 at 18:43, Mathieu Poirier mathieu.poirier@linaro.org wrote:
On Thu, Apr 16, 2020 at 04:39:23PM +0100, Mike Leach wrote:
Adjust the handling of the session sink selection to allow no sink to be selected on the command line. This then forwards the sink selection to the CoreSight infrastructure which will attempt to select a sink based on the principal sink labelling.
Signed-off-by: Mike Leach mike.leach@linaro.org
tools/perf/arch/arm/util/cs-etm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c index 941f814820b8..ed9ea2c60f27 100644 --- a/tools/perf/arch/arm/util/cs-etm.c +++ b/tools/perf/arch/arm/util/cs-etm.c @@ -242,10 +242,10 @@ static int cs_etm_set_sink_attr(struct perf_pmu *pmu, }
/*
* No sink was provided on the command line - for _now_ treat* this as an error.
* No sink was provided on the command line - allow the CoreSight* system to look for a default */
return ret;
return 0;I understand this patchset is a proof of concept. When we reach a consensus on how to move forward and you are ready for a respin, please do two sets - one for kernel changes and another one for the perf tools. Normally changes to the kernel need to be merged first.
Regards, Mathieu
Understood. The "real" patchset is going to need doc updates too.
Regards
Mike
}
static int cs_etm_recording_options(struct auxtrace_record *itr,
2.17.1