On Mon, 8 Sept 2025 at 03:02, Jie Gan jie.gan@oss.qualcomm.com wrote:
Create and insert or remove the etr_buf_node to/from the etr_buf_list.
Signed-off-by: Jie Gan jie.gan@oss.qualcomm.com
drivers/hwtracing/coresight/coresight-tmc-etr.c | 94 +++++++++++++++++++++++++ drivers/hwtracing/coresight/coresight-tmc.h | 2 + 2 files changed, 96 insertions(+)
diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c index b07fcdb3fe1a..ed15991b3217 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -1909,6 +1909,100 @@ const struct coresight_ops tmc_etr_cs_ops = { .panic_ops = &tmc_etr_sync_ops, };
+/**
- tmc_clean_etr_buf_list - clean the etr_buf_list.
- @drvdata: driver data of the TMC device.
- Remove the allocated node from the list and free the extra buffer.
- */
+void tmc_clean_etr_buf_list(struct tmc_drvdata *drvdata) +{
struct etr_buf_node *nd, *next;list_for_each_entry_safe(nd, next, &drvdata->etr_buf_list, node) {if (nd->sysfs_buf == drvdata->sysfs_buf) {if (coresight_get_mode(drvdata->csdev) == CS_MODE_DISABLED) {drvdata->sysfs_buf = NULL;tmc_free_etr_buf(nd->sysfs_buf);nd->sysfs_buf = NULL;}list_del(&nd->node);kfree(nd);} else {/* Free allocated buffers which are not utilized by ETR */list_del(&nd->node);tmc_free_etr_buf(nd->sysfs_buf);nd->sysfs_buf = NULL;kfree(nd);}}+} +EXPORT_SYMBOL_GPL(tmc_clean_etr_buf_list);
+/**
- tmc_create_etr_buf_list - create a list to manage the etr_buf_node.
- @drvdata: driver data of the TMC device.
- @num_nodes: number of nodes want to create with the list.
- Return 0 upon success and return the error number if fail.
- */
+int tmc_create_etr_buf_list(struct tmc_drvdata *drvdata, int num_nodes) +{
struct etr_buf_node *new_node;struct etr_buf *sysfs_buf;int i = 0, ret = 0;/* We dont need a list if there is only one node */if (num_nodes < 2)return -EINVAL;/* We expect that sysfs_buf in drvdata has already been allocated. */if (drvdata->sysfs_buf) {/* Directly insert the allocated sysfs_buf into the list first */new_node = kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL);if (IS_ERR(new_node))return PTR_ERR(new_node);new_node->sysfs_buf = drvdata->sysfs_buf;new_node->is_free = false;list_add(&new_node->node, &drvdata->etr_buf_list);i++;}while (i < num_nodes) {new_node = kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL);if (IS_ERR(new_node)) {ret = PTR_ERR(new_node);break;}sysfs_buf = tmc_alloc_etr_buf(drvdata, drvdata->size, 0, cpu_to_node(0), NULL);if (IS_ERR(sysfs_buf)) {kfree(new_node);ret = PTR_ERR(new_node);break;}/* We dont have a available sysfs_buf in drvdata, setup one */if (!drvdata->sysfs_buf) {drvdata->sysfs_buf = sysfs_buf;new_node->is_free = false;} elsenew_node->is_free = true;new_node->sysfs_buf = sysfs_buf;list_add(&new_node->node, &drvdata->etr_buf_list);i++;}/* Clean the list if there is an error */if (ret)tmc_clean_etr_buf_list(drvdata);return ret;+} +EXPORT_SYMBOL_GPL(tmc_create_etr_buf_list);
int tmc_read_prepare_etr(struct tmc_drvdata *drvdata) { int ret = 0; diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h index 292e25d82b62..ca0cba860d5f 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -459,5 +459,7 @@ void tmc_etr_remove_catu_ops(void); struct etr_buf *tmc_etr_get_buffer(struct coresight_device *csdev, enum cs_mode mode, void *data); extern const struct attribute_group coresight_etr_group; +void tmc_clean_etr_buf_list(struct tmc_drvdata *drvdata); +int tmc_create_etr_buf_list(struct tmc_drvdata *drvdata, int num_nodes);
#endif
-- 2.34.1
Reviewed-by: Mike Leach mike.leach@linaro.org