Re: [PATCH] coresight: Replace scnprintf() with sysfs_emit() in sysfs show functions

On 19/06/2025 4:07 pm, Chelsy Ratnawat wrote:

Replace calls to scnprintf() with sysfs_emit() in sysfs show functions. These helpers are preferred in sysfs callbacks because they automatically handle buffer sizing (PAGE_SIZE) and improve safety and readability.

Signed-off-by: Chelsy Ratnawat chelsyratnawat2001@gmail.com

.../hwtracing/coresight/coresight-etm-perf.c | 4 +- .../coresight/coresight-etm3x-sysfs.c | 2 +- .../coresight/coresight-etm4x-sysfs.c | 108 +++++++++--------- drivers/hwtracing/coresight/coresight-stm.c | 8 +-

There's two missing from coresight-sysfs.c. Might as well change those too while were here.

With those changed:

Reviewed-by: James Clark james.clark@linaro.org