Re: [RFT v4 6/8] perf cs-etm: Introduce invalid address macro

On Fri, Jun 01, 2018 at 05:58:38PM +0800, Leo Yan wrote:

This patch introduces invalid address macro and uses it to replace dummy value '0xdeadbeefdeadbeefUL'.

Signed-off-by: Leo Yan leo.yan@linaro.org

tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 8 ++++---- tools/perf/util/cs-etm-decoder/cs-etm-decoder.h | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c index 2125d00..c1715ff 100644 --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c @@ -261,8 +261,8 @@ static void cs_etm_decoder__clear_buffer(struct cs_etm_decoder *decoder) decoder->tail = 0; decoder->packet_count = 0; for (i = 0; i < MAX_BUFFER; i++) {

• decoder->packet_buffer[i].start_addr = 0xdeadbeefdeadbeefUL;
  

• decoder->packet_buffer[i].end_addr = 0xdeadbeefdeadbeefUL;
  

• decoder->packet_buffer[i].start_addr = CS_ETM_INVAL_ADDR;
  

• decoder->packet_buffer[i].end_addr = CS_ETM_INVAL_ADDR;
  

  decoder->packet_buffer[i].last_instr_taken_branch = false; decoder->packet_buffer[i].cpu = INT_MIN; }

@@ -291,8 +291,8 @@ cs_etm_decoder__buffer_packet(struct cs_etm_decoder *decoder, decoder->packet_buffer[et].sample_type = sample_type; decoder->packet_buffer[et].cpu = *((int *)inode->priv);

• decoder->packet_buffer[et].start_addr = 0xdeadbeefdeadbeefUL;
• decoder->packet_buffer[et].end_addr = 0xdeadbeefdeadbeefUL;

• decoder->packet_buffer[et].start_addr = CS_ETM_INVAL_ADDR;
• decoder->packet_buffer[et].end_addr = CS_ETM_INVAL_ADDR;

if (decoder->packet_count == MAX_BUFFER - 1) return OCSD_RESP_WAIT; diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h index cf31a9c..cb57756 100644 --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h @@ -13,6 +13,8 @@ #include <linux/types.h> #include <stdio.h> +#define CS_ETM_INVAL_ADDR 0xdeadbeefdeadbeefUL

I think this patch can also be sent separately, which so far, would give you 4 patches in that "new" set.

struct cs_etm_decoder; struct cs_etm_buffer { -- 2.7.4