On 11/6/20 8:46 PM, Mathieu Poirier wrote:
On Wed, Oct 28, 2020 at 10:09:38PM +0000, Suzuki K Poulose wrote:
In preparation to detect the support for system instruction support, move the detection of the device access to the target CPU.
Signed-off-by: Suzuki K Poulose suzuki.poulose@arm.com
.../coresight/coresight-etm4x-core.c | 45 ++++++++++++++++--- 1 file changed, 40 insertions(+), 5 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c index f038bb10bc78..308674ab746c 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -56,6 +56,11 @@ static u64 etm4_get_access_type(struct etmv4_config *config); static enum cpuhp_state hp_online; +struct etm_init_arg {
- struct etmv4_drvdata *drvdata;
- struct csdev_access *csa;
+};
- u64 etm4x_sysreg_read(struct csdev_access *csa, u32 offset, bool _relaxed,
@@ -669,6 +674,22 @@ static const struct coresight_ops etm4_cs_ops = { .source_ops = &etm4_source_ops, }; +static bool etm_init_iomem_access(struct etmv4_drvdata *drvdata,
struct csdev_access *csa)+{
- *csa = CSDEV_ACCESS_IOMEM(drvdata->base);
- return true;
+}
+static bool etm_init_csdev_access(struct etmv4_drvdata *drvdata,
struct csdev_access *csa)+{
- if (drvdata->base)
return etm_init_iomem_access(drvdata, csa);- return false;
+}
I would also prefix the above two functions with "etm4_" rather than "etm_" to follow what is already done in this file.
sure, will do.
suzuki