Re: [PATCH v2 5/6] coresight: Add format attribute for setting the timestamp interval

On Wed, Oct 01, 2025 at 02:28:15PM +0100, Coresight ML wrote:

[...]

...

Unfortunately that won't work because you'd have to always include coresight-etm4x.h. This file is compiled for both arm32 and arm64 so it would break the arm32 build.

I could define the TTR_CFG_FLD_ts_level_* stuff somewhere else but then it becomes messier than just doing the #ifdefs here.

ATTR_CFG_FLD_ts_level_* is only used in coresight-etm4x-core.c, it is not used in coresight-etm-perf.c. Thus, we don't need to include coresight-etm4x.h in coresight-etm-perf.c. Do I miss anything?

Now I understand that you are using GEN_PMU_FORMAT_ATTR, so need to used TTR_CFG_FLD_ts_level_* macro defined in coresight-etm4x.h.

Thanks, Leo