Re: [PATCH v5 09/15] coresight: trbe: Add infrastructure for Errata handling

Hi Arnd

Thanks for the report.

On 29/10/2021 11:31, Arnd Bergmann wrote:

On Fri, Oct 15, 2021 at 12:31 AM Suzuki K Poulose suzuki.poulose@arm.com wrote:

...

+static void trbe_check_errata(struct trbe_cpudata *cpudata) +{

•   int i;
  

•   for (i = 0; i < TRBE_ERRATA_MAX; i++) {
  

•           int cap = trbe_errata_cpucaps[i];
  

•           if (WARN_ON_ONCE(cap < 0))
  

•                   return;
  

•           if (this_cpu_has_cap(cap))
  

•                   set_bit(i, cpudata->errata);
  

•   }
  

+}

this_cpu_has_cap() is private to arch/arm64 and not exported, so this causes a build failure when used from a loadable module:

ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!

Should this symbol be exported or do we need a different workaround?

This should be exported. I can send in a patch.

Suzuki