Hi,
(+coresight mailing lists.)
Looked at this - -fpic is supposed to generate smaller code then -fPIC. That said, I've tried both variants for x86_64 and aarch64 builds:
x86_64 showed no change, (gcc 5.4) cross compiled aarch64 code was 0.45% smaller using -fpic rather than -fPIC. (gcc 6.2) native compiled aarch64 code showed no change (gcc 4.9)
While we could add some code to the makefile to dynamically change the -fPIC/pic option when building on sparc architectures, unless there are objections on the mailing list, I propose to change to -fPIC across the board at this point.
This will be released as a 0.11.1 patch (along with another minor build fix.)
Regards
Mike
On Wed, 13 Mar 2019 at 08:50, John Paul Adrian Glaubitz < notifications@github.com> wrote:
I have just tested this on sparc64 and can confirm that replacing -fpic with -fPIC fixes the issue for me.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Linaro/OpenCSD/issues/16#issuecomment-472332457, or mute the thread https://github.com/notifications/unsubscribe-auth/AMvwsxbzERGcBbzJECyGHDUxntbh6moBks5vWLvkgaJpZM4bsquw .
After reading on it a little [1] I don't see a problem.
Mathieu.
[1]. https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#Code-Gen-Options
---------- Forwarded message --------- From: Mike Leach mike.leach@linaro.org Date: Wed, 13 Mar 2019 at 06:08 Subject: Re: [Linaro/OpenCSD] Use -fPIC rather than -fpic (#16) To: Linaro/OpenCSD < reply+00cbf0b3eb7bba2371ba5d095e73e2f1f478b1a48c89aa5b92cf0000000118a0866492a169ce190e6dfa@reply.github.com>, coresight@lists.linaro.org Cc: Subscribed subscribed@noreply.github.com, Linaro/OpenCSD < OpenCSD@noreply.github.com>
Hi,
(+coresight mailing lists.)
Looked at this - -fpic is supposed to generate smaller code then -fPIC. That said, I've tried both variants for x86_64 and aarch64 builds:
x86_64 showed no change, (gcc 5.4) cross compiled aarch64 code was 0.45% smaller using -fpic rather than -fPIC. (gcc 6.2) native compiled aarch64 code showed no change (gcc 4.9)
While we could add some code to the makefile to dynamically change the -fPIC/pic option when building on sparc architectures, unless there are objections on the mailing list, I propose to change to -fPIC across the board at this point.
This will be released as a 0.11.1 patch (along with another minor build fix.)
Regards
Mike
On Wed, 13 Mar 2019 at 08:50, John Paul Adrian Glaubitz < notifications@github.com> wrote:
I have just tested this on sparc64 and can confirm that replacing -fpic with -fPIC fixes the issue for me.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Linaro/OpenCSD/issues/16#issuecomment-472332457, or mute the thread https://github.com/notifications/unsubscribe-auth/AMvwsxbzERGcBbzJECyGHDUxntbh6moBks5vWLvkgaJpZM4bsquw .
-
Mathieu Poirier -
Mike Leach