On 17/07/25 1:08 AM, Dan Carpenter wrote:

The devm_ioremap_resource() function returns error pointers on error. It never returns NULL. Update the error checking to match.

Fixes: 26e20622a8ae ("coresight: add coresight Trace Network On Chip driver") Signed-off-by: Dan Carpenter dan.carpenter@linaro.org

---

drivers/hwtracing/coresight/coresight-tnoc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-tnoc.c b/drivers/hwtracing/coresight/coresight-tnoc.c index 0e4164707eea..d542df46ea39 100644 --- a/drivers/hwtracing/coresight/coresight-tnoc.c +++ b/drivers/hwtracing/coresight/coresight-tnoc.c @@ -183,8 +183,8 @@ static int trace_noc_probe(struct amba_device *adev, const struct amba_id *id) dev_set_drvdata(dev, drvdata); drvdata->base = devm_ioremap_resource(dev, &adev->res);

• if (!drvdata->base)

• return -ENOMEM;
  

• if (IS_ERR(drvdata->base))

• return PTR_ERR(drvdata->base);
  

spin_lock_init(&drvdata->spinlock);

Do we still have more similar instances in coresight ?