Hi Wookey,

On Sun, 22 Nov 2020 at 20:45, Wookey wookey@wookware.org wrote:

On 2020-11-18 16:03 +0000, Mike Leach wrote:

...

With build fixes and minor bugfixes. See README for details.

Now in Debian unstable.

A couple of minor patches worth upstreaming:

Typo releated -> related

--- libopencsd-0.14.4.orig/decoder/source/etmv4/trc_pkt_decode_etmv4i.cpp +++ libopencsd-0.14.4/decoder/source/etmv4/trc_pkt_decode_etmv4i.cpp @@ -525,7 +525,7 @@ ocsd_err_t TrcPktDecodeEtmV4I::decodePac //resp = OCSD_RESP_FATAL_INVALID_DATA; #endif err = OCSD_ERR_UNSUPP_DECODE_PKT;

•    LogError(ocsdError(sev, err, "Data trace releated, unsupported packet t
  

ype."));

•    LogError(ocsdError(sev, err, "Data trace related, unsupported packet ty
  

pe.")); } break;

Thanks - that will make it into the next version.

Also the doc process produces 59 duplicate files. You can save about 1M by deduping with jdupes -rl $(OCSD_ROOT)/docs/html

The debian build now does this, but you might want to upstream it on linux builds?

I found that jdupes wasn't present on my system as standard - so may lay off this for now. Thanks for the tip though.

I also wrote a man page for trc_pkt_lister. It would be good if this was incorporated upstream rather than only available to debian users. It's also less likely to bit-rot and get updated for changes if it's upstream. https://salsa.debian.org/wookey/libopencsd/-/blob/master/debian/trc_pkt_list...

Thanks for writing this. This file will appear in decoder/docs/man in the next release, with a minor update to reflect a new option in the release. I've also added an install option for it in the makefile.

New version will be coming out soon - but will need co-ordinating with a perf patch, as it represents a significant update, with new output packets - and hence a changed enum that would otherwise break the perf build.

Regards

Mike

Wookey

Principal hats: Linaro, Debian, Wookware, ARM http://wookware.org/ _______________________________________________ CoreSight mailing list CoreSight@lists.linaro.org https://lists.linaro.org/mailman/listinfo/coresight