Re: [PATCH v1 1/3] dt-bindings: arm: qcom,coresight-static-replicator: Add property for source filtering
On 7/5/2024 6:38 PM, Rob Herring (Arm) wrote:
On Fri, 05 Jul 2024 16:51:50 +0800, Tao Zhang wrote:
Add a new property "filter_src" to label the source corresponding to the output connection for a static replicator. By combining a funnel and a static replicator in devicetree, a new device that supports multi-port input and multi-port output is implemented. In order to match the output port with the input port and successfully build the trace path, add this new property to indicate the data source corresponding to this output port.
Signed-off-by: Tao Zhang quic_taozha@quicinc.com
.../arm/arm,coresight-static-replicator.yaml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml: ^port@[01]$: Missing additionalProperties/unevaluatedProperties constraint /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml: endpoint: Missing additionalProperties/unevaluatedProperties constraint
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/2024070508515...
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Yes, I didn't see this errors in running 'make dt_binding_check', I will re-run this check
according to your suggestion.
Best,
Tao
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 7/5/2024 11:23 PM, Tao Zhang wrote:
On 7/5/2024 6:38 PM, Rob Herring (Arm) wrote:
On Fri, 05 Jul 2024 16:51:50 +0800, Tao Zhang wrote:
Add a new property "filter_src" to label the source corresponding to the output connection for a static replicator. By combining a funnel and a static replicator in devicetree, a new device that supports multi-port input and multi-port output is implemented. In order to match the output port with the input port and successfully build the trace path, add this new property to indicate the data source corresponding to this output port.
Signed-off-by: Tao Zhang quic_taozha@quicinc.com
.../arm/arm,coresight-static-replicator.yaml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml: ^port@[01]$: Missing additionalProperties/unevaluatedProperties constraint /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml: endpoint: Missing additionalProperties/unevaluatedProperties constraint
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/2024070508515...
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Yes, I didn't see this errors in running 'make dt_binding_check', I will re-run this check
according to your suggestion.
Best,
Tao
After upgrading dtschema and installing 'yamllint', I saw the above errors in running
'dt_binding_check'. I will fix them and update in the next patch series.
Best,
Tao
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
CoreSight mailing list -- coresight@lists.linaro.org To unsubscribe send an email to coresight-leave@lists.linaro.org
-
Tao Zhang