HI James,
Agreed the header is missing from the install. Looking in more detail the header should also be part of ocsd_c_api_types.h so that it gets pulled in by any program including the main api header.
I'll look at an update to fix both these issues.
Normally these should come through the CS mailing list, or as an issue on the git hub project.
Thanks
Mike
On Fri, 16 Jul 2021 at 14:56, James Clark james.clark@arm.com wrote:
To be able to instantiate the OCSD_BUILTIN_DCD_ETE decoder the header trc_pkt_types_ete.h is required, so install it alongside the headers for the other versions.
Signed-off-by: James Clark james.clark@arm.com
decoder/build/linux/rctdl_c_api_lib/makefile | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/decoder/build/linux/rctdl_c_api_lib/makefile b/decoder/build/linux/rctdl_c_api_lib/makefile index a0bd5a3..7b4055d 100644 --- a/decoder/build/linux/rctdl_c_api_lib/makefile +++ b/decoder/build/linux/rctdl_c_api_lib/makefile @@ -113,6 +113,8 @@ install_inc: $(INSTALL) --mode=0644 $(INST_INC_SRC)/etmv3/trc_pkt_types_etmv3.h $(INST_INC_DST)/etmv3/ $(INSTALL) -d --mode=0755 $(INST_INC_DST)/etmv4 $(INSTALL) --mode=0644 $(INST_INC_SRC)/etmv4/trc_pkt_types_etmv4.h $(INST_INC_DST)/etmv4/
$(INSTALL) -d --mode=0755 $(INST_INC_DST)/ete$(INSTALL) --mode=0644 $(INST_INC_SRC)/ete/trc_pkt_types_ete.h $(INST_INC_DST)/ete/ $(INSTALL) -d --mode=0755 $(INST_INC_DST)/c_api $(INSTALL) --mode=0644 $(INST_INC_SRC)/c_api/ocsd_c_api_types.h $(INST_INC_DST)/c_api/ $(INSTALL) --mode=0644 $(INST_INC_SRC)/c_api/opencsd_c_api.h $(INST_INC_DST)/c_api/-- 2.28.0
James,
I've sent a patchset to the list that is the proposed complete fix for the issue you found. Please try it out when you get time. You should be able to build by including only the c-api main headers, as the others are pulled in from there
Cheers
Mike
On Fri, 16 Jul 2021 at 15:36, Mike Leach mike.leach@linaro.org wrote:
HI James,
Agreed the header is missing from the install. Looking in more detail the header should also be part of ocsd_c_api_types.h so that it gets pulled in by any program including the main api header.
I'll look at an update to fix both these issues.
Normally these should come through the CS mailing list, or as an issue on the git hub project.
Thanks
Mike
On Fri, 16 Jul 2021 at 14:56, James Clark james.clark@arm.com wrote:
To be able to instantiate the OCSD_BUILTIN_DCD_ETE decoder the header trc_pkt_types_ete.h is required, so install it alongside the headers for the other versions.
Signed-off-by: James Clark james.clark@arm.com
decoder/build/linux/rctdl_c_api_lib/makefile | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/decoder/build/linux/rctdl_c_api_lib/makefile b/decoder/build/linux/rctdl_c_api_lib/makefile index a0bd5a3..7b4055d 100644 --- a/decoder/build/linux/rctdl_c_api_lib/makefile +++ b/decoder/build/linux/rctdl_c_api_lib/makefile @@ -113,6 +113,8 @@ install_inc: $(INSTALL) --mode=0644 $(INST_INC_SRC)/etmv3/trc_pkt_types_etmv3.h $(INST_INC_DST)/etmv3/ $(INSTALL) -d --mode=0755 $(INST_INC_DST)/etmv4 $(INSTALL) --mode=0644 $(INST_INC_SRC)/etmv4/trc_pkt_types_etmv4.h $(INST_INC_DST)/etmv4/
$(INSTALL) -d --mode=0755 $(INST_INC_DST)/ete$(INSTALL) --mode=0644 $(INST_INC_SRC)/ete/trc_pkt_types_ete.h $(INST_INC_DST)/ete/ $(INSTALL) -d --mode=0755 $(INST_INC_DST)/c_api $(INSTALL) --mode=0644 $(INST_INC_SRC)/c_api/ocsd_c_api_types.h $(INST_INC_DST)/c_api/ $(INSTALL) --mode=0644 $(INST_INC_SRC)/c_api/opencsd_c_api.h $(INST_INC_DST)/c_api/-- 2.28.0
-- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK
-- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK
-
Mike Leach