Hi Mike,

We don't require a release, just this patch applied to github repo please.

Thanks

Ruslan

On Wed, Mar 21, 2018 at 07:55:21AM +0000, Mike Leach wrote:

Hi Rusian,

I've seen your patch /pull request and agree with your solution. I am at a conference this week, but expect to make an updated openCSD release next week with your patch and some other patches required for debian packaging.

Thanks for your input.

Regards

Mike

On 20 March 2018 at 15:45, Ruslan Bukin ruslan.bukin@cl.cam.ac.uk wrote:

...

Hi

I'm adding Coresight tracing support to FreeBSD.

The kernel support is currently on review (https://reviews.freebsd.org/D14618, https://reviews.freebsd.org/D12875).

At this step I would like to include OpenCSD to base FreeBSD distribution, but I have small local change preventing me to do so.

Here is a small patch to OpenCSD attached. Can someone take a look? We use LLVM and the 'params' vector is left uninitialized in ETMv4 decoder.

I'm not sure if this is correct fix, but it works fine for us.

I also added a pull request here: https://github.com/Linaro/OpenCSD/pull/12

Thank you.

Ruslan

---

CoreSight mailing list CoreSight@lists.linaro.org https://lists.linaro.org/mailman/listinfo/coresight

-- Mike Leach Principal Engineer, ARM Ltd. Blackburn Design Centre. UK

Hi Mike

Can you apply pull request? I would like to import OpenCSD (latest git) to the FreeBSD distribution, but I need to have problem fixed first.

Thanks

Thanks

On Wed, Mar 21, 2018 at 07:55:21AM +0000, Mike Leach wrote:

Hi Rusian,

I've seen your patch /pull request and agree with your solution. I am at a conference this week, but expect to make an updated openCSD release next week with your patch and some other patches required for debian packaging.

Thanks for your input.

Regards

Mike

On 20 March 2018 at 15:45, Ruslan Bukin ruslan.bukin@cl.cam.ac.uk wrote:

...

Hi

I'm adding Coresight tracing support to FreeBSD.

The kernel support is currently on review (https://reviews.freebsd.org/D14618, https://reviews.freebsd.org/D12875).

At this step I would like to include OpenCSD to base FreeBSD distribution, but I have small local change preventing me to do so.

Here is a small patch to OpenCSD attached. Can someone take a look? We use LLVM and the 'params' vector is left uninitialized in ETMv4 decoder.

I'm not sure if this is correct fix, but it works fine for us.

I also added a pull request here: https://github.com/Linaro/OpenCSD/pull/12

Thank you.

Ruslan

---

CoreSight mailing list CoreSight@lists.linaro.org https://lists.linaro.org/mailman/listinfo/coresight

-- Mike Leach Principal Engineer, ARM Ltd. Blackburn Design Centre. UK

Hi Ruslan,

Looking at the LICENSE file I agree that there is no "above" copyright - possibly because there are multiple contributors to the project. All the individual source files have copyright notices though.

Reading further, clauses 1) and 2), even in the absence of a copyright notice, do require that the list of conditions, and the disclaimer is included with source/binary distributions. E.g. "2) Redistributions in binary form must reproduce .... , this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution."

On that basis I would say that LICENSE does have the effect of requiring the distributor to reproduce the conditions and disclaimer.

Regards

Mike

-----Original Message----- From: CoreSight coresight-bounces@lists.linaro.org On Behalf Of Ruslan Bukin Sent: 06 April 2018 10:58 To: Mike Leach mike.leach@linaro.org Cc: coresight@lists.linaro.org Subject: Re: OpenCSD FreeBSD patch

Hi Mike

I imported OpenCSD to the FreeBSD distribution.

One question we are discussing currently is a license of OpenCSD.

We found that license form is broken: if you read LICENSE there is no copyright "above" to retain, or print for a binary release. As a consumer of that LICENSE technically I have to display nothing. We believe that is is not the desired intent.

Can you take a look ?

Thanks

Ruslan

On Wed, Mar 21, 2018 at 07:55:21AM +0000, Mike Leach wrote:

Hi Rusian,

I've seen your patch /pull request and agree with your solution. I am at a conference this week, but expect to make an updated openCSD release next week with your patch and some other patches required for debian packaging.

Thanks for your input.

Regards

Mike

On 20 March 2018 at 15:45, Ruslan Bukin ruslan.bukin@cl.cam.ac.uk wrote:

...

Hi

I'm adding Coresight tracing support to FreeBSD.

The kernel support is currently on review (https://reviews.freebsd.org/D14618, https://reviews.freebsd.org/D12875).

At this step I would like to include OpenCSD to base FreeBSD distribution, but I have small local change preventing me to do so.

Here is a small patch to OpenCSD attached. Can someone take a look? We use LLVM and the 'params' vector is left uninitialized in ETMv4 decoder.

I'm not sure if this is correct fix, but it works fine for us.

I also added a pull request here: https://github.com/Linaro/OpenCSD/pull/12

Thank you.

Ruslan

---

CoreSight mailing list CoreSight@lists.linaro.org https://lists.linaro.org/mailman/listinfo/coresight

-- Mike Leach Principal Engineer, ARM Ltd. Blackburn Design Centre. UK

_______________________________________________ CoreSight mailing list CoreSight@lists.linaro.org https://lists.linaro.org/mailman/listinfo/coresight IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.