Hi Conor,
-----Original Message----- From: Conor Dooley conor@kernel.org Sent: Saturday, October 14, 2023 6:56 PM To: Linu Cherian lcherian@marvell.com Cc: Mike Leach mike.leach@linaro.org; suzuki.poulose@arm.com; james.clark@arm.com; leo.yan@linaro.org; linux-arm- kernel@lists.infradead.org; coresight@lists.linaro.org; linux- kernel@vger.kernel.org; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; devicetree@vger.kernel.org; Sunil Kovvuri Goutham sgoutham@marvell.com; George Cherian gcherian@marvell.com Subject: Re: [EXT] Re: [PATCH 1/7] dt-bindings: arm: coresight-tmc: Add "memory-region" property
On Sat, Oct 14, 2023 at 11:36:37AM +0000, Linu Cherian wrote:
- description: Reserved meta data memory. Used for ETR and ETF
sinks.
- memory-region-names:
- items:
- const: trace-mem
- const: metadata-mem
Is there a constraint required here? If we are using the memory area for trace in a panic situation, then we must have the meta data memory area defined? Perhaps a set of names such as "etr-trace-mem", "panic-trace-mem" , "panic-metadata-mem", were the first is for general ETR trace in non-panic situation and then constrain the "panic-" areas to appear
together.
The "etr-trace-mem", "panic-trace-mem" could easily point to the same area.
As noted above, we do not have other generic use case for these reserved
regions now.
Hence two regions/names, panic-trace-mem and panic-metadata-mem
with
constraints kept as minItems: 2 and maxItems: 2 would suffice ?
Whatever you do, please delete the -mem suffix.
Ack.