The content of this message was lost. It was probably cross-posted to multiple lists and previously handled on another list.
On ١١/٣/٢٠٢٣ ١٤:٥٧, Menna Mahmoud wrote:
On ١١/٣/٢٠٢٣ ١٤:٥٥, Julia Lawall wrote:
On Sat, 11 Mar 2023, Menna Mahmoud wrote:
On ١١/٣/٢٠٢٣ ١٠:٥٩, Julia Lawall wrote:
On Fri, 10 Mar 2023, Menna Mahmoud wrote:
Fix " CHECK: Alignment should match open parenthesis " Reported by checkpath
See the message in the other mail about the log message.
Also, you should not have two patches with the same subject. Here, the changes are on the same file and are essentially the same, even involving the same function call. So they can be together in one patch.
julia
okay, I will. appreciate your feedback. thanks.
Please put some blank lines around your response, so it is easier to find.
thanks, julia
Okay, I will.
thanks,
Menna
Hi Julia,
according to Alex feedback
" I think this type of alignment is not a major problem, and alignment isn't done this way in general in this driver, it's probably OK to keep it that way. - Alex "
,I won't resubmit these patches, right?
-Menna
Signed-off-by: Menna Mahmoud eng.mennamahmoud.mm@gmail.com
drivers/staging/greybus/fw-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index 57bebf24636b..f562cb12d5ad 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, }
connection = gb_connection_create(bundle, cport_id, - gb_fw_mgmt_request_handler);
gb_fw_mgmt_request_handler); if (IS_ERR(connection)) { ret = PTR_ERR(connection); dev_err(&bundle->dev, -- 2.34.1
On Sat, Mar 11, 2023 at 04:06:51PM +0200, Menna Mahmoud wrote:
according to Alex feedback
" I think this type of alignment is not a major problem, and alignment isn't done this way in general in this driver, it's probably OK to keep it that way. - Alex "
,I won't resubmit these patches, right?
Yeah. Find something else to fix.
I feel like in outreachy and similar that people send a first patch and then they get a bunch of different feedback. And it's like checkpatch is complaining and it's staging code so probably the code is actually ugly in a way. But often it's better to abandon the project instead of getting obsessed with it. Zoom out a bit. Find something else where it's obvious how to improve the code from a readability perspective.
People are giving you feedback to help you and not because they are about that particular line of code. They won't care if you work on something else instead.
regards, dan carpenter
On Sat, Mar 11, 2023 at 05:23:11PM +0300, Dan Carpenter wrote:
People are giving you feedback to help you and not because they are
^^^ I meant "care" not "are".
about that particular line of code.
regards, dan carpenter
On ١١/٣/٢٠٢٣ ١٦:٢٣, Dan Carpenter wrote:
On Sat, Mar 11, 2023 at 04:06:51PM +0200, Menna Mahmoud wrote:
according to Alex feedback
" I think this type of alignment is not a major problem, and alignment isn't done this way in general in this driver, it's probably OK to keep it that way. - Alex "
,I won't resubmit these patches, right?
Yeah. Find something else to fix.
I feel like in outreachy and similar that people send a first patch and then they get a bunch of different feedback. And it's like checkpatch is complaining and it's staging code so probably the code is actually ugly in a way. But often it's better to abandon the project instead of getting obsessed with it. Zoom out a bit. Find something else where it's obvious how to improve the code from a readability perspective.
People are giving you feedback to help you and not because they are about that particular line of code. They won't care if you work on something else instead.
regards, dan carpenter
Got it, thanks Dan.
On Sat, 11 Mar 2023, Menna Mahmoud wrote:
On ١١/٣/٢٠٢٣ ١٤:٥٧, Menna Mahmoud wrote:
On ١١/٣/٢٠٢٣ ١٤:٥٥, Julia Lawall wrote:
On Sat, 11 Mar 2023, Menna Mahmoud wrote:
On ١١/٣/٢٠٢٣ ١٠:٥٩, Julia Lawall wrote:
On Fri, 10 Mar 2023, Menna Mahmoud wrote:
Fix " CHECK: Alignment should match open parenthesis " Reported by checkpath
See the message in the other mail about the log message.
Also, you should not have two patches with the same subject. Here, the changes are on the same file and are essentially the same, even involving the same function call. So they can be together in one patch.
julia
okay, I will. appreciate your feedback. thanks.
Please put some blank lines around your response, so it is easier to find.
thanks, julia
Okay, I will.
thanks,
Menna
Hi Julia,
according to Alex feedback
" I think this type of alignment is not a major problem, and alignment isn't done this way in general in this driver, it's probably OK to keep it that way. - Alex "
,I won't resubmit these patches, right?
The existing code indeed looks better to me. So you can skip this issue.
julia
-Menna
Signed-off-by: Menna Mahmoud eng.mennamahmoud.mm@gmail.com
drivers/staging/greybus/fw-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index 57bebf24636b..f562cb12d5ad 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, }
connection = gb_connection_create(bundle, cport_id, - gb_fw_mgmt_request_handler);
gb_fw_mgmt_request_handler); if (IS_ERR(connection)) { ret = PTR_ERR(connection); dev_err(&bundle->dev, -- 2.34.1
On ١١/٣/٢٠٢٣ ١٦:٣٨, Julia Lawall wrote:
On Sat, 11 Mar 2023, Menna Mahmoud wrote:
On ١١/٣/٢٠٢٣ ١٤:٥٧, Menna Mahmoud wrote:
On ١١/٣/٢٠٢٣ ١٤:٥٥, Julia Lawall wrote:
On Sat, 11 Mar 2023, Menna Mahmoud wrote:
On ١١/٣/٢٠٢٣ ١٠:٥٩, Julia Lawall wrote:
On Fri, 10 Mar 2023, Menna Mahmoud wrote:
> Fix " CHECK: Alignment should match open parenthesis " > Reported by checkpath See the message in the other mail about the log message.
Also, you should not have two patches with the same subject. Here, the changes are on the same file and are essentially the same, even involving the same function call. So they can be together in one patch.
julia
okay, I will. appreciate your feedback. thanks.
Please put some blank lines around your response, so it is easier to find.
thanks, julia
Okay, I will.
thanks,
Menna
Hi Julia,
according to Alex feedback
" I think this type of alignment is not a major problem, and alignment isn't done this way in general in this driver, it's probably OK to keep it that way. - Alex "
,I won't resubmit these patches, right?
The existing code indeed looks better to me. So you can skip this issue.
julia
Okay, thanks Julia.
-Menna
> Signed-off-by: Menna Mahmoud eng.mennamahmoud.mm@gmail.com > --- > drivers/staging/greybus/fw-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/fw-core.c > b/drivers/staging/greybus/fw-core.c > index 57bebf24636b..f562cb12d5ad 100644 > --- a/drivers/staging/greybus/fw-core.c > +++ b/drivers/staging/greybus/fw-core.c > @@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle > *bundle, > } > > connection = gb_connection_create(bundle, cport_id, > - gb_fw_mgmt_request_handler); > + > gb_fw_mgmt_request_handler); > if (IS_ERR(connection)) { > ret = PTR_ERR(connection); > dev_err(&bundle->dev, > -- > 2.34.1 > > >
-
Dan Carpenter -
eng.mennamahmoud.mm＠gmail.com -
Julia Lawall -
Menna Mahmoud