On Monday, August 29, 2016 2:06:19 AM CEST Build bot for Mark Brown wrote:
Tree/Branch: master Git describe: v4.8-rc3-252-g25d0d91 Commit: 25d0d91af7 Merge tag 'drm-fixes-for-4.8-rc4' of git://people.freedesktop.org/~airlied/linux
Build Time: 92 min 56 sec
Passed: 7 / 10 ( 70.00 %) Failed: 3 / 10 ( 30.00 %)
Errors: 1 Warnings: 1 Section Mismatches: 0
Failed defconfigs: arm-allmodconfig arm-multi_v7_defconfig arm-multi_v5_defconfig
Errors:
arm-allmodconfig ../drivers/clocksource/timer-atmel-pit.c:264:2: error: 'ret' undeclared (first use in this function)
arm-multi_v7_defconfig ../drivers/clocksource/timer-atmel-pit.c:264:2: error: 'ret' undeclared (first use in this function)
arm-multi_v5_defconfig ../drivers/clocksource/timer-atmel-pit.c:264:2: error: 'ret' undeclared (first use in this function)
This was caused by the commit below, which misses a declaration of the 'ret' variable.
Arnd
commit 699e36e5b8e9f77b2be4c23f0b309e53be4b2880 Author: Alexandre Belloni alexandre.belloni@free-electrons.com Date: Tue Aug 23 10:44:02 2016 +0200
clocksource/drivers/timer-atmel-pit: Enable mck clock
mck is needed to get the PIT working. Explicitly prepare_enable it instead of assuming it is enabled.
This solves an issue where the system is freezing when the ETM/ETB drivers are enabled.
Reported-by: Olivier Schonken olivier.schonken@gmail.com Reviewed-by: Boris Brezillon boris.brezillon@free-electrons.com Acked-by: Nicolas Ferre nicolas.ferre@atmel.com Signed-off-by: Alexandre Belloni alexandre.belloni@free-electrons.com Signed-off-by: Daniel Lezcano daniel.lezcano@linaro.org
diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c index 1ffac0cb0cb7..3494bc5a21d5 100644 --- a/drivers/clocksource/timer-atmel-pit.c +++ b/drivers/clocksource/timer-atmel-pit.c @@ -261,6 +261,12 @@ static int __init at91sam926x_pit_dt_init(struct device_node *node) return PTR_ERR(data->mck); }
+ ret = clk_prepare_enable(data->mck); + if (ret) { + pr_err("Unable to enable mck\n"); + return ret; + } + /* Get the interrupts property */ data->irq = irq_of_parse_and_map(node, 0); if (!data->irq) {