From: Thierry Reding <treding(a)nvidia.com>
The seqno_fence_init() function's cond argument isn't described in the
kerneldoc comment. Fix that to silence a warning when building DocBook
documentation.
Signed-off-by: Thierry Reding <treding(a)nvidia.com>
---
include/linux/seqno-fence.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/seqno-fence.h b/include/linux/seqno-fence.h
index 3d6003de4b0d..a1ba6a5ccdd6 100644
--- a/include/linux/seqno-fence.h
+++ b/include/linux/seqno-fence.h
@@ -62,6 +62,7 @@ to_seqno_fence(struct fence *fence)
* @context: the execution context this fence is a part of
* @seqno_ofs: the offset within @sync_buf
* @seqno: the sequence # to signal on
+ * @cond: fence wait condition
* @ops: the fence_ops for operations on this seqno fence
*
* This function initializes a struct seqno_fence with passed parameters,
--
2.0.4
From: Thierry Reding <treding(a)nvidia.com>
kerneldoc doesn't know how to parse variables, so don't let it try.
Signed-off-by: Thierry Reding <treding(a)nvidia.com>
---
drivers/dma-buf/fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/fence.c b/drivers/dma-buf/fence.c
index 4222cb2aa96a..7bb9d65d9a2c 100644
--- a/drivers/dma-buf/fence.c
+++ b/drivers/dma-buf/fence.c
@@ -29,7 +29,7 @@
EXPORT_TRACEPOINT_SYMBOL(fence_annotate_wait_on);
EXPORT_TRACEPOINT_SYMBOL(fence_emit);
-/**
+/*
* fence context counter: each execution context should have its own
* fence context, this allows checking if fences belong to the same
* context or not. One device can have multiple separate contexts,
--
2.0.4
Dear Joonsoo,
I tried your changes which are present at the below link.
https://github.com/JoonsooKim/linux/tree/cma-fix-up-v3.0-next-20140625
But unfortunately for me it did not help much.
After running various apps that uses ION nonmovable memory, it fails to allocate memory after some time. When I see the pagetypeinfo shows lots of CMA pages available and non-movable were very less and thus nonmovable allocation were failing.
However I noticed the failure was little delayed.
Also I noticed that the CMA utilized and the CMA free is not matching with total CMA size.
In my system RAM is 256MB and CMA configured is 56MB.
And free memory was hanging around 30-40MB during failure.
Am I missing something?
My kernel version is 3.10 and I applied the changes manually.
If there are other sets of patches that needs to be applied, please let me know.
Note, I did not apply the ALLOC_CMA removal patches.
Now I am experimenting more and will share if I have any findings.
Thank you!
Pintu
Sent from Samsung Mobile
-------- Original message --------
From: Joonsoo Kim <iamjoonsoo.kim(a)lge.com>
Date: 29/07/2014 5:06 PM (GMT+09:00)
To: 'pintu_agarwal' <pintu_agarwal(a)yahoo.com>,linux-mm@kvack.org,linux-arm-kernel@lists.infradead.org,linaro-mm-sig@lists.linaro.org,ritesh.list@gmail.com
Cc: pintu.k@outlook.com,pintu.k@samsung.com,vishu_1385@yahoo.com,m.szyprowski@samsung.com,mina86@mina86.com,ngupta@vflare.org,iqbalblr@gmail.com
Subject: RE: [linux-3.10.17] Could not allocate memory from free CMA areas
From: pintu_agarwal [mailto:pintu_agarwal@yahoo.com]
Sent: Friday, July 25, 2014 12:15 AM
To: PINTU KUMAR; linux-mm(a)kvack.org; linux-arm-kernel(a)lists.infradead.org; linaro-mm-sig(a)lists.linaro.org; iamjoonsoo.kim(a)lge.com; ritesh.list(a)gmail.com
Cc: pintu.k(a)outlook.com; pintu.k(a)samsung.com; vishu_1385(a)yahoo.com; m.szyprowski(a)samsung.com; mina86(a)mina86.com; ngupta(a)vflare.org; iqbalblr(a)gmail.com
Subject: RE: [linux-3.10.17] Could not allocate memory from free CMA areas
Dear joonsoo kim,
> I have your patches for: Aggressively allocate memory from cma ....
> We are facing almost similar problem here.
> If any of your patches still working for you please let us know here.
> I would like to try those approach.
Hello,
I stopped to implement it, because there are other bugs on CMA related codes.
Although aggressively allocate... doesn't have bugs itself, it enlarges
existing freepage counting bugs significantly so I'm first trying to fix
those bugs. See the below link.
https://lkml.org/lkml/2014/7/4/79
I will restart to implement aggressively... after fixing these bugs.
If you have interest on next version of aggressively allocate..., see the
following link.
https://github.com/JoonsooKim/linux/tree/cma-fix-up-v3.0-next-20140625
Thanks.
