Hi Lukasz,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.1-rc4 next-20221111] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Lukasz-Wiecaszek/udmabuf-add-... base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20221111114528.608801-1-lukasz.wiecaszek%40gmail.c... patch subject: [PATCH] udmabuf: add vmap method to udmabuf_ops config: m68k-allyesconfig compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/abc7204aeb6f9de98f5f614611551d... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Lukasz-Wiecaszek/udmabuf-add-vmap-method-to-udmabuf_ops/20221111-194718 git checkout abc7204aeb6f9de98f5f614611551d3c471f79d3 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/dma-buf/udmabuf.c:62:53: warning: 'struct dma_buf_map' declared inside parameter list will not be visible outside of this definition or declaration
62 | static int vmap_udmabuf(struct dma_buf *buf, struct dma_buf_map *map) | ^~~~~~~~~~~ drivers/dma-buf/udmabuf.c: In function 'vmap_udmabuf': drivers/dma-buf/udmabuf.c:72:9: error: implicit declaration of function 'dma_buf_map_set_vaddr'; did you mean 'iosys_map_set_vaddr'? [-Werror=implicit-function-declaration] 72 | dma_buf_map_set_vaddr(map, ubuf->vaddr); | ^~~~~~~~~~~~~~~~~~~~~ | iosys_map_set_vaddr drivers/dma-buf/udmabuf.c: At top level: drivers/dma-buf/udmabuf.c:179:30: error: initialization of 'int (*)(struct dma_buf *, struct iosys_map *)' from incompatible pointer type 'int (*)(struct dma_buf *, struct dma_buf_map *)' [-Werror=incompatible-pointer-types] 179 | .vmap = vmap_udmabuf, | ^~~~~~~~~~~~ drivers/dma-buf/udmabuf.c:179:30: note: (near initialization for 'udmabuf_ops.vmap') cc1: some warnings being treated as errors
vim +62 drivers/dma-buf/udmabuf.c
61
62 static int vmap_udmabuf(struct dma_buf *buf, struct dma_buf_map *map)
63 { 64 struct udmabuf *ubuf = buf->priv; 65 66 if (!ubuf->vaddr) { 67 ubuf->vaddr = vm_map_ram(ubuf->pages, ubuf->pagecount, -1); 68 if (!ubuf->vaddr) 69 return -EINVAL; 70 } 71 72 dma_buf_map_set_vaddr(map, ubuf->vaddr); 73 74 return 0; 75 } 76