Re: [Linaro-mm-sig] [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible

On 28 January 2015 at 16:50, Daniel Thompson daniel.thompson@linaro.org wrote:

On 28/01/15 06:00, Sumit Semwal wrote:

<snip>

...

+/**

• • helper macro for exporters; zeros and fills in most common values
• */

+#define DEFINE_DMA_BUF_EXPORT_INFO(a) \

• struct dma_buf_export_info a = {0};             \
  

• exp_info.exp_name = KBUILD_MODNAME
  

This risks generating C99 warnings unless used with care (and only once per function). Shouldn't this be more like:

#define DEFINE_DMA_BUF_EXPORT_INFO(a) \ struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME }

Ah! My bad; thanks for catching this, Daniel; I'll send out the updated patch in a minute!

Daniel.