Hi Rijo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on herbert-cryptodev-2.6/master] [also build test WARNING on herbert-crypto-2.6/master linus/master v6.1-rc8 next-20221206] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Rijo-Thomas/crypto-ccp-Alloca... base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master patch link: https://lore.kernel.org/r/43568d5e6395fcab48262fa5b3d1a5112918fbe8.166937219... patch subject: [PATCH 1/1] crypto: ccp - Allocate TEE ring and cmd buffer using DMA APIs config: x86_64-allyesconfig compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/5615778a8f19c66bbacb611c78175e... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Rijo-Thomas/crypto-ccp-Allocate-TEE-ring-and-cmd-buffer-using-DMA-APIs/20221206-203201 git checkout 5615778a8f19c66bbacb611c78175e3130aa22c0 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/crypto/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/crypto/ccp/tee-dev.c:117:20: warning: no previous prototype for 'tee_alloc_cmd_buffer' [-Wmissing-prototypes]
117 | struct dma_buffer *tee_alloc_cmd_buffer(struct psp_tee_device *tee) | ^~~~~~~~~~~~~~~~~~~~
vim +/tee_alloc_cmd_buffer +117 drivers/crypto/ccp/tee-dev.c
116
117 struct dma_buffer *tee_alloc_cmd_buffer(struct psp_tee_device *tee)
118 { 119 struct tee_init_ring_cmd *cmd; 120 struct dma_buffer *cmd_buffer; 121 122 cmd_buffer = psp_tee_alloc_dmabuf(sizeof(*cmd), 123 GFP_KERNEL | __GFP_ZERO); 124 if (!cmd_buffer) 125 return NULL; 126 127 cmd = (struct tee_init_ring_cmd *)cmd_buffer->vaddr; 128 cmd->hi_addr = upper_32_bits(tee->rb_mgr.ring_buf->paddr); 129 cmd->low_addr = lower_32_bits(tee->rb_mgr.ring_buf->paddr); 130 cmd->size = tee->rb_mgr.ring_buf->size; 131 132 dev_dbg(tee->dev, "tee: ring address: high = 0x%x low = 0x%x size = %u\n", 133 cmd->hi_addr, cmd->low_addr, cmd->size); 134 135 return cmd_buffer; 136 } 137