Successfully identified regression in *llvm* in CI configuration tcwg_bmk_llvm_tx1/llvm-master-aarch64-spec2k6-O3_LTO. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tx1/llvm-master-aarch64-spec2k6-O3_LTO
Culprit: <cut> commit a41f076ef1d611fcd255514d0c19cb06375e49b2 Author: Fangrui Song i@maskray.me Date: Mon Apr 26 16:04:22 2021 -0700
[test] Fix tools/gold/X86/weak.ll after D94202
The order regressed after D94202: after `a b`, when adding `a c`, we may reorder `a` to the right of `b`, causing the final order to be `b a c`. </cut>
Results regressed to (for first_bad == a41f076ef1d611fcd255514d0c19cb06375e49b2) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O3_LTO -- artifacts/build-a41f076ef1d611fcd255514d0c19cb06375e49b2/results_id: 1 # 447.dealII,dealII_base.default regressed by 107
from (for last_good == 262a72f50f1887591558ce0f521a5f7d3a17e2c2) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O3_LTO -- artifacts/build-262a72f50f1887591558ce0f521a5f7d3a17e2c2/results_id: 1
Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-a... Results ID of last_good: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-master-aarch64-spec2k6-O3_LTO/2269 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-a... Results ID of first_bad: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-master-aarch64-spec2k6-O3_LTO/2253 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-a...
Configuration details:
Reproduce builds: <cut> mkdir investigate-llvm-a41f076ef1d611fcd255514d0c19cb06375e49b2 cd investigate-llvm-a41f076ef1d611fcd255514d0c19cb06375e49b2
git clone https://git.linaro.org/toolchain/jenkins-scripts
mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-a... --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-a... --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-a... --fail chmod +x artifacts/test.sh
# Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh
# Save baseline build state (which is then restored in artifacts/test.sh) mkdir -p ./bisect rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /llvm/ ./ ./bisect/baseline/
cd llvm
# Reproduce first_bad build git checkout --detach a41f076ef1d611fcd255514d0c19cb06375e49b2 ../artifacts/test.sh
# Reproduce last_good build git checkout --detach 262a72f50f1887591558ce0f521a5f7d3a17e2c2 ../artifacts/test.sh
cd .. </cut>
History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/c...
Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-a... Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-a...
Full commit (up to 1000 lines): <cut> commit a41f076ef1d611fcd255514d0c19cb06375e49b2 Author: Fangrui Song i@maskray.me Date: Mon Apr 26 16:04:22 2021 -0700
[test] Fix tools/gold/X86/weak.ll after D94202
The order regressed after D94202: after `a b`, when adding `a c`, we may reorder `a` to the right of `b`, causing the final order to be `b a c`. --- llvm/test/tools/gold/X86/Inputs/weak.ll | 1 + llvm/test/tools/gold/X86/weak.ll | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/llvm/test/tools/gold/X86/Inputs/weak.ll b/llvm/test/tools/gold/X86/Inputs/weak.ll index 5209d343f23f..8aba5b261001 100644 --- a/llvm/test/tools/gold/X86/Inputs/weak.ll +++ b/llvm/test/tools/gold/X86/Inputs/weak.ll @@ -1,3 +1,4 @@ +target triple = "x86_64-unknown-linux-gnu" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
@a = weak global i32 41 diff --git a/llvm/test/tools/gold/X86/weak.ll b/llvm/test/tools/gold/X86/weak.ll index 384a0ab3ae8c..340de107b43b 100644 --- a/llvm/test/tools/gold/X86/weak.ll +++ b/llvm/test/tools/gold/X86/weak.ll @@ -6,6 +6,7 @@ ; RUN: -shared %t.o %t2.o -o %t3.o ; RUN: llvm-dis %t3.o -o - | FileCheck %s
+target triple = "x86_64-unknown-linux-gnu" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
@a = weak global i32 42 @@ -13,6 +14,6 @@ target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
; Test that @b and @c end up pointing to the same variable.
-; CHECK: @a = weak global i32 42 ; CHECK: @b = global i32* @a{{$}} +; CHECK: @a = weak global i32 42 ; CHECK: @c = global i32* @a{{$}} </cut>