On 11 January 2012 08:43, Javier Martinez Canillas javier@dowhile0.org wrote:
Add ISEE IGEPv2 board definition (an OMAP3730 based board).
Signed-off-by: Javier Martinez Canillas javier@dowhile0.org
It's polite to mention that patches are against qemu-linaro if you cc qemu-devel.
So my initial reaction to this is to ask what the benefit is of adding another basically-just-an-OMAP3 model. We already have beagle and overo, and this is obviously just cut-n-paste from overo (it still has the comment about "FAB revisions" which is specific to Overo, which doesn't give me a great deal of confidence that this is actually correctly modelling the IGEPv2 rather than just something random which happens to be able to boot an IGEPv2 kernel...)
GPLv2-only rather than v2-or-later is also going to be a problem, although I appreciate that that's because you've based this on the v2-only overo.c [which is going to be a problem for me later on when I try to upstream that :-)]
-- PMM