Linaro-uefi

linaro-uefi@lists.linaro.org

811 discussions

[PATCH v3 0/7] ATAPI support on SiI SATA adapter

by Jeremy Linton

The SiI isn't an AHCI compatible adapter so it implements the EFI ATA pass-through protocol directly. This works for fixed hard drives, but not ATAPI attached devices (CDROM, DVDROM, TAPE, etc). This patch adds read only ATAPI support via the EFI SCSI pass-through protocol, allowing boot from attached CD/DVD. This patch also cleans up, and tweaks recovery paths/etc in the original driver. When combined with the ARM/PCI dma lib changes this allows us to relax the IO alignment requirement that caused grub failures. Finally, the OpenPlatformPkg/Juno must be updated, with another patch to avoid build breaks now that the SiI has a dependency on the SCSI libraries. V2->V3: Send the correct patch, rather than the one I was running the patch checker against. V1->V2: Formatting corrections per Ard's comments and Daniil's updated patch checker. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton <jeremy.linton(a)arm.com> Jeremy Linton (7): EmbeddedPkg: SiI3132: Note that ARM is using this Dxe MdePkg IndustryStandard/Scsi.h: Add sense code macro EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks EmbeddedPkg: SiI3132: Add SCSI protocol support to header EmbeddedPkg: SiI3132: Break out FIS command submission EmbeddedPkg: SiI3132: Cleanup device node creation EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 49 ++- EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 93 ++++- .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf | 2 + .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 268 ++++++++----- .../Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c | 431 +++++++++++++++++++++ MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +- MdePkg/Include/IndustryStandard/Scsi.h | 2 + OpenPlatformPkg | 2 +- 8 files changed, 721 insertions(+), 128 deletions(-) create mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c -- 2.9.3

7 years, 9 months

[PATCH v2 0/9] enable Android Fastboot App on Hikey

by Haojian Zhuang

v2: * Fix the register offset sequence in Hi6220 head file. * Remove the unnecessary dependency. Set them in DSC & FDF file instead. v1: * Enable Android Fastboot App on HiKey platform. Haojian Zhuang (9): Platforms/Hisilicon/HiKey: append more register definitions Platforms/Hisilicon/HiKey: add HiKey variable space Drivers/Usb/DwUsb: support designware usb Platforms/Hisilicon/HiKey: append GUID in dec Platforms/Hisilicon/HiKey: support GPIO controller Platforms/Hisilicon/HiKey: support designware USB controller Platforms/Hisilicon/HiKey: support fastboot driver Platforms/Hisilicon/HiKey: add platform boot manager Platforms/Hisilicon/HiKey: enable Android Fastboot Chips/Hisilicon/Hi6220/Include/Hi6220.h | 29 + Drivers/Usb/DwUsbDxe/DwUsbDxe.c | 796 +++++++++++++++++++++ Drivers/Usb/DwUsbDxe/DwUsbDxe.dec | 46 ++ Drivers/Usb/DwUsbDxe/DwUsbDxe.h | 627 ++++++++++++++++ Drivers/Usb/DwUsbDxe/DwUsbDxe.inf | 52 ++ Include/Protocol/DwUsb.h | 81 +++ OpenPlatformPkg.dec | 1 + Platforms/Hisilicon/HiKey/HiKey.dec | 1 + Platforms/Hisilicon/HiKey/HiKey.dsc | 17 +- Platforms/Hisilicon/HiKey/HiKey.fdf | 6 +- .../HiKey/HiKeyFastbootDxe/HiKeyFastbootDxe.c | 705 ++++++++++++++++++ .../HiKey/HiKeyFastbootDxe/HiKeyFastbootDxe.inf | 61 ++ .../Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.c | 68 ++ .../Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.inf | 37 + .../Hisilicon/HiKey/HiKeyUsbDxe/HiKeyUsbDxe.c | 266 +++++++ .../Hisilicon/HiKey/HiKeyUsbDxe/HiKeyUsbDxe.inf | 46 ++ .../Hisilicon/HiKey/Include/Guid/HiKeyVariable.h | 24 + .../Library/PlatformBootManagerLib/PlatformBm.c | 485 +++++++++++++ .../Library/PlatformBootManagerLib/PlatformBm.h | 59 ++ .../PlatformBootManagerLib.inf | 88 +++ .../Library/PlatformBootManagerLib/QuietBoot.c | 680 ++++++++++++++++++ 21 files changed, 4172 insertions(+), 3 deletions(-) create mode 100644 Drivers/Usb/DwUsbDxe/DwUsbDxe.c create mode 100644 Drivers/Usb/DwUsbDxe/DwUsbDxe.dec create mode 100644 Drivers/Usb/DwUsbDxe/DwUsbDxe.h create mode 100644 Drivers/Usb/DwUsbDxe/DwUsbDxe.inf create mode 100644 Include/Protocol/DwUsb.h create mode 100644 Platforms/Hisilicon/HiKey/HiKeyFastbootDxe/HiKeyFastbootDxe.c create mode 100644 Platforms/Hisilicon/HiKey/HiKeyFastbootDxe/HiKeyFastbootDxe.inf create mode 100644 Platforms/Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.c create mode 100644 Platforms/Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.inf create mode 100644 Platforms/Hisilicon/HiKey/HiKeyUsbDxe/HiKeyUsbDxe.c create mode 100644 Platforms/Hisilicon/HiKey/HiKeyUsbDxe/HiKeyUsbDxe.inf create mode 100644 Platforms/Hisilicon/HiKey/Include/Guid/HiKeyVariable.h create mode 100644 Platforms/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c create mode 100644 Platforms/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.h create mode 100644 Platforms/Hisilicon/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf create mode 100644 Platforms/Hisilicon/Library/PlatformBootManagerLib/QuietBoot.c -- 2.7.4

7 years, 9 months

[Linaro-uefi v1] Hisilicon/D02: update FVMAIN_SEC.fv

by Chenhui Sun

From: Heyi Guo <heyi.guo(a)linaro.org> We need to rebuild FVMAIN_SEC.fv after enlarging FVMAIN_COMPACT, because the fv size and trustfirmware located base address changed. Signed-off-by: Chenhui Sun <sunchenhui(a)huawei.com> --- Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv | Bin 262144 -> 262144 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv index bac8767..49b61aa 100644 Binary files a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv and b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv differ -- 1.9.1

7 years, 9 months

[PATCH 0/4] enhance to support android kernel

by Haojian Zhuang

v1: * Fix the issue of booting kernel in AndroidFastboot. The issue was caused by broken LinuxLoader. * Add a new App to boot android kernel from storage device. Haojian Zhuang (4): EmbeddedPkg/AndroidFastboot: add the GetKernelArgs interface EmbeddedPkg/AndroidFastboot: fix to boot android kernel EmbeddedPkg: add Android boot device path EmbeddedPkg/AndroidBoot: boot android kernel from storage .../Application/AndroidBoot/AndroidBootApp.c | 118 +++++++++ .../Application/AndroidBoot/AndroidBootApp.h | 44 ++++ .../Application/AndroidBoot/AndroidBootApp.inf | 67 ++++++ .../Application/AndroidBoot/AndroidBootImg.c | 91 +++++++ .../AndroidBoot/Arm/BootAndroidBootImg.c | 268 +++++++++++++++++++++ .../AndroidFastboot/AndroidFastbootApp.c | 2 +- .../AndroidFastboot/AndroidFastbootApp.h | 21 +- .../AndroidFastboot/AndroidFastbootApp.inf | 4 + .../AndroidFastboot/Arm/BootAndroidBootImg.c | 230 +++++++++++++----- EmbeddedPkg/EmbeddedPkg.dec | 2 + .../Include/Protocol/AndroidFastbootPlatform.h | 13 + 11 files changed, 795 insertions(+), 65 deletions(-) create mode 100644 EmbeddedPkg/Application/AndroidBoot/AndroidBootApp.c create mode 100644 EmbeddedPkg/Application/AndroidBoot/AndroidBootApp.h create mode 100644 EmbeddedPkg/Application/AndroidBoot/AndroidBootApp.inf create mode 100644 EmbeddedPkg/Application/AndroidBoot/AndroidBootImg.c create mode 100644 EmbeddedPkg/Application/AndroidBoot/Arm/BootAndroidBootImg.c -- 2.7.4

7 years, 9 months

Aspen Project :UEFI GUID Partition Table (GPT) issue on Poplar board

by zhufuwengang

Hi ,all Lately I've been having a problem when I tried to boot kernel from EMMC. GUID Partition Table is the basic essentials for UEFI and must be stored on the device before power on;It has two header structures:the primary and the backup.The primary GPT Header must be located in LBA 1 (i.e., the second logical block of EMMC), which is also the storage place of Bootloader, and the backup GPT Header must be located in the last LBA of the device. Therefore,there is a conflict between GPT and Bootloader in the storage. The boot architecture on Poplar board can be described as follows: BootRom-->Bootloader-->ATF-->UEFI-->Kernel. The Bootloader can be viewed as the BL1 stage of the ATF image;So it's a basic essential either. In some date manual we can get that the EMMC device is composed of five parts:BOOT Area Partition 1,BOOT Area Partition 2,RPMB,User Data Area and Vender private area.Hikey did not flash its fastboot into User Data Area where Poplar flased. I have asked our BootRom engineers but got a negative result:BootRom only can recognize the Bootloader in the start address of User Data Area on Poplar board where GPT must be placed to. Therefor, how to solve the conflicts between GPT and Bootloader is really a thorny problem. I have asked several people for help,and got two methods as follows: #1.Use the backup GPT Header. In the GPT chapter of the UEFI Spec2.6 I read some useful information.Firstly,the backup GPT Partition Entry Array must be located after the Last Usable LBA and end before the backup GPT Header.Secondly,if the primary GPT is corrupt, software must check the last LBA of the device to see if it has a valid GPT Header and point to a valid GPT Partition Entry Array. If it points to a valid GPT Partition Entry Array, then software should restore the primary GPT if allowed by platform policy settings.If the primary GPT is invalid, the backup GPT is used instead and it is located on the last logical block on the disk. On the base of the above,I only flashed the backup GPT to the thirty-three block from the end. But the UEFI can't recognize the backup GPT.So I don't know if the place where I store the backup GPT is wrong? #2.Add an offset when read or write block . This method will reserve a 1M space for Bootloader at the start address of EMMC. And the primary GPT will be placed in a start address of 1M. We should add a 1M offset when we use the BlockIO functions to read or write block devices.This method maybe need to modify the EDKII core code;Honestly, I have not try this method. How to solve the conflicts between GPT and Bootloader is really a thorny problem for me.Can you give me some advises about this problem? Best regards, Wengang

7 years, 9 months

[PATCH 0/3] AMD/Styx: enable strict memory permissions

by Ard Biesheuvel

This cleans up some dodgy code in the SMBIOS driver, after which it is possible to enable the shiny new memory protection controls. Note that these patches are still under review, so patch #3 cannot be merged yet. Ard Biesheuvel (3): Platforms/AMD/Styx/PlatformSmbiosDxe: don't write to string literals Platforms/AMD/Styx: constify/staticize all local functions and variables Platforms/AMD/Styx: enable strict memory permission policy Platforms/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 87 ++++++++++++-------- Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc | 15 ++++ 2 files changed, 67 insertions(+), 35 deletions(-) -- 2.7.4

7 years, 9 months

[PATCH] Treewide: remove references to VirtualUncachedPages libraries and PCDs

by Ard Biesheuvel

Clean up any [commented out] references to the recently removed DebugUncachedMemoryAllocationLib, and to the related PCD PcdArmUncachedMemoryMask which will be removed as soon as all references are gone. While we're at it, remove some stale comments as well. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel(a)linaro.org> --- Chips/Hisilicon/Hisilicon.dsc.inc | 9 --------- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 5 ----- Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 10 ---------- Platforms/Hisilicon/D02/Pv660D02.dsc | 10 ---------- Platforms/Hisilicon/D03/D03.dsc | 12 ------------ Platforms/Hisilicon/D05/D05.dsc | 7 ------- Platforms/Hisilicon/HiKey/HiKey.dsc | 5 ----- Platforms/Marvell/Armada/Armada.dsc.inc | 1 - 8 files changed, 59 deletions(-) diff --git a/Chips/Hisilicon/Hisilicon.dsc.inc b/Chips/Hisilicon/Hisilicon.dsc.inc index 510ee1d2898e..4c6eea0ea428 100644 --- a/Chips/Hisilicon/Hisilicon.dsc.inc +++ b/Chips/Hisilicon/Hisilicon.dsc.inc @@ -340,15 +340,6 @@ gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiLoaderData|0 # - # ARM Pcds - # - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000000000000 - - # - # ARM PrimeCell - # - - # # ARM OS Loader # # Versatile Express machine type (ARM VERSATILE EXPRESS = 2272) required for ARM Linux: diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc index cf4b803096f1..56feed48495f 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc @@ -114,11 +114,6 @@ # Size of the region used by UEFI in permanent memory (Reserved 64MB) gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000 - # - # ARM Pcds - # - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 - ## Trustzone enable (to make the transition from EL3 to NS EL2 in ArmPlatformPkg/Sec) gArmTokenSpaceGuid.PcdTrustzoneSupport|TRUE diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index ddf617c850c8..c94001b3bcdb 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -25,7 +25,6 @@ !else DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf UncachedMemoryAllocationLib|ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.inf -# UncachedMemoryAllocationLib|ArmPkg/Library/DebugUncachedMemoryAllocationLib/DebugUncachedMemoryAllocationLib.inf !endif DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf @@ -394,15 +393,6 @@ gArmVExpressTokenSpaceGuid.PcdAndroidFastbootNvmDevicePath|L"VenHw(09831032-6FA3-4484-AF4F-0A000A8D3A82)" # - # ARM Pcds - # - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000000000000 - - # - # ARM PrimeCell - # - - # # FileSystem # diff --git a/Platforms/Hisilicon/D02/Pv660D02.dsc b/Platforms/Hisilicon/D02/Pv660D02.dsc index 2f5fbe53217a..b61157905829 100644 --- a/Platforms/Hisilicon/D02/Pv660D02.dsc +++ b/Platforms/Hisilicon/D02/Pv660D02.dsc @@ -126,16 +126,6 @@ # Size of the region used by UEFI in permanent memory (Reserved 64MB) gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x10000000 - # - # ARM Pcds - # - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 - - # - # ARM PrimeCell - # - - ## SP805 Watchdog - Motherboard Watchdog gArmPlatformTokenSpaceGuid.PcdSP805WatchdogBase|0x801e0000 diff --git a/Platforms/Hisilicon/D03/D03.dsc b/Platforms/Hisilicon/D03/D03.dsc index 4c903268c8b3..9c73494c7398 100644 --- a/Platforms/Hisilicon/D03/D03.dsc +++ b/Platforms/Hisilicon/D03/D03.dsc @@ -143,18 +143,6 @@ gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x10000000 gHisiTokenSpaceGuid.PcdSerDesFlowCtrlFlag|1 - - - # - # ARM Pcds - # - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 - - # - # ARM PrimeCell - # - - gHisiTokenSpaceGuid.PcdSlotPerChannelNum|0x2 diff --git a/Platforms/Hisilicon/D05/D05.dsc b/Platforms/Hisilicon/D05/D05.dsc index 5645b15b255c..2877da013bd5 100644 --- a/Platforms/Hisilicon/D05/D05.dsc +++ b/Platforms/Hisilicon/D05/D05.dsc @@ -155,13 +155,6 @@ gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x10000000 gHisiTokenSpaceGuid.PcdSerDesFlowCtrlFlag|1 - - - # - # ARM Pcds - # - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 - gHisiTokenSpaceGuid.PcdSlotPerChannelNum|0x2 diff --git a/Platforms/Hisilicon/HiKey/HiKey.dsc b/Platforms/Hisilicon/HiKey/HiKey.dsc index 492faaa02429..a9b29f2b0e9b 100644 --- a/Platforms/Hisilicon/HiKey/HiKey.dsc +++ b/Platforms/Hisilicon/HiKey/HiKey.dsc @@ -296,11 +296,6 @@ gArmTokenSpaceGuid.PcdVFPEnabled|1 # - # ARM Pcds - # - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000000000000 - - # # ARM PrimeCell # diff --git a/Platforms/Marvell/Armada/Armada.dsc.inc b/Platforms/Marvell/Armada/Armada.dsc.inc index aac6b7f66f78..da48ea6702e1 100644 --- a/Platforms/Marvell/Armada/Armada.dsc.inc +++ b/Platforms/Marvell/Armada/Armada.dsc.inc @@ -359,7 +359,6 @@ gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE # ARM Pcds - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000000000000 gArmTokenSpaceGuid.PcdSystemMemoryBase|0 gArmTokenSpaceGuid.PcdSystemMemorySize|0x40000000 gArmTokenSpaceGuid.PcdArmScr|0x531 -- 2.7.4

7 years, 9 months

Re: [Linaro-uefi] Problem with building AML file from Dsdt.asl for Juno

by Leif Lindholm

Oh dear... Adding linaro-toolchain(a)lists.linaro.org to see what they have to say (and linaro-uefi, because it's useful information for subscribers of that). Regards, Leif On Tue, Feb 21, 2017 at 08:09:53PM +0000, Evan Lloyd wrote: > To add to Alexei's comments: > It seems there is a bug in the newer GCC Pre-processor that messes with the file case. > (He is currently checking what file system flags might be affecting that, but older versions work fine). > > The questions I'd add are: > Is there someone in Linaro who we might discuss the problem with (on the GCC side)? I think there are Linaro guys involved with it, and they may be able to tell us it is confusion on our part. > Should we be trying to upstream the fix, or just wait for a new GCC? > > Regards, > Evan > > > > From: Alexei Fedorov > Sent: 21 February 2017 16:37 > To: ard.biesheuvel(a)linaro.org; ryan.harkin(a)linaro.org; leif.lindholm(a)linaro.org; Evan Lloyd; Sami Mujawar; Girish Pathak > Cc: Mitch Ishihara; Alexei Fedorov > Subject: Problem with building AML file from Dsdt.asl for Juno > > > Hello, > > > > We are facing a problem when compiling Juno's Dsdt.asl file with the following GCC builds: > > > > gcc-linaro-5.3.1-2016.05-i686-mingw32_aarch64-elf > > gcc-linaro-6.1.1-2016.08-i686-mingw32_aarch64-elf > > gcc-linaro-6.2.1-2016.11-i686-mingw32_aarch64-elf > > gcc-linaro-6.3.1-2017.02-i686-mingw32_aarch64-elf > > > > which all show a similar error: > > > > ... > Trim --source-code -l -o k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.iiii k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.iii > "C:\ASL\iasl" -pk:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.aml k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.iiii > Error 6126 - Input file does not appear to be an ASL or data table source file > Intel ACPI Component Architecture > make: *** [Makefile:325: k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\Dsdt.aml] Error -1 > > > > It looks like the problem is with GCC pre-processor running on Dsdt.i file (created after > > Trim --asl-file -o k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.i -i k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\inc.lst k:\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\Dsdt.asl > > ) > > > > See: > > > "C:\gcc-linaro-6.3.1-2017.02-i686-mingw32_aarch64-elf\bin\aarch64-elf-gcc" -x c -E -include AutoGen.h -Ik:\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables -Ik:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\DEBUG -Ik:\ArmPkg -Ik:\ArmPkg\Include -Ik:\ArmPlatformPkg -Ik:\ArmPlatformPkg\Include -Ik:\ArmPlatformPkg\ArmVExpressPkg -Ik:\ArmPlatformPkg\ArmVExpressPkg\Include -Ik:\ArmPlatformPkg\ArmJunoPkg -Ik:\ArmPlatformPkg\ArmJunoPkg\Include -Ik:\EmbeddedPkg -Ik:\EmbeddedPkg\Include -Ik:\MdePkg -Ik:\MdePkg\Include -Ik:\MdePkg\Include\AArch64 -Ik:\MdeModulePkg -Ik:\MdeModulePkg\Include -Ik:\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTablesk:\Build\ArmJuno\DEBUG_GCC5AARCH64OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.i > k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.iii > > > > For all GCC versions above, the 1st line of Dsdt.iii lists its name & full path in lowercase: > > # 1 "k:\\build\\armjuno\\debug_gcc5\\aarch64\\openplatformpkg\\platforms\\arm\\juno\\acpitables\\acpitables\\output\\dsdt.i" > > > > Compare it with Dsdt.iii after pre-processing by GCC from gcc-linaro-4.9.4-2017.01-i686-mingw32_aarch64-elf release: > > # 1 "k:\\Build\\ArmJuno\\DEBUG_GCC49\\AARCH64\\OpenPlatformPkg\\Platforms\\ARM\\Juno\\AcpiTables\\AcpiTables\\OUTPUT\\.\\Dsdt.i" > > > > For GCC 5.3.1 & above Dsdt.iiii created by > > Trim --source-code -l -o k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.iiii k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.iii > > > > has 0 length, which causes iASL compiler to fail with: > > Error 6126 - Input file does not appear to be an ASL or data table source file > > > > We've got a workaround solution for that problem which involves modification of \BaseTools\Conf\build_rule.template: > > > > In ASL section: > [Acpi-Source-Language-File] > <InputFile> > ?.asl, ?.Asl, ?.ASL > > > > by replacing 3 lines as below: > > > <Command.GCC, Command.GCCLD> > # Trim --asl-file -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.i -i $(INC_LIST) ${src} > # "$(ASLPP)" $(ASLPP_FLAGS) $(INC) -I${s_path} $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.i > $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iii > # Trim --source-code -l -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iiii $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iii > "$(ASLPP)" $(ASLPP_FLAGS) $(INC) -I${s_path} ${src} > $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.i > Trim --source-code -l -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iiii $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.I > > > > Please share your opinion on that matter. > > > > Alexei. > > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

7 years, 10 months

[PATCH v2 0/7] ATAPI support on SiI SATA adapter

by Jeremy Linton

The SiI isn't an AHCI compatible adapter so it implements the EFI ATA pass-through protocol directly. This works for fixed hard drives, but not ATAPI attached devices (CDROM, DVDROM, TAPE, etc). This patch adds read only ATAPI support via the EFI SCSI pass-through protocol, allowing boot from attached CD/DVD. This patch also cleans up, and tweaks recovery paths/etc in the original driver. When combined with the ARM/PCI dma lib changes this allows us to relax the IO alignment requirement that caused grub failures. Finally, the OpenPlatformPkg/Juno must be updated, with another patch to avoid build breaks now that the SiI has a dependency on the SCSI libraries. V1->V2: Formatting corrections per Ard's comments and Daniil's updated patch checker. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton <jeremy.linton(a)arm.com> Jeremy Linton (7): EmbeddedPkg: SiI3132: Note that ARM is using this Dxe MdePkg IndustryStandard/Scsi.h: Add sense code macro EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks EmbeddedPkg: SiI3132: Add SCSI protocol support to header EmbeddedPkg: SiI3132: Break out FIS command submission EmbeddedPkg: SiI3132: Cleanup device node creation EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 49 ++- EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 93 ++++- .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf | 2 + .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 268 ++++++++----- .../Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c | 431 +++++++++++++++++++++ MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +- MdePkg/Include/IndustryStandard/Scsi.h | 2 + OpenPlatformPkg | 2 +- 8 files changed, 721 insertions(+), 128 deletions(-) create mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c -- 2.9.3

7 years, 10 months

Stack Alignment is not enabled in ARM EDK2

by Heyi Guo

Hi folks, It seems there is no code to enable stack alignment check in EDK2, while it is required to be enabled according to UEFI spec v2.6, section 2.3.6, page 38. Shall we find somewhere to enable SA? Thanks and regards, Gary (Heyi Guo)

7 years, 10 months

← Newer
1
...
21
22
23
24
25
26
27
...
82
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-uefi