- Linux-kselftest-mirror - lists.linaro.org

[PATCH v1] kunit: tools: fix kunit_tool tests for parsing test plans

by Brendan Higgins

Some tests logs for kunit_tool tests are missing their test plans causing their tests to fail; fix this by adding the test plans. Fixes: 45dcbb6f5ef7 ("kunit: test: add test plan to KUnit TAP format") Signed-off-by: Brendan Higgins <brendanhiggins(a)google.com> --- tools/testing/kunit/kunit_tool_test.py | 32 ++++++++++++++---- .../test_data/test_config_printk_time.log | Bin 1584 -> 1605 bytes .../test_data/test_interrupted_tap_output.log | Bin 1982 -> 2003 bytes .../test_data/test_kernel_panic_interrupt.log | Bin 1321 -> 1342 bytes .../test_data/test_multiple_prefixes.log | Bin 1832 -> 1861 bytes .../kunit/test_data/test_pound_no_prefix.log | Bin 1193 -> 1200 bytes .../kunit/test_data/test_pound_sign.log | Bin 1656 -> 1676 bytes 7 files changed, 25 insertions(+), 7 deletions(-) diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py index 99c3c5671ea48..0b60855fb8198 100755 --- a/tools/testing/kunit/kunit_tool_test.py +++ b/tools/testing/kunit/kunit_tool_test.py @@ -179,7 +179,7 @@ class KUnitParserTest(unittest.TestCase): print_mock = mock.patch('builtins.print').start() result = kunit_parser.parse_run_tests( kunit_parser.isolate_kunit_output(file.readlines())) - print_mock.assert_any_call(StrContains("no kunit output detected")) + print_mock.assert_any_call(StrContains('no tests run!')) print_mock.stop() file.close() @@ -198,39 +198,57 @@ class KUnitParserTest(unittest.TestCase): 'test_data/test_config_printk_time.log') with open(prefix_log) as file: result = kunit_parser.parse_run_tests(file.readlines()) - self.assertEqual('kunit-resource-test', result.suites[0].name) + self.assertEqual( + kunit_parser.TestStatus.SUCCESS, + result.status) + self.assertEqual('kunit-resource-test', result.suites[0].name) def test_ignores_multiple_prefixes(self): prefix_log = get_absolute_path( 'test_data/test_multiple_prefixes.log') with open(prefix_log) as file: result = kunit_parser.parse_run_tests(file.readlines()) - self.assertEqual('kunit-resource-test', result.suites[0].name) + self.assertEqual( + kunit_parser.TestStatus.SUCCESS, + result.status) + self.assertEqual('kunit-resource-test', result.suites[0].name) def test_prefix_mixed_kernel_output(self): mixed_prefix_log = get_absolute_path( 'test_data/test_interrupted_tap_output.log') with open(mixed_prefix_log) as file: result = kunit_parser.parse_run_tests(file.readlines()) - self.assertEqual('kunit-resource-test', result.suites[0].name) + self.assertEqual( + kunit_parser.TestStatus.SUCCESS, + result.status) + self.assertEqual('kunit-resource-test', result.suites[0].name) def test_prefix_poundsign(self): pound_log = get_absolute_path('test_data/test_pound_sign.log') with open(pound_log) as file: result = kunit_parser.parse_run_tests(file.readlines()) - self.assertEqual('kunit-resource-test', result.suites[0].name) + self.assertEqual( + kunit_parser.TestStatus.SUCCESS, + result.status) + self.assertEqual('kunit-resource-test', result.suites[0].name) def test_kernel_panic_end(self): panic_log = get_absolute_path('test_data/test_kernel_panic_interrupt.log') with open(panic_log) as file: result = kunit_parser.parse_run_tests(file.readlines()) - self.assertEqual('kunit-resource-test', result.suites[0].name) + self.assertEqual( + kunit_parser.TestStatus.TEST_CRASHED, + result.status) + self.assertEqual('kunit-resource-test', result.suites[0].name) def test_pound_no_prefix(self): pound_log = get_absolute_path('test_data/test_pound_no_prefix.log') with open(pound_log) as file: result = kunit_parser.parse_run_tests(file.readlines()) - self.assertEqual('kunit-resource-test', result.suites[0].name) + self.assertEqual( + kunit_parser.TestStatus.SUCCESS, + result.status) + self.assertEqual('kunit-resource-test', result.suites[0].name) class KUnitJsonTest(unittest.TestCase): diff --git a/tools/testing/kunit/test_data/test_config_printk_time.log b/tools/testing/kunit/test_data/test_config_printk_time.log index c02ca773946d641291e27d44d73174cc16a17d9d..6bdb57f76eacef0396e68942cb3fa983b6992bab 100644 GIT binary patch delta 25 hcmdnMbChSob{0cDJ>$uC%rcYXnAkR+OlM`}0sw1)2Xg=b delta 10 RcmX@gvw>&A_Kl}2Spgdh1kV5f diff --git a/tools/testing/kunit/test_data/test_interrupted_tap_output.log b/tools/testing/kunit/test_data/test_interrupted_tap_output.log index 5c73fb3a1c6fd13a9b163a48d02eb33b0315a375..1fb677728abeb0fe6aa5edb3a0387c05906b9815 100644 GIT binary patch delta 21 dcmdnTf0=*6b{0cDJ>$t2n3Xo3{L0421prz=2g3jW delta 17 Zcmcc2zmI>y_Q@YucqXy1ZM^%H4FE=v2d@AC diff --git a/tools/testing/kunit/test_data/test_kernel_panic_interrupt.log b/tools/testing/kunit/test_data/test_kernel_panic_interrupt.log index c045eee75f27fefaabf3ba073d9e282721c19a67..a014ffe9725e3c4e81697f742cee2652a41b2108 100644 GIT binary patch delta 25 hcmZ3<wU2AUb{0cDJ>$uC%rcYXnAkR+OkiQ;0sv{Y2U!3B delta 10 RcmdnTwUTSX_Kl~DSO6Mc1hoJF diff --git a/tools/testing/kunit/test_data/test_multiple_prefixes.log b/tools/testing/kunit/test_data/test_multiple_prefixes.log index bc48407dcc36c44665c7d2ac620e42e7caf98481..0ad78481a0b450bf463ca7aaab0ae739d4e43018 100644 GIT binary patch delta 16 YcmZ3%ca(3!^~t;}vKwy%urYE005`P-oB#j- delta 15 XcmX@gw}NlN^~vX$gf_D>+Oq)wG*bm+ diff --git a/tools/testing/kunit/test_data/test_pound_no_prefix.log b/tools/testing/kunit/test_data/test_pound_no_prefix.log index 2ceb360be7d52cbee4b0a5a426456605ded7466e..dc4cf09a96d077bbc0b5fbcb312251742e390379 100644 GIT binary patch delta 17 YcmZ3<xq)*+J&U29p7F+79Tr9|05Q}Ar~m)} delta 10 RcmdnMxsr22{l-=;762DW1K$7u diff --git a/tools/testing/kunit/test_data/test_pound_sign.log b/tools/testing/kunit/test_data/test_pound_sign.log index 28ffa5ba03bfa81ea02ea9d38e7de7acf3dd9e5d..3f358e3a7ba0d118c1dc15e5f637fb8ffb5aa388 100644 GIT binary patch delta 19 bcmeyt)5AMqJBy*7p7G>PCZ&xh*RuiuM}Y?y delta 14 WcmeC-{lPO~`{cDuLL2X{X9WN;2?l!r base-commit: 7cf726a59435301046250c42131554d9ccc566b8 -- 2.29.0.rc1.297.gfa9743e501-goog

5 years

2
1
0 0

[PATCH] Documentation: kunit: Update Kconfig parts for KUNIT's module support

by SeongJae Park

From: SeongJae Park <sjpark(a)amazon.de> If 'CONFIG_KUNIT=m', letting kunit tests that do not support loadable module build depends on 'KUNIT' instead of 'KUNIT=y' result in compile errors. This commit updates the document for this. Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module") Signed-off-by: SeongJae Park <sjpark(a)amazon.de> Reviewed-by: David Gow <davidgow(a)google.com> --- Changes from v2 (https://lore.kernel.org/linux-kselftest/20201013063743.32179-1-sjpark@amazo…) - Fix a grammar issue (David Gow) - Add 'Reviewed-by: David Gow <davidgow(a)google.com>' Changes from v1 (https://lore.kernel.org/linux-kselftest/20201012105420.5945-1-sjpark@amazon…) - Fix a typo (Marco Elver) --- Documentation/dev-tools/kunit/start.rst | 2 +- Documentation/dev-tools/kunit/usage.rst | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Documentation/dev-tools/kunit/start.rst b/Documentation/dev-tools/kunit/start.rst index d23385e3e159..454f307813ea 100644 --- a/Documentation/dev-tools/kunit/start.rst +++ b/Documentation/dev-tools/kunit/start.rst @@ -197,7 +197,7 @@ Now add the following to ``drivers/misc/Kconfig``: config MISC_EXAMPLE_TEST bool "Test for my example" - depends on MISC_EXAMPLE && KUNIT + depends on MISC_EXAMPLE && KUNIT=y and the following to ``drivers/misc/Makefile``: diff --git a/Documentation/dev-tools/kunit/usage.rst b/Documentation/dev-tools/kunit/usage.rst index 961d3ea3ca19..62142a47488c 100644 --- a/Documentation/dev-tools/kunit/usage.rst +++ b/Documentation/dev-tools/kunit/usage.rst @@ -561,6 +561,11 @@ Once the kernel is built and installed, a simple ...will run the tests. +.. note:: + Note that you should make sure your test depends on ``KUNIT=y`` in Kconfig + if the test does not support module build. Otherwise, it will trigger + compile errors if ``CONFIG_KUNIT`` is ``m``. + Writing new tests for other architectures ----------------------------------------- -- 2.17.1

5 years

2
1
0 0

[PATCH v2] Documentation: kunit: Update Kconfig parts for KUNIT's module support

by SeongJae Park

From: SeongJae Park <sjpark(a)amazon.de> If 'CONFIG_KUNIT=m', letting kunit tests that do not support loadable module build depends on 'KUNIT' instead of 'KUNIT=y' result in compile errors. This commit updates the document for this. Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module") Signed-off-by: SeongJae Park <sjpark(a)amazon.de> --- Changes from v1 (https://lore.kernel.org/linux-kselftest/20201012105420.5945-1-sjpark@amazon…): - Fix a typo (Marco Elver) --- Documentation/dev-tools/kunit/start.rst | 2 +- Documentation/dev-tools/kunit/usage.rst | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Documentation/dev-tools/kunit/start.rst b/Documentation/dev-tools/kunit/start.rst index d23385e3e159..454f307813ea 100644 --- a/Documentation/dev-tools/kunit/start.rst +++ b/Documentation/dev-tools/kunit/start.rst @@ -197,7 +197,7 @@ Now add the following to ``drivers/misc/Kconfig``: config MISC_EXAMPLE_TEST bool "Test for my example" - depends on MISC_EXAMPLE && KUNIT + depends on MISC_EXAMPLE && KUNIT=y and the following to ``drivers/misc/Makefile``: diff --git a/Documentation/dev-tools/kunit/usage.rst b/Documentation/dev-tools/kunit/usage.rst index 3c3fe8b5fecc..b331f5a5b0b9 100644 --- a/Documentation/dev-tools/kunit/usage.rst +++ b/Documentation/dev-tools/kunit/usage.rst @@ -556,6 +556,11 @@ Once the kernel is built and installed, a simple ...will run the tests. +.. note:: + Note that you should make your test depends on ``KUNIT=y`` in Kconfig if the + test does not support module build. Otherwise, it will trigger compile + errors if ``CONFIG_KUNIT`` is ``m``. + Writing new tests for other architectures ----------------------------------------- -- 2.17.1

5 years

2
3
0 0

[RFC,net-next, 0/4] seg6: add support for SRv6 End.DT4 behavior

by Andrea Mayer

This patchset adds support for the SRv6 End.DT4 behavior. The SRv6 End.DT4 is used to implement multi-tenant IPv4 L3VPN. It decapsulates the received packets and performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux implementation leverages a VRF device. SRv6 End.DT4 is defined in the SRv6 Network Programming [1]. - Patch 1/4 is needed to solve a pre-existing issue with tunneled packets when a sniffer is attached; - Patch 2/4 introduces two callbacks used for customizing the creation/destruction of a SRv6 behavior; - Patch 3/4 is the core patch that adds support for the SRv6 End.DT4 behavior; - Patch 4/4 adds the selftest for SRv6 End.DT4. I would like to thank David Ahern for his support during the development of this patch set. Comments, suggestions and improvements are very welcome! Thanks, Andrea Mayer [1] https://tools.ietf.org/html/draft-ietf-spring-srv6-network-programming Andrea Mayer (4): vrf: push mac header for tunneled packets when sniffer is attached seg6: add callbacks for customizing the creation/destruction of a behavior seg6: add support for the SRv6 End.DT4 behavior add selftest for the SRv6 End.DT4 behavior drivers/net/vrf.c | 78 ++- net/ipv6/seg6_local.c | 261 ++++++++++ .../selftests/net/srv6_end_dt4_l3vpn_test.sh | 490 ++++++++++++++++++ 3 files changed, 823 insertions(+), 6 deletions(-) create mode 100755 tools/testing/selftests/net/srv6_end_dt4_l3vpn_test.sh -- 2.20.1

5 years

1
4
0 0

[PATCH v2] fat: Add KUnit tests for checksums and timestamps

by David Gow

Add some basic sanity-check tests for the fat_checksum() function and the fat_time_unix2fat() and fat_time_fat2unix() functions. These unit tests verify these functions return correct output for a number of test inputs. These tests were inspored by -- and serve a similar purpose to -- the timestamp parsing KUnit tests in ext4[1]. Note that, unlike fat_time_unix2fat, fat_time_fat2unix wasn't previously exported, so this patch exports it as well. This is required for the case where we're building the fat and fat_test as modules. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/… Signed-off-by: David Gow <davidgow(a)google.com> Acked-by: OGAWA Hirofumi <hirofumi(a)mail.parknet.co.jp> --- Changes since v1: https://lore.kernel.org/linux-kselftest/20201017064107.375174-1-davidgow@go… - Now export fat_time_fat2unix() so that the test can access it when built as a module. fs/fat/Kconfig | 13 +++ fs/fat/Makefile | 2 + fs/fat/fat_test.c | 197 ++++++++++++++++++++++++++++++++++++++++++++++ fs/fat/misc.c | 1 + 4 files changed, 213 insertions(+) create mode 100644 fs/fat/fat_test.c diff --git a/fs/fat/Kconfig b/fs/fat/Kconfig index 66532a71e8fd..fdef03b79c69 100644 --- a/fs/fat/Kconfig +++ b/fs/fat/Kconfig @@ -115,3 +115,16 @@ config FAT_DEFAULT_UTF8 Say Y if you use UTF-8 encoding for file names, N otherwise. See <file:Documentation/filesystems/vfat.rst> for more information. + +config FAT_KUNIT_TEST + tristate "Unit Tests for FAT filesystems" if !KUNIT_ALL_TESTS + select FAT_FS + depends on KUNIT + default KUNIT_ALL_TESTS + help + This builds the FAT KUnit tests + + For more information on KUnit and unit tests in general, please refer + to the KUnit documentation in Documentation/dev-tools/kunit + + If unsure, say N diff --git a/fs/fat/Makefile b/fs/fat/Makefile index 70645ce2f7fc..2b034112690d 100644 --- a/fs/fat/Makefile +++ b/fs/fat/Makefile @@ -10,3 +10,5 @@ obj-$(CONFIG_MSDOS_FS) += msdos.o fat-y := cache.o dir.o fatent.o file.o inode.o misc.o nfs.o vfat-y := namei_vfat.o msdos-y := namei_msdos.o + +obj-$(CONFIG_FAT_KUNIT_TEST) += fat_test.o diff --git a/fs/fat/fat_test.c b/fs/fat/fat_test.c new file mode 100644 index 000000000000..c1b4348b9b3b --- /dev/null +++ b/fs/fat/fat_test.c @@ -0,0 +1,197 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * KUnit tests for FAT filesystems. + * + * Copyright (C) 2020 Google LLC. + * Author: David Gow <davidgow(a)google.com> + */ + +#include <kunit/test.h> + +#include "fat.h" + +static void fat_checksum_test(struct kunit *test) +{ + /* With no extension. */ + KUNIT_EXPECT_EQ(test, fat_checksum("VMLINUX "), 44); + /* With 3-letter extension. */ + KUNIT_EXPECT_EQ(test, fat_checksum("README TXT"), 115); + /* With short (1-letter) extension. */ + KUNIT_EXPECT_EQ(test, fat_checksum("ABCDEFGHA "), 98); +} + + +struct fat_timestamp_testcase { + const char *name; + struct timespec64 ts; + __le16 time; + __le16 date; + u8 cs; + int time_offset; +}; + +const static struct fat_timestamp_testcase time_test_cases[] = { + { + .name = "Earliest possible UTC (1980-01-01 00:00:00)", + .ts = {.tv_sec = 315532800LL, .tv_nsec = 0L}, + .time = 0, + .date = 33, + .cs = 0, + .time_offset = 0, + }, + { + .name = "Latest possible UTC (2107-12-31 23:59:58)", + .ts = {.tv_sec = 4354819198LL, .tv_nsec = 0L}, + .time = 49021, + .date = 65439, + .cs = 0, + .time_offset = 0, + }, + { + .name = "Earliest possible (UTC-11) (== 1979-12-31 13:00:00 UTC)", + .ts = {.tv_sec = 315493200LL, .tv_nsec = 0L}, + .time = 0, + .date = 33, + .cs = 0, + .time_offset = 11 * 60, + }, + { + .name = "Latest possible (UTC+11) (== 2108-01-01 10:59:58 UTC)", + .ts = {.tv_sec = 4354858798LL, .tv_nsec = 0L}, + .time = 49021, + .date = 65439, + .cs = 0, + .time_offset = -11 * 60, + }, + { + .name = "Leap Day / Year (1996-02-29 00:00:00)", + .ts = {.tv_sec = 825552000LL, .tv_nsec = 0L}, + .time = 0, + .date = 8285, + .cs = 0, + .time_offset = 0, + }, + { + .name = "Year 2000 is leap year (2000-02-29 00:00:00)", + .ts = {.tv_sec = 951782400LL, .tv_nsec = 0L}, + .time = 0, + .date = 10333, + .cs = 0, + .time_offset = 0, + }, + { + .name = "Year 2100 not leap year (2100-03-01 00:00:00)", + .ts = {.tv_sec = 4107542400LL, .tv_nsec = 0L}, + .time = 0, + .date = 61537, + .cs = 0, + .time_offset = 0, + }, + { + .name = "Leap year + timezone UTC+1 (== 2004-02-29 00:30:00 UTC)", + .ts = {.tv_sec = 1078014600LL, .tv_nsec = 0L}, + .time = 48064, + .date = 12380, + .cs = 0, + .time_offset = -60, + }, + { + .name = "Leap year + timezone UTC-1 (== 2004-02-29 23:30:00 UTC)", + .ts = {.tv_sec = 1078097400LL, .tv_nsec = 0L}, + .time = 960, + .date = 12385, + .cs = 0, + .time_offset = 60, + }, + { + .name = "VFAT odd-second resolution (1999-12-31 23:59:59)", + .ts = {.tv_sec = 946684799LL, .tv_nsec = 0L}, + .time = 49021, + .date = 10143, + .cs = 100, + .time_offset = 0, + }, + { + .name = "VFAT 10ms resolution (1980-01-01 00:00:00:0010)", + .ts = {.tv_sec = 315532800LL, .tv_nsec = 10000000L}, + .time = 0, + .date = 33, + .cs = 1, + .time_offset = 0, + }, +}; + +static void fat_time_fat2unix_test(struct kunit *test) +{ + struct msdos_sb_info fake_sb; + int i; + struct timespec64 ts; + + for (i = 0; i < ARRAY_SIZE(time_test_cases); ++i) { + fake_sb.options.tz_set = 1; + fake_sb.options.time_offset = time_test_cases[i].time_offset; + + fat_time_fat2unix(&fake_sb, &ts, + time_test_cases[i].time, + time_test_cases[i].date, + time_test_cases[i].cs); + KUNIT_EXPECT_EQ_MSG(test, + time_test_cases[i].ts.tv_sec, + ts.tv_sec, + "Timestamp mismatch (seconds) in case \"%s\"\n", + time_test_cases[i].name); + KUNIT_EXPECT_EQ_MSG(test, + time_test_cases[i].ts.tv_nsec, + ts.tv_nsec, + "Timestamp mismatch (nanoseconds) in case \"%s\"\n", + time_test_cases[i].name); + } +} + +static void fat_time_unix2fat_test(struct kunit *test) +{ + struct msdos_sb_info fake_sb; + int i; + __le16 date, time; + u8 cs; + + for (i = 0; i < ARRAY_SIZE(time_test_cases); ++i) { + fake_sb.options.tz_set = 1; + fake_sb.options.time_offset = time_test_cases[i].time_offset; + + fat_time_unix2fat(&fake_sb, &time_test_cases[i].ts, + &time, &date, &cs); + KUNIT_EXPECT_EQ_MSG(test, + time_test_cases[i].time, + time, + "Time mismatch in case \"%s\"\n", + time_test_cases[i].name); + KUNIT_EXPECT_EQ_MSG(test, + time_test_cases[i].date, + date, + "Date mismatch in case \"%s\"\n", + time_test_cases[i].name); + KUNIT_EXPECT_EQ_MSG(test, + time_test_cases[i].cs, + cs, + "Centisecond mismatch in case \"%s\"\n", + time_test_cases[i].name); + } +} + +static struct kunit_case fat_test_cases[] = { + KUNIT_CASE(fat_checksum_test), + KUNIT_CASE(fat_time_fat2unix_test), + KUNIT_CASE(fat_time_unix2fat_test), + {}, +}; + +static struct kunit_suite fat_test_suite = { + .name = "fat_test", + .test_cases = fat_test_cases, +}; + +kunit_test_suites(&fat_test_suite); + +MODULE_LICENSE("GPL v2"); + diff --git a/fs/fat/misc.c b/fs/fat/misc.c index f1b2a1fc2a6a..445ad3542e74 100644 --- a/fs/fat/misc.c +++ b/fs/fat/misc.c @@ -229,6 +229,7 @@ void fat_time_fat2unix(struct msdos_sb_info *sbi, struct timespec64 *ts, ts->tv_nsec = 0; } } +EXPORT_SYMBOL_GPL(fat_time_fat2unix); /* Convert linear UNIX date to a FAT time/date pair. */ void fat_time_unix2fat(struct msdos_sb_info *sbi, struct timespec64 *ts, -- 2.29.0.rc1.297.gfa9743e501-goog

5 years

2
3
0 0

[PATCH v1] kunit: Don't fail test suites if one of them is empty

by Andy Shevchenko

Empty test suite is okay test suite. Don't fail the rest of the test suites if one of them is empty. Fixes: 6ebf5866f2e8 ("kunit: tool: add Python wrappers for running KUnit tests") Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- tools/testing/kunit/kunit_parser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/kunit/kunit_parser.py b/tools/testing/kunit/kunit_parser.py index 8019e3dd4c32..12b9fc652ef6 100644 --- a/tools/testing/kunit/kunit_parser.py +++ b/tools/testing/kunit/kunit_parser.py @@ -242,7 +242,7 @@ def parse_test_suite(lines: List[str], expected_suite_index: int) -> TestSuite: return None test_suite.name = name expected_test_case_num = parse_subtest_plan(lines) - if not expected_test_case_num: + if expected_test_case_num is None: return None while expected_test_case_num > 0: test_case = parse_test_case(lines) -- 2.28.0

5 years

2
1
0 0

BUG: unable to handle page fault for address - PF: supervisor read access in kernel mode

by Naresh Kamboju

while running selftests net icmp_redirect.sh the following crash noticed on x86_64 on linux-next master. BUG: unable to handle page fault for address: ffff9c00302d7872 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 2c401067 P4D 2c401067 PUD 0 Oops: 0000 [#1] SMP PTI CPU: 1 PID: 887 Comm: ip Tainted: G W K 5.9.0-next-20201016 #1 Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 RIP: 0010:__kmalloc_track_caller+0x100/0x340 Reported-by: Naresh Kamboju <naresh.kamboju(a)linaro.org> metadata: git branch: master git repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git commit: b2926c108f9fd225d3fe9ea73fb5c35f48735d20 git describe: next-20201016 make_kernelversion: 5.9.0 kernel-config: http://snapshots.linaro.org/openembedded/lkft/lkft/sumo/intel-corei7-64/lkf… steps to reproduce: ---------------------------- # cd /opt/kselftests/default-in-kernel/ # ./run_kselftest.sh -t net:icmp_redirect.sh crash log: ---------- # selftests: net: icmp_redirect.sh <trim> [ 1062.257877] eth0: renamed from r1h1 [ 1062.311218] eth0: renamed from r2h1 [ 1062.321114] device eth1 left promiscuous mode [ 1062.325655] br0: port 2(eth1) entered disabled state [ 1062.325671] audit: type=1700 audit(1602906729.931:89088): dev=eth1 prom=0 old_prom=256 auid=4294967295 uid=0 gid=0 ses=4294967295 [ 1062.353160] device eth0 left promiscuous mode [ 1062.357640] br0: port 1(eth0) entered disabled state [ 1062.357707] audit: type=1700 audit(1602906729.963:89089): dev=eth0 prom=0 old_prom=256 auid=4294967295 uid=0 gid=0 ses=4294967295 [ 1062.506822] eth2: renamed from r2h2 [ 1062.516999] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready [ 1062.529632] BUG: unable to handle page fault for address: ffff9c00302d7872 [ 1062.536516] #PF: supervisor read access in kernel mode [ 1062.541655] #PF: error_code(0x0000) - not-present page [ 1062.546786] PGD 2c401067 P4D 2c401067 PUD 0 [ 1062.551058] Oops: 0000 [#1] SMP PTI [ 1062.554544] CPU: 1 PID: 887 Comm: ip Tainted: G W K 5.9.0-next-20201016 #1 [ 1062.562540] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 1062.570013] RIP: 0010:__kmalloc_track_caller+0x100/0x340 [ 1062.575325] Code: 4d 8b 04 24 65 49 8b 50 08 65 4c 03 05 01 70 20 4a 49 8b 00 48 85 c0 48 89 45 c8 0f 84 ba 01 00 00 41 8b 4c 24 28 49 8b 3c 24 <48> 8b 1c 08 48 8d 4a 01 65 48 0f c7 0f 0f 94 c0 84 c0 74 c2 41 8b [ 1062.594070] RSP: 0018:ffffb83c009f3ce8 EFLAGS: 00010286 [ 1062.599296] RAX: ffff9c00302d7872 RBX: 0000000000000cc0 RCX: 0000000000000000 [ 1062.606420] RDX: 000000000031bfb3 RSI: 0000000000000cc0 RDI: 000000000002f2d0 [ 1062.613544] RBP: ffffb83c009f3d28 R08: ffff9c541fcaf2d0 R09: 0000000000000000 [ 1062.620666] R10: ffffb83c009f3b98 R11: 0000000000000246 R12: ffff9c50c0042e00 [ 1062.627791] R13: 0000000000000cc0 R14: 0000000000000005 R15: ffffffffb5da0814 [ 1062.634917] FS: 00007f74b53d9440(0000) GS:ffff9c541fc80000(0000) knlGS:0000000000000000 [ 1062.642999] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1062.648738] CR2: ffff9c00302d7872 CR3: 0000000105d3e002 CR4: 00000000003706e0 [ 1062.655861] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1062.662984] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 1062.670109] Call Trace: [ 1062.672558] kstrdup+0x31/0x60 [ 1062.675616] kstrdup_const+0x24/0x30 [ 1062.679193] alloc_vfsmnt+0x64/0x1a0 [ 1062.682774] clone_mnt+0x36/0x2f0 [ 1062.686092] copy_tree+0x12e/0x390 [ 1062.689498] copy_mnt_ns+0xb5/0x380 [ 1062.692983] create_new_namespaces+0x61/0x2c0 [ 1062.697340] unshare_nsproxy_namespaces+0x5a/0xb0 [ 1062.702040] ksys_unshare+0x1e5/0x370 [ 1062.705704] __x64_sys_unshare+0x12/0x20 [ 1062.709631] do_syscall_64+0x37/0x50 [ 1062.713208] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 1062.718256] RIP: 0033:0x7f74b46d4d27 [ 1062.721831] Code: 73 01 c3 48 8b 0d 71 a1 2b 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 10 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 41 a1 2b 00 f7 d8 64 89 01 48 [ 1062.740569] RSP: 002b:00007fff74b0dbb8 EFLAGS: 00000206 ORIG_RAX: 0000000000000110 [ 1062.748135] RAX: ffffffffffffffda RBX: 0000000000000005 RCX: 00007f74b46d4d27 [ 1062.755257] RDX: 0000000000080000 RSI: 0000000040000000 RDI: 0000000000020000 [ 1062.762380] RBP: 00007fff74b11c45 R08: 0000000000000002 R09: 0000000000000000 [ 1062.769504] R10: 0000000000000358 R11: 0000000000000206 R12: 00007fff74b10ec8 [ 1062.776628] R13: 0000000000470deb R14: 00007fff74b11c3b R15: 00007fff74b10ed0 [ 1062.783757] Modules linked in: ip6table_mangle mpls_iptunnel mpls_router sch_etf ip6table_filter xt_conntrack nf_conntrack nf_defrag_ipv4 libcrc32c ip6_tables nf_defrag_ipv6 iptable_filter ip_tables netdevsim vrf 8021q bridge stp llc sch_fq sch_ingress veth algif_hash x86_pkg_temp_thermal fuse [last unloaded: test_blackhole_dev] [ 1062.812840] CR2: ffff9c00302d7872 [ 1062.816158] ---[ end trace 47c4f9ef0796b428 ]--- [ 1062.820769] RIP: 0010:__kmalloc_track_caller+0x100/0x340 [ 1062.826081] Code: 4d 8b 04 24 65 49 8b 50 08 65 4c 03 05 01 70 20 4a 49 8b 00 48 85 c0 48 89 45 c8 0f 84 ba 01 00 00 41 8b 4c 24 28 49 8b 3c 24 <48> 8b 1c 08 48 8d 4a 01 65 48 0f c7 0f 0f 94 c0 84 c0 74 c2 41 8b [ 1062.844817] RSP: 0018:ffffb83c009f3ce8 EFLAGS: 00010286 [ 1062.850033] RAX: ffff9c00302d7872 RBX: 0000000000000cc0 RCX: 0000000000000000 [ 1062.857158] RDX: 000000000031bfb3 RSI: 0000000000000cc0 RDI: 000000000002f2d0 [ 1062.864284] RBP: ffffb83c009f3d28 R08: ffff9c541fcaf2d0 R09: 0000000000000000 [ 1062.871415] R10: ffffb83c009f3b98 R11: 0000000000000246 R12: ffff9c50c0042e00 [ 1062.878540] R13: 0000000000000cc0 R14: 0000000000000005 R15: ffffffffb5da0814 [ 1062.885662] FS: 00007f74b53d9440(0000) GS:ffff9c541fc80000(0000) knlGS:0000000000000000 [ 1062.893740] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1062.899475] CR2: ffff9c00302d7872 CR3: 0000000105d3e002 CR4: 00000000003706e0 [ 1062.906600] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1062.913726] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 1062.920850] BUG: sleeping function called from invalid context at /usr/src/kernel/include/linux/percpu-rwsem.h:49 [ 1062.931101] in_atomic(): 0, irqs_disabled(): 1, non_block: 0, pid: 887, name: ip [ 1062.938485] INFO: lockdep is turned off. [ 1062.942403] irq event stamp: 2686 [ 1062.945715] hardirqs last enabled at (2685): [<ffffffffb6aef301>] _raw_spin_unlock_irqrestore+0x31/0x40 [ 1062.955186] hardirqs last disabled at (2686): [<ffffffffb6adfb31>] irqentry_enter+0x21/0x50 [ 1062.963522] softirqs last enabled at (1978): [<ffffffffb6755555>] release_sock+0x85/0xb0 [ 1062.971686] softirqs last disabled at (1976): [<ffffffffb67554ee>] release_sock+0x1e/0xb0 [ 1062.979850] CPU: 1 PID: 887 Comm: ip Tainted: G D W K 5.9.0-next-20201016 #1 [ 1062.987841] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 1062.995310] Call Trace: [ 1062.997756] dump_stack+0x7d/0x9f [ 1063.001066] ___might_sleep+0x163/0x250 [ 1063.004897] __might_sleep+0x4a/0x80 [ 1063.008469] exit_signals+0x33/0x2f0 [ 1063.012047] do_exit+0xa9/0xcb0 [ 1063.015185] rewind_stack_do_exit+0x17/0x20 [ 1063.019369] RIP: 0033:0x7f74b46d4d27 [ 1063.022941] Code: 73 01 c3 48 8b 0d 71 a1 2b 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 10 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 41 a1 2b 00 f7 d8 64 89 01 48 [ 1063.041677] RSP: 002b:00007fff74b0dbb8 EFLAGS: 00000206 ORIG_RAX: 0000000000000110 [ 1063.049233] RAX: ffffffffffffffda RBX: 0000000000000005 RCX: 00007f74b46d4d27 [ 1063.056359] RDX: 0000000000080000 RSI: 0000000040000000 RDI: 0000000000020000 [ 1063.063483] RBP: 00007fff74b11c45 R08: 0000000000000002 R09: 0000000000000000 [ 1063.070614] R10: 0000000000000358 R11: 0000000000000206 R12: 00007fff74b10ec8 [ 1063.077739] R13: 0000000000470deb R14: 00007fff74b11c3b R15: 00007fff74b10ed0 # ./icmp_redirect.sh: line 165: 887 Killed ip -netns r1 li add eth1 type veth peer name r2r1 [ 1067.354852] BUG: unable to handle page fault for address: ffff9c00302d7872 [ 1067.361741] #PF: supervisor read access in kernel mode [ 1067.361742] #PF: error_code(0x0000) - not-present page [ 1067.361743] PGD 2c401067 P4D 2c401067 PUD 0 [ 1067.361746] Oops: 0000 [#2] SMP PTI [ 1067.361747] CPU: 1 PID: 332 Comm: systemd-journal Tainted: G D W K 5.9.0-next-20201016 #1 [ 1067.361748] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 1067.361751] RIP: 0010:__kmalloc_track_caller+0x100/0x340 [ 1067.361753] Code: 4d 8b 04 24 65 49 8b 50 08 65 4c 03 05 01 70 20 4a 49 8b 00 48 85 c0 48 89 45 c8 0f 84 ba 01 00 00 41 8b 4c 24 28 49 8b 3c 24 <48> 8b 1c 08 48 8d 4a 01 65 48 0f c7 0f 0f 94 c0 84 c0 74 c2 41 8b [ 1067.361754] RSP: 0018:ffffb83c00ca7ad8 EFLAGS: 00010286 [ 1067.361755] RAX: ffff9c00302d7872 RBX: 0000000000000a20 RCX: 0000000000000000 [ 1067.361755] RDX: 000000000031bfb3 RSI: 0000000000000a20 RDI: 000000000002f2d0 [ 1067.361756] RBP: ffffb83c00ca7b18 R08: ffff9c541fcaf2d0 R09: 0000000000000000 [ 1067.361757] R10: ffffffffb884f560 R11: ffffb83c00ca7dd8 R12: ffff9c50c0042e00 [ 1067.361757] R13: 0000000000000a20 R14: 0000000000000007 R15: ffffffffb603d886 [ 1067.361758] FS: 00007f0aa293b480(0000) GS:ffff9c541fc80000(0000) knlGS:0000000000000000 [ 1067.361759] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1067.361760] CR2: ffff9c00302d7872 CR3: 00000001040e2006 CR4: 00000000003706e0 [ 1067.361761] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1067.361761] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 1067.361762] Call Trace: [ 1067.361766] kmemdup+0x20/0x50 [ 1067.361769] security_sid_to_context_core+0x86/0x290 [ 1067.361771] ? __might_fault+0x79/0x80 [ 1067.361774] security_sid_to_context+0x14/0x20 [ 1067.515084] selinux_secid_to_secctx+0x1d/0x20 [ 1067.519522] security_secid_to_secctx+0x41/0x60 [ 1067.524054] unix_dgram_recvmsg+0x46b/0x600 [ 1067.528241] ? lock_release+0xcf/0x270 [ 1067.531995] sock_recvmsg+0x6d/0x70 [ 1067.535486] ____sys_recvmsg+0x9b/0x1b0 [ 1067.539325] ? import_iovec+0x1b/0x20 [ 1067.542989] ? copy_msghdr_from_user+0x60/0x90 [ 1067.547426] ? avc_has_perm+0x139/0x2b0 [ 1067.551259] ___sys_recvmsg+0x8c/0xd0 [ 1067.554923] ? sock_ioctl+0x280/0x3c0 [ 1067.558580] ? file_has_perm+0xc6/0xd0 [ 1067.562324] ? sock_ioctl+0x280/0x3c0 [ 1067.565984] __sys_recvmsg+0x66/0xb0 [ 1067.569561] ? __sys_recvmsg+0x66/0xb0 [ 1067.573307] ? do_syscall_64+0x13/0x50 [ 1067.577058] __x64_sys_recvmsg+0x1f/0x30 [ 1067.580975] do_syscall_64+0x37/0x50 [ 1067.584547] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 1067.589602] RIP: 0033:0x7f0aa20e26a7 [ 1067.593179] Code: 44 00 00 41 54 41 89 d4 55 48 89 f5 53 89 fb 48 83 ec 10 e8 8b eb ff ff 44 89 e2 48 89 ee 89 df 41 89 c0 b8 2f 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 35 44 89 c7 48 89 44 24 08 e8 c4 eb ff ff 48 [ 1067.611924] RSP: 002b:00007ffec379aca0 EFLAGS: 00000293 ORIG_RAX: 000000000000002f [ 1067.619487] RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 00007f0aa20e26a7 [ 1067.626611] RDX: 0000000040000040 RSI: 00007ffec379ad10 RDI: 0000000000000004 [ 1067.633737] RBP: 00007ffec379ad10 R08: 0000000000000000 R09: 000000000000042a [ 1067.640867] R10: 00000000ffffffff R11: 0000000000000293 R12: 0000000040000040 [ 1067.647993] R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000000 [ 1067.655118] Modules linked in: ip6table_mangle mpls_iptunnel mpls_router sch_etf ip6table_filter xt_conntrack nf_conntrack nf_defrag_ipv4 libcrc32c ip6_tables nf_defrag_ipv6 iptable_filter ip_tables netdevsim vrf 8021q bridge stp llc sch_fq sch_ingress veth algif_hash x86_pkg_temp_thermal fuse [last unloaded: test_blackhole_dev] [ 1067.684200] CR2: ffff9c00302d7872 [ 1067.687511] ---[ end trace 47c4f9ef0796b429 ]--- [ 1067.692123] RIP: 0010:__kmalloc_track_caller+0x100/0x340 [ 1067.697425] Code: 4d 8b 04 24 65 49 8b 50 08 65 4c 03 05 01 70 20 4a 49 8b 00 48 85 c0 48 89 45 c8 0f 84 ba 01 00 00 41 8b 4c 24 28 49 8b 3c 24 <48> 8b 1c 08 48 8d 4a 01 65 48 0f c7 0f 0f 94 c0 84 c0 74 c2 41 8b [ 1067.716163] RSP: 0018:ffffb83c009f3ce8 EFLAGS: 00010286 [ 1067.721380] RAX: ffff9c00302d7872 RBX: 0000000000000cc0 RCX: 0000000000000000 [ 1067.728505] RDX: 000000000031bfb3 RSI: 0000000000000cc0 RDI: 000000000002f2d0 [ 1067.735629] RBP: ffffb83c009f3d28 R08: ffff9c541fcaf2d0 R09: 0000000000000000 [ 1067.742753] R10: ffffb83c009f3b98 R11: 0000000000000246 R12: ffff9c50c0042e00 [ 1067.749874] R13: 0000000000000cc0 R14: 0000000000000005 R15: ffffffffb5da0814 [ 1067.756999] FS: 00007f0aa293b480(0000) GS:ffff9c541fc80000(0000) knlGS:0000000000000000 [ 1067.765078] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1067.770813] CR2: ffff9c00302d7872 CR3: 00000001040e2006 CR4: 00000000003706e0 [ 1067.777938] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1067.785060] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 1067.792185] BUG: sleeping function called from invalid context at /usr/src/kernel/include/linux/percpu-rwsem.h:49 [ 1067.802429] in_atomic(): 0, irqs_disabled(): 1, non_block: 0, pid: 332, name: systemd-journal [ 1067.810941] INFO: lockdep is turned off. [ 1067.814859] irq event stamp: 16046288 [ 1067.818523] hardirqs last enabled at (16046287): [<ffffffffb6aef8c7>] _raw_write_unlock_irq+0x27/0x40 [ 1067.827816] hardirqs last disabled at (16046288): [<ffffffffb6ae8724>] __schedule+0x624/0x950 [ 1067.836334] softirqs last enabled at (16044926): [<ffffffffb6e00308>] __do_softirq+0x308/0x42a [ 1067.845018] softirqs last disabled at (16044919): [<ffffffffb6c00f82>] asm_call_irq_on_stack+0x12/0x20 [ 1067.854316] CPU: 1 PID: 332 Comm: systemd-journal Tainted: G D W K 5.9.0-next-20201016 #1 [ 1067.863432] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 1067.870903] Call Trace: [ 1067.873349] dump_stack+0x7d/0x9f [ 1067.876668] ___might_sleep+0x163/0x250 [ 1067.880506] __might_sleep+0x4a/0x80 [ 1067.884078] exit_signals+0x33/0x2f0 [ 1067.887656] do_exit+0xa9/0xcb0 [ 1067.890796] rewind_stack_do_exit+0x17/0x20 [ 1067.894980] RIP: 0033:0x7f0aa20e26a7 [ 1067.898551] Code: 44 00 00 41 54 41 89 d4 55 48 89 f5 53 89 fb 48 83 ec 10 e8 8b eb ff ff 44 89 e2 48 89 ee 89 df 41 89 c0 b8 2f 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 35 44 89 c7 48 89 44 24 08 e8 c4 eb ff ff 48 [ 1067.917294] RSP: 002b:00007ffec379aca0 EFLAGS: 00000293 ORIG_RAX: 000000000000002f [ 1067.924852] RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 00007f0aa20e26a7 [ 1067.931975] RDX: 0000000040000040 RSI: 00007ffec379ad10 RDI: 0000000000000004 [ 1067.939100] RBP: 00007ffec379ad10 R08: 0000000000000000 R09: 000000000000042a [ 1067.946224] R10: 00000000ffffffff R11: 0000000000000293 R12: 0000000040000040 [ 1067.953348] R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000000 [ 1067.961618] systemd[1]: systemd-journald.service: Service has no hold-off time, scheduling restart. [ 1067.970722] systemd[1]: systemd-journald.service: Scheduled restart job, restart counter is at 1. [ 1067.980063] systemd[1]: Stopped Flush Journal to Persistent Storage. [ 1067.986435] systemd[1]: Stopping Flush Journal to Persistent Storage... [ 1067.993060] systemd[1]: Stopped Journal Service. [ 1067.998163] audit: type=1334 audit(1602906735.603:89090): prog-id=43815 op=LOAD [ 1068.005571] audit: type=1334 audit(1602906735.611:89091): prog-id=43816 op=LOAD [ 1068.005978] systemd[1]: Starting Journal Service... [ 1068.014259] audit: type=1305 audit(1602906735.619:89092): op=set audit_enabled=1 old=1 auid=4294967295 ses=4294967295 subj=kernel res=1 [ 1068.014935] systemd-journald[890]: File /run/log/journal/b58194f5bd004118b8471b91dd8d1ce6/system.journal corrupted or uncleanly shut down, renaming and replacing. [ 1068.044478] audit: type=1334 audit(1602906735.624:89093): prog-id=11 op=UNLOAD [ 1068.051740] audit: type=1334 audit(1602906735.624:89094): prog-id=10 op=UNLOAD [ 1068.072184] systemd[1]: Started Journal Service. [ 1068.077987] BUG: unable to handle page fault for address: ffff9c00302d7872 [ 1068.084862] #PF: supervisor read access in kernel mode [ 1068.089991] #PF: error_code(0x0000) - not-present page [ 1068.095122] PGD 2c401067 P4D 2c401067 PUD 0 [ 1068.099388] Oops: 0000 [#3] SMP PTI [ 1068.102873] CPU: 1 PID: 891 Comm: (urnalctl) Tainted: G D W K 5.9.0-next-20201016 #1 [ 1068.111562] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 1068.119037] RIP: 0010:__kmalloc+0x100/0x330 [ 1068.123220] Code: 4d 8b 04 24 65 49 8b 50 08 65 4c 03 05 a1 7a 20 4a 49 8b 00 48 85 c0 48 89 45 c8 0f 84 bf 01 00 00 41 8b 4c 24 28 49 8b 3c 24 <48> 8b 1c 08 48 8d 4a 01 65 48 0f c7 0f 0f 94 c0 84 c0 74 c2 41 8b [ 1068.141958] RSP: 0018:ffffb83c00107e20 EFLAGS: 00010286 [ 1068.147181] RAX: ffff9c00302d7872 RBX: 0000000000000cc0 RCX: 0000000000000000 [ 1068.154307] RDX: 000000000031bfb3 RSI: 0000000000000cc0 RDI: 000000000002f2d0 [ 1068.161431] RBP: ffffb83c00107e60 R08: ffff9c541fcaf2d0 R09: 0000000000000000 [ 1068.168554] R10: 0000000000000000 R11: 0000000000000001 R12: ffff9c50c0042e00 [ 1068.175678] R13: 0000000000000cc0 R14: 0000000000000005 R15: 0000000000000000 [ 1068.182803] FS: 00007f31ad0f4840(0000) GS:ffff9c541fc80000(0000) knlGS:0000000000000000 [ 1068.190880] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1068.196616] CR2: ffff9c00302d7872 CR3: 00000001040e2001 CR4: 00000000003706e0 [ 1068.203740] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1068.210865] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 1068.217986] Call Trace: [ 1068.220436] ? kernfs_fop_write+0xcf/0x1c0 [ 1068.224533] kernfs_fop_write+0xcf/0x1c0 [ 1068.228458] vfs_write+0xed/0x240 [ 1068.231768] ksys_write+0xad/0xf0 [ 1068.235080] __x64_sys_write+0x1a/0x20 [ 1068.238833] do_syscall_64+0x37/0x50 [ 1068.242411] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 1068.247456] RIP: 0033:0x7f31ab8ed177 [ 1068.251033] Code: 0f 1f 00 41 54 49 89 d4 55 48 89 f5 53 89 fb 48 83 ec 10 e8 5b ad 01 00 4c 89 e2 48 89 ee 89 df 41 89 c0 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 35 44 89 c7 48 89 44 24 08 e8 94 ad 01 00 48 [ 1068.269769] RSP: 002b:00007ffe1b95a340 EFLAGS: 00000293 ORIG_RAX: 0000000000000001 [ 1068.277327] RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f31ab8ed177 [ 1068.284451] RDX: 0000000000000004 RSI: 000055bf0a08e8f0 RDI: 0000000000000003 [ 1068.291575] RBP: 000055bf0a08e8f0 R08: 0000000000000000 R09: 00007ffe1b95a2a5 [ 1068.298700] R10: 0000000000000000 R11: 0000000000000293 R12: 0000000000000004 [ 1068.305823] R13: 0000000000000004 R14: 00007f31abbb2760 R15: 0000000000000004 [ 1068.312951] Modules linked in: ip6table_mangle mpls_iptunnel mpls_router sch_etf ip6table_filter xt_conntrack nf_conntrack nf_defrag_ipv4 libcrc32c ip6_tables nf_defrag_ipv6 iptable_filter ip_tables netdevsim vrf 8021q bridge stp llc sch_fq sch_ingress veth algif_hash x86_pkg_temp_thermal fuse [last unloaded: test_blackhole_dev] [ 1068.342031] CR2: ffff9c00302d7872 [ 1068.345342] ---[ end trace 47c4f9ef0796b42a ]--- [ 1068.349953] RIP: 0010:__kmalloc_track_caller+0x100/0x340 ref: https://lkft.validation.linaro.org/scheduler/job/1851078#L11407 -- Linaro LKFT https://lkft.linaro.org

5 years

1
0
0 0

[PATCH v3] lib: kunit: add test_min_heap test conversion to KUnit

by Vitor Massaru Iha

This adds the conversion of the runtime tests of test_min_heap, from `lib/test_min_heap.c` to KUnit tests. Signed-off-by: Vitor Massaru Iha <vitor(a)massaru.org> --- v2: * change Kconfig entries to be more adherent to KUnit documentation, min_heap test runs when enabling full test coverage (KUNIT_ALL_TESTS). * make kconfig help more concise; * fix KUNIT_TEST sufix; v3: * change KUNIT_EXPECT_FALSE_MSG for KUNIT_EXPECT_LE and KUNIT_EXPECT_GE where they are applicable; --- lib/Kconfig.debug | 24 +++-- lib/Makefile | 2 +- lib/{test_min_heap.c => min_heap_kunit.c} | 111 +++++++++++----------- 3 files changed, 72 insertions(+), 65 deletions(-) rename lib/{test_min_heap.c => min_heap_kunit.c} (62%) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 4f09c6505a2e..0e10ef1176de 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1915,16 +1915,6 @@ config TEST_LIST_SORT If unsure, say N. -config TEST_MIN_HEAP - tristate "Min heap test" - depends on DEBUG_KERNEL || m - help - Enable this to turn on min heap function tests. This test is - executed only once during system boot (so affects only boot time), - or at module load time. - - If unsure, say N. - config TEST_SORT tristate "Array-based sort test" depends on DEBUG_KERNEL || m @@ -2256,6 +2246,20 @@ config BITS_TEST If unsure, say N. +config MIN_HEAP_KUNIT_TEST + tristate "KUnit test for Min heap" if !KUNIT_ALL_TESTS + depends on KUNIT + default KUNIT_ALL_TESTS + help + Enable this to turn on min heap function tests. This test is + executed only once during system boot (so affects only boot time), + or at module load time. + + For more information on KUnit and unit tests in general please refer + to the KUnit documentation in Documentation/dev-tools/kunit/. + + If unsure, say N. + config TEST_UDELAY tristate "udelay test driver" help diff --git a/lib/Makefile b/lib/Makefile index d862d41fdc3d..03d12e672cf8 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -68,7 +68,6 @@ CFLAGS_test_ubsan.o += $(call cc-disable-warning, vla) UBSAN_SANITIZE_test_ubsan.o := y obj-$(CONFIG_TEST_KSTRTOX) += test-kstrtox.o obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o -obj-$(CONFIG_TEST_MIN_HEAP) += test_min_heap.o obj-$(CONFIG_TEST_LKM) += test_module.o obj-$(CONFIG_TEST_VMALLOC) += test_vmalloc.o obj-$(CONFIG_TEST_OVERFLOW) += test_overflow.o @@ -343,3 +342,4 @@ obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o obj-$(CONFIG_BITS_TEST) += test_bits.o +obj-$(CONFIG_MIN_HEAP_KUNIT_TEST) += min_heap_kunit.o diff --git a/lib/test_min_heap.c b/lib/min_heap_kunit.c similarity index 62% rename from lib/test_min_heap.c rename to lib/min_heap_kunit.c index d19c8080fd4d..97c5771f2b5e 100644 --- a/lib/test_min_heap.c +++ b/lib/min_heap_kunit.c @@ -7,9 +7,8 @@ #include <linux/log2.h> #include <linux/min_heap.h> -#include <linux/module.h> -#include <linux/printk.h> #include <linux/random.h> +#include <kunit/test.h> static __init bool less_than(const void *lhs, const void *rhs) { @@ -29,37 +28,28 @@ static __init void swap_ints(void *lhs, void *rhs) *(int *)rhs = temp; } -static __init int pop_verify_heap(bool min_heap, +static __init void pop_verify_heap(struct kunit *context, + bool min_heap, struct min_heap *heap, const struct min_heap_callbacks *funcs) { int *values = heap->data; - int err = 0; int last; last = values[0]; min_heap_pop(heap, funcs); while (heap->nr > 0) { if (min_heap) { - if (last > values[0]) { - pr_err("error: expected %d <= %d\n", last, - values[0]); - err++; - } + KUNIT_EXPECT_LE(context, last, values[0]); } else { - if (last < values[0]) { - pr_err("error: expected %d >= %d\n", last, - values[0]); - err++; - } + KUNIT_EXPECT_GE(context, last, values[0]); } last = values[0]; min_heap_pop(heap, funcs); } - return err; } -static __init int test_heapify_all(bool min_heap) +static __init void test_heapify_all(struct kunit *context, bool min_heap) { int values[] = { 3, 1, 2, 4, 0x8000000, 0x7FFFFFF, 0, -3, -1, -2, -4, 0x8000000, 0x7FFFFFF }; @@ -73,12 +63,11 @@ static __init int test_heapify_all(bool min_heap) .less = min_heap ? less_than : greater_than, .swp = swap_ints, }; - int i, err; + int i; /* Test with known set of values. */ min_heapify_all(&heap, &funcs); - err = pop_verify_heap(min_heap, &heap, &funcs); - + pop_verify_heap(context, min_heap, &heap, &funcs); /* Test with randomly generated values. */ heap.nr = ARRAY_SIZE(values); @@ -86,12 +75,10 @@ static __init int test_heapify_all(bool min_heap) values[i] = get_random_int(); min_heapify_all(&heap, &funcs); - err += pop_verify_heap(min_heap, &heap, &funcs); - - return err; + pop_verify_heap(context, min_heap, &heap, &funcs); } -static __init int test_heap_push(bool min_heap) +static __init void test_heap_push(struct kunit *context, bool min_heap) { const int data[] = { 3, 1, 2, 4, 0x80000000, 0x7FFFFFFF, 0, -3, -1, -2, -4, 0x80000000, 0x7FFFFFFF }; @@ -106,25 +93,22 @@ static __init int test_heap_push(bool min_heap) .less = min_heap ? less_than : greater_than, .swp = swap_ints, }; - int i, temp, err; + int i, temp; /* Test with known set of values copied from data. */ for (i = 0; i < ARRAY_SIZE(data); i++) min_heap_push(&heap, &data[i], &funcs); - - err = pop_verify_heap(min_heap, &heap, &funcs); + pop_verify_heap(context, min_heap, &heap, &funcs); /* Test with randomly generated values. */ while (heap.nr < heap.size) { temp = get_random_int(); min_heap_push(&heap, &temp, &funcs); } - err += pop_verify_heap(min_heap, &heap, &funcs); - - return err; + pop_verify_heap(context, min_heap, &heap, &funcs); } -static __init int test_heap_pop_push(bool min_heap) +static __init void test_heap_pop_push(struct kunit *context, bool min_heap) { const int data[] = { 3, 1, 2, 4, 0x80000000, 0x7FFFFFFF, 0, -3, -1, -2, -4, 0x80000000, 0x7FFFFFFF }; @@ -139,7 +123,7 @@ static __init int test_heap_pop_push(bool min_heap) .less = min_heap ? less_than : greater_than, .swp = swap_ints, }; - int i, temp, err; + int i, temp; /* Fill values with data to pop and replace. */ temp = min_heap ? 0x80000000 : 0x7FFFFFFF; @@ -149,8 +133,7 @@ static __init int test_heap_pop_push(bool min_heap) /* Test with known set of values copied from data. */ for (i = 0; i < ARRAY_SIZE(data); i++) min_heap_pop_push(&heap, &data[i], &funcs); - - err = pop_verify_heap(min_heap, &heap, &funcs); + pop_verify_heap(context, min_heap, &heap, &funcs); heap.nr = 0; for (i = 0; i < ARRAY_SIZE(data); i++) @@ -161,34 +144,54 @@ static __init int test_heap_pop_push(bool min_heap) temp = get_random_int(); min_heap_pop_push(&heap, &temp, &funcs); } - err += pop_verify_heap(min_heap, &heap, &funcs); + pop_verify_heap(context, min_heap, &heap, &funcs); +} - return err; +static void __init test_heapify_all_true(struct kunit *context) +{ + test_heapify_all(context, true); } -static int __init test_min_heap_init(void) +static void __init test_heapify_all_false(struct kunit *context) { - int err = 0; - - err += test_heapify_all(true); - err += test_heapify_all(false); - err += test_heap_push(true); - err += test_heap_push(false); - err += test_heap_pop_push(true); - err += test_heap_pop_push(false); - if (err) { - pr_err("test failed with %d errors\n", err); - return -EINVAL; - } - pr_info("test passed\n"); - return 0; + test_heapify_all(context, true); +} + +static void __init test_heap_push_true(struct kunit *context) +{ + test_heap_push(context, true); +} + +static void __init test_heap_push_false(struct kunit *context) +{ + test_heap_push(context, false); } -module_init(test_min_heap_init); -static void __exit test_min_heap_exit(void) +static void __init test_heap_pop_push_true(struct kunit *context) { - /* do nothing */ + test_heap_pop_push(context, true); } -module_exit(test_min_heap_exit); + +static void __init test_heap_pop_push_false(struct kunit *context) +{ + test_heap_pop_push(context, false); +} + +static struct kunit_case __refdata min_heap_test_cases[] = { + KUNIT_CASE(test_heapify_all_true), + KUNIT_CASE(test_heapify_all_false), + KUNIT_CASE(test_heap_push_true), + KUNIT_CASE(test_heap_push_false), + KUNIT_CASE(test_heap_pop_push_true), + KUNIT_CASE(test_heap_pop_push_false), + {} +}; + +static struct kunit_suite min_heap_test_suite = { + .name = "min-heap", + .test_cases = min_heap_test_cases, +}; + +kunit_test_suites(&min_heap_test_suite); MODULE_LICENSE("GPL"); base-commit: d2585f5164c298aaaed14c2c8d313cbe7bd5b253 -- 2.26.2

5 years

2
1
0 0

[PATCH RFC V3 0/9] PKS: Add Protection Keys Supervisor (PKS) support RFC v3

by ira.weiny＠intel.com

From: Ira Weiny <ira.weiny(a)intel.com> This RFC series has been reviewed by Dave Hansen. Introduce a new page protection mechanism for supervisor pages, Protection Key Supervisor (PKS). 2 use cases for PKS are being developed, trusted keys and PMEM. Trusted keys is a newer use case which is still being explored. PMEM was submitted as part of the RFC (v2) series[1]. However, since then it was found that some callers of kmap() require a global implementation of PKS. Specifically some users of kmap() expect mappings to be available to all kernel threads. While global use of PKS is rare it needs to be included for correctness. Unfortunately the kmap() updates required a large patch series to make the needed changes at the various kmap() call sites so that patch set has been split out. Because the global PKS feature is only required for that use case it will be deferred to that set as well.[2] This patch set is being submitted as a precursor to both of the use cases. For an overview of the entire PKS ecosystem, a git tree including this series and the 2 use cases can be found here: https://github.com/weiny2/linux-kernel/tree/pks-rfc-v3 PKS enables protections on 'domains' of supervisor pages to limit supervisor mode access to those pages beyond the normal paging protections. PKS works in a similar fashion to user space pkeys, PKU. As with PKU, supervisor pkeys are checked in addition to normal paging protections and Access or Writes can be disabled via a MSR update without TLB flushes when permissions change. Also like PKU, a page mapping is assigned to a domain by setting pkey bits in the page table entry for that mapping. Access is controlled through a PKRS register which is updated via WRMSR/RDMSR. XSAVE is not supported for the PKRS MSR. Therefore the implementation saves/restores the MSR across context switches and during exceptions. Nested exceptions are supported by each exception getting a new PKS state. For consistent behavior with current paging protections, pkey 0 is reserved and configured to allow full access via the pkey mechanism, thus preserving the default paging protections on mappings with the default pkey value of 0. Other keys, (1-15) are allocated by an allocator which prepares us for key contention from day one. Kernel users should be prepared for the allocator to fail either because of key exhaustion or due to PKS not being supported on the arch and/or CPU instance. The following are key attributes of PKS. 1) Fast switching of permissions 1a) Prevents access without page table manipulations 1b) No TLB flushes required 2) Works on a per thread basis PKS is available with 4 and 5 level paging. Like PKRU it consumes 4 bits from the PTE to store the pkey within the entry. [1] https://lore.kernel.org/lkml/20200717072056.73134-1-ira.weiny@intel.com/ [2] https://github.com/weiny2/linux-kernel/commit/f10abb0f0d7b4e14f03fc8890313a… and a testing patch https://github.com/weiny2/linux-kernel/commit/2a8e0fc7654a7c69b243d628f63b0… Fenghua Yu (3): x86/fpu: Refactor arch_set_user_pkey_access() for PKS support x86/pks: Enable Protection Keys Supervisor (PKS) x86/pks: Add PKS kernel API Ira Weiny (6): x86/pkeys: Create pkeys_common.h x86/pks: Preserve the PKRS MSR on context switch x86/entry: Pass irqentry_state_t by reference x86/entry: Preserve PKRS MSR across exceptions x86/fault: Report the PKRS state on fault x86/pks: Add PKS test code Documentation/core-api/protection-keys.rst | 102 ++- arch/x86/Kconfig | 1 + arch/x86/entry/common.c | 57 +- arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/idtentry.h | 29 +- arch/x86/include/asm/msr-index.h | 1 + arch/x86/include/asm/pgtable.h | 13 +- arch/x86/include/asm/pgtable_types.h | 12 + arch/x86/include/asm/pkeys.h | 15 + arch/x86/include/asm/pkeys_common.h | 36 + arch/x86/include/asm/processor.h | 13 + arch/x86/include/uapi/asm/processor-flags.h | 2 + arch/x86/kernel/cpu/common.c | 17 + arch/x86/kernel/cpu/mce/core.c | 4 + arch/x86/kernel/fpu/xstate.c | 22 +- arch/x86/kernel/kvm.c | 4 +- arch/x86/kernel/nmi.c | 7 +- arch/x86/kernel/process.c | 21 + arch/x86/kernel/traps.c | 21 +- arch/x86/mm/fault.c | 86 ++- arch/x86/mm/pkeys.c | 188 +++++- include/linux/entry-common.h | 19 +- include/linux/pgtable.h | 4 + include/linux/pkeys.h | 23 +- kernel/entry/common.c | 28 +- lib/Kconfig.debug | 12 + lib/Makefile | 3 + lib/pks/Makefile | 3 + lib/pks/pks_test.c | 690 ++++++++++++++++++++ mm/Kconfig | 2 + tools/testing/selftests/x86/Makefile | 3 +- tools/testing/selftests/x86/test_pks.c | 65 ++ 32 files changed, 1376 insertions(+), 128 deletions(-) create mode 100644 arch/x86/include/asm/pkeys_common.h create mode 100644 lib/pks/Makefile create mode 100644 lib/pks/pks_test.c create mode 100644 tools/testing/selftests/x86/test_pks.c -- 2.28.0.rc0.12.gb6a658bd00c9

5 years

5
46
0 0

[PATCHv5] selftests: rtnetlink: load fou module for kci_test_encap_fou() test

by Po-Hsu Lin

The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh needs the fou module to work. Otherwise it will fail with: $ ip netns exec "$testns" ip fou add port 7777 ipproto 47 RTNETLINK answers: No such file or directory Error talking to the kernel Add the CONFIG_NET_FOU into the config file as well. Which needs at least to be set as a loadable module. Signed-off-by: Po-Hsu Lin <po-hsu.lin(a)canonical.com> --- tools/testing/selftests/net/config | 1 + tools/testing/selftests/net/rtnetlink.sh | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config index 4364924..4d5df8e 100644 --- a/tools/testing/selftests/net/config +++ b/tools/testing/selftests/net/config @@ -33,3 +33,4 @@ CONFIG_KALLSYMS=y CONFIG_TRACEPOINTS=y CONFIG_NET_DROP_MONITOR=m CONFIG_NETDEVSIM=m +CONFIG_NET_FOU=m diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh index 8a2fe6d..c9ce3df 100755 --- a/tools/testing/selftests/net/rtnetlink.sh +++ b/tools/testing/selftests/net/rtnetlink.sh @@ -520,6 +520,11 @@ kci_test_encap_fou() return $ksft_skip fi + if ! /sbin/modprobe -q -n fou; then + echo "SKIP: module fou is not found" + return $ksft_skip + fi + /sbin/modprobe -q fou ip -netns "$testns" fou add port 7777 ipproto 47 2>/dev/null if [ $? -ne 0 ];then echo "FAIL: can't add fou port 7777, skipping test" -- 2.7.4

5 years

2
1
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror