- Linux-kselftest-mirror - lists.linaro.org

[PATCH] selftests/*/Makefile: stop calling headers_install

by Anders Roxell

Various tests should not call headers_install. Adding headers_install as a prereq before building kselftests. Signed-off-by: Anders Roxell <anders.roxell(a)linaro.org> --- tools/testing/selftests/Makefile | 5 ++++- tools/testing/selftests/gpio/Makefile | 6 +----- tools/testing/selftests/vm/Makefile | 4 ---- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 2d73f7f0b180..5b8553654d6b 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -74,13 +74,16 @@ endif export KSFT_TAP_LEVEL=`echo 1` export BUILD -all: +all: headers_install @for TARGET in $(TARGETS); do \ BUILD_TARGET=$$BUILD/$$TARGET; \ mkdir $$BUILD_TARGET -p; \ make OUTPUT=$$BUILD_TARGET -C $$TARGET;\ done; +headers_install: + make -C ../../.. headers_install + run_tests: all @for TARGET in $(TARGETS); do \ BUILD_TARGET=$$BUILD/$$TARGET; \ diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile index 1bbb47565c55..9ef4d751268b 100644 --- a/tools/testing/selftests/gpio/Makefile +++ b/tools/testing/selftests/gpio/Makefile @@ -21,11 +21,7 @@ endef CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/ LDLIBS += -lmount -I/usr/include/libmount -$(BINARIES): ../../../gpio/gpio-utils.o ../../../../usr/include/linux/gpio.h +$(BINARIES): ../../../gpio/gpio-utils.o ../../../gpio/gpio-utils.o: make ARCH=$(ARCH) CROSS_COMPILE=$(CROSS_COMPILE) -C ../../../gpio - -../../../../usr/include/linux/gpio.h: - make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/ - diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index fdefa2295ddc..58759454b1d0 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -25,10 +25,6 @@ TEST_PROGS := run_vmtests include ../lib.mk -$(OUTPUT)/userfaultfd: ../../../../usr/include/linux/kernel.h $(OUTPUT)/userfaultfd: LDLIBS += -lpthread $(OUTPUT)/mlock-random-test: LDLIBS += -lcap - -../../../../usr/include/linux/kernel.h: - make -C ../../../.. headers_install -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 9 months

1
0
0 0

[PATCH] selftests: prevent carpal tunnel

by Alexey Dobriyan

Shuah, please do ln -s tools/testing/selftests test It will save a lot of typing for everyone over the years. Signed-off-by: Alexey Dobriyan <adobriyan(a)gmail.com> --- test | 1 + 1 file changed, 1 insertion(+) new file mode 120000 --- /dev/null +++ b/test @@ -0,0 +1 @@ +tools/testing/selftests \ No newline at end of file -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 9 months

1
0
0 0

[PATCH] selftests/ipc/msgque: Fix warning implicit declaration

by Anders Roxell

gcc warns about implicit declaration. gcc -I../../../../usr/include/ msgque.c -o msgque msgque.c: In function ‘restore_queue’: msgque.c:52:7: warning: implicit declaration of function ‘msgget’ [-Wimplicit-function-declaration] id = msgget(msgque->key, msgque->mode | IPC_CREAT | IPC_EXCL); ^~~~~~ msgque.c:66:7: warning: implicit declaration of function ‘msgsnd’ [-Wimplicit-function-declaration] if (msgsnd(msgque->msq_id, &msgque->messages[i].mtype, ^~~~~~ msgque.c:76:6: warning: implicit declaration of function ‘msgctl’ [-Wimplicit-function-declaration] if (msgctl(id, IPC_RMID, 0)) ^~~~~~ msgque.c: In function ‘check_and_destroy_queue’: msgque.c:87:9: warning: implicit declaration of function ‘msgrcv’ [-Wimplicit-function-declaration] ret = msgrcv(msgque->msq_id, &message.mtype, MAX_MSG_SIZE, ^~~~~~ msgque.c: In function ‘main’: msgque.c:204:15: warning: implicit declaration of function ‘ftok’ [-Wimplicit-function-declaration] msgque.key = ftok(argv[0], 822155650); ^~~~ In the current code, we include the headers that the functions want according to the man pages, and we define MSG_COPY if its not defined. We also use 'struct msqid_ds' instead of 'struct msqid64_ds'. I thought about another patch where I just forward declared these functions. However, I wasn't happy with that patch since it feels that it forces user space apps to do the same in order to get this to work. Another reason was that checkpatch.pl complained that I added forward declarations in the c file. Fixes: 3a665531a3b7 ("selftests: IPC message queue copy feature test") Signed-off-by: Anders Roxell <anders.roxell(a)linaro.org> --- tools/testing/selftests/ipc/msgque.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c index ee9382bdfadc..3e32917cd7f4 100644 --- a/tools/testing/selftests/ipc/msgque.c +++ b/tools/testing/selftests/ipc/msgque.c @@ -3,11 +3,18 @@ #include <stdio.h> #include <string.h> #include <errno.h> -#include <linux/msg.h> #include <fcntl.h> +#include <sys/types.h> +#include <sys/ipc.h> +#include <sys/msg.h> + #include "../kselftest.h" +#ifndef MSG_COPY +# define MSG_COPY 040000 /* copy (not remove) all queue messages */ +#endif + #define MAX_MSG_SIZE 32 struct msg1 { @@ -129,7 +136,7 @@ int check_and_destroy_queue(struct msgque_data *msgque) int dump_queue(struct msgque_data *msgque) { - struct msqid64_ds ds; + struct msqid_ds ds; int kern_id; int i, ret; -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 9 months

1
0
0 0

kernel_selftests.x86.mpx-mini-test_32.fail on skylake platform

by Li Zhijian

Hi all 0Day noticed that kernel_selftests.x86.mpx-mini-test_32.fail at recent upstream kernel a. v4.11 Good b. v4.12 and later: Bad And the 64bit application kernel_selftests.x86.mpx-mini-test_64 is always good. 0Day robot tried to bisect the FBC, but it failed at last. But anyway i want to let you know we had this issue. below is the testing log at v4.12 ----------------------- 2018-03-02 23:12:08 make run_tests -C x86 make: Entering directory '/usr/src/linux-selftests-x86_64-rhel-7.2_mpx-6f7da290413ba713f0cdd9ff1a2a9bb129ef4f6c/tools/testing/selftests/x86' #BR status == 2, missing bounds table,kernel should have handled!! XSAVE is supported by HW & OS XSAVE processor supported state mask: 0x2ff XSAVE OS supported state mask: 0x2ff BNDREGS: size: 64 user: 1 supervisor: 0 aligned: 0 BNDCSR: size: 64 user: 1 supervisor: 0 aligned: 0 executing unmaptest mpx dig ( 1) complete, SUCCESS ( 0 / 0) selftests: mpx-mini-test_32 [FAIL] ----------------------- 0Day Environment OS: Debian 9 kernel: v4.12 model: Skylake nr_cpu: 104 memory: 64G brand: Intel(R) Xeon(R) Platinum 8170 CPU @ 2.10GHz ------------------------- as a comparison, paste the log at v4.11 as following XSAVE is supported by HW & OS XSAVE processor supported state mask: 0x2ff XSAVE OS supported state mask: 0x2ff BNDREGS: size: 64 user: 1 supervisor: 0 aligned: 0 BNDCSR: size: 64 user: 1 supervisor: 0 aligned: 0 executing unmaptest mpx dig ( 1) complete, SUCCESS ( 0 / 0) iteration 1 complete, OK so far mpx dig ( 2) complete, SUCCESS ( 8836 / 5554) mpx dig ( 3) complete, SUCCESS ( 2761 / 1760) mpx dig ( 4) complete, SUCCESS ( 4494 / 2828) mpx dig ( 5) complete, SUCCESS ( 531 / 337) mpx dig ( 6) complete, SUCCESS ( 145 / 92) mpx dig ( 7) complete, SUCCESS ( 0 / 0) mpx dig ( 8) complete, SUCCESS ( 0 / 0) mpx dig ( 9) complete, SUCCESS ( 0 / 0) mpx dig ( 10) complete, SUCCESS ( 0 / 0) mpx dig ( 11) complete, SUCCESS ( 0 / 0) mpx dig ( 12) complete, SUCCESS ( 0 / 0) mpx dig ( 13) complete, SUCCESS ( 0 / 0) mpx dig ( 14) complete, SUCCESS ( 0 / 0) mpx dig ( 15) complete, SUCCESS ( 0 / 0) mpx dig ( 16) complete, SUCCESS ( 0 / 0) iteration 1566 complete, OK so far mpx dig ( 17) complete, SUCCESS ( 0 / 0) mpx dig ( 18) complete, SUCCESS ( 0 / 0) mpx dig ( 19) complete, SUCCESS ( 0 / 0) mpx dig ( 20) complete, SUCCESS ( 0 / 0) mpx dig ( 21) complete, SUCCESS ( 0 / 0) mpx dig ( 22) complete, SUCCESS ( 0 / 0) mpx dig ( 23) complete, SUCCESS ( 0 / 0) mpx dig ( 24) complete, SUCCESS ( 0 / 0) mpx dig ( 25) complete, SUCCESS ( 0 / 0) mpx dig ( 26) complete, SUCCESS ( 0 / 0) mpx dig ( 27) complete, SUCCESS ( 0 / 0) mpx dig ( 28) complete, SUCCESS ( 0 / 0) mpx dig ( 29) complete, SUCCESS ( 0 / 0) mpx dig ( 30) complete, SUCCESS ( 0 / 0) mpx dig ( 31) complete, SUCCESS ( 0 / 0) mpx dig ( 32) complete, SUCCESS ( 0 / 0) mpx dig ( 33) complete, SUCCESS ( 0 / 0) mpx dig ( 34) complete, SUCCESS ( 0 / 0) mpx dig ( 35) complete, SUCCESS ( 0 / 0) mpx dig ( 36) complete, SUCCESS ( 0 / 0) mpx dig ( 37) complete, SUCCESS ( 0 / 0) mpx dig ( 38) complete, SUCCESS ( 0 / 0) mpx dig ( 39) complete, SUCCESS ( 0 / 0) mpx dig ( 40) complete, SUCCESS ( 0 / 0) iteration 3325 complete, OK so far done with malloc() fun starting mpx bounds table test iteration 4574 complete, OK so far iteration 9157 complete, OK so far done with mpx bounds table test ./mpx-mini-test_32 completed successfully selftests: mpx-mini-test_32 [PASS] Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 9 months

1
0
0 0

[PATCH] selftests/net: enable fragments for fib-onlink-tests

by Anders Roxell

We miss CONFIG_* fragments so test fib-onlink-tests.sh can do: ip li add lisa type vrf table 1101 ip li add veth1 type veth peer name veth2 And the follow message occurs if it isn't enabled: Configuring interfaces RTNETLINK answers: Operation not supported This enables for NET_NRF (and friends) and VETH so we can create a vrf table and veth. Fixes: 153e1b84f477 ("selftests: Add FIB onlink tests") Signed-off-by: Anders Roxell <anders.roxell(a)linaro.org> --- tools/testing/selftests/net/config | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config index 7177bea1fdfa..6a75a3ea44ad 100644 --- a/tools/testing/selftests/net/config +++ b/tools/testing/selftests/net/config @@ -2,3 +2,8 @@ CONFIG_USER_NS=y CONFIG_BPF_SYSCALL=y CONFIG_TEST_BPF=m CONFIG_NUMA=y +CONFIG_NET_VRF=y +CONFIG_NET_L3_MASTER_DEV=y +CONFIG_IPV6=y +CONFIG_IPV6_MULTIPLE_TABLES=y +CONFIG_VETH=y -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 9 months

3
2
0 0

[PATCH] selftests/size: rework to use main instead of _start

by Anders Roxell

In a -ffreestanding environment without glibc, we shouldn't be able to call either getenv or printf. It seems that printf() happens to work fine, but it ends up using the glibc getenv(), which doesn't work unless we call the glibc _start() function first. Using _start() was originally meant as an optimization to reduce the memory consumption of the test program itself, in order to get a more accurate representation of the available RAM at system boot time. However, it causes more problems than it helps, especially when run from a shell script that also consumes some memory. get_size[2838]: segfault at ffffffffffffffd0 ip 000000000040538b sp 00007ffc41980668 error 5 in get_size[400000+b0000] audit: type=1701 audit(1521532923.838:4): auid=0 uid=0 gid=0 ses=2 subj=kernel pid=2838 comm=\"get_size\" exe=\"/opt/kselftests/next/size/get_size\" sig=11 res=1 get_size[2840]: segfault at ffffffffffffffd0 ip 000000000040538b sp 00007ffdace9b378 error 5 in get_size[400000+b0000] audit: type=1701 audit(1521532932.057:5): auid=0 uid=0 gid=0 ses=2 subj=kernel pid=2840 comm=\"get_size\" exe=\"/opt/kselftests/next/size/get_size\" sig=11 res=1 Rework to get_size test to use main (and printf) instead of _start. All other seftest tests uses main and not _start. Fixes: 0081901af95f ("selftests: size call ksft_print_header() to print TAP header") Signed-off-by: Anders Roxell <anders.roxell(a)linaro.org> --- tools/testing/selftests/size/Makefile | 2 +- tools/testing/selftests/size/get_size.c | 47 ++++++++++----------------------- 2 files changed, 15 insertions(+), 34 deletions(-) diff --git a/tools/testing/selftests/size/Makefile b/tools/testing/selftests/size/Makefile index 4685b3e421fc..73932e0e7cd0 100644 --- a/tools/testing/selftests/size/Makefile +++ b/tools/testing/selftests/size/Makefile @@ -1,4 +1,4 @@ -CFLAGS := -static -ffreestanding -nostartfiles -s +CFLAGS := -static -ffreestanding -s TEST_GEN_PROGS := get_size diff --git a/tools/testing/selftests/size/get_size.c b/tools/testing/selftests/size/get_size.c index 1280b09266f0..490cf4e26eaf 100644 --- a/tools/testing/selftests/size/get_size.c +++ b/tools/testing/selftests/size/get_size.c @@ -26,13 +26,6 @@ #include <stdio.h> #include "../kselftest.h" -#define STDOUT_FILENO 1 - -static int print(const char *s) -{ - return write(STDOUT_FILENO, s, __builtin_strlen(s)); -} - static inline char *num_to_str(unsigned long num, char *buf, int len) { unsigned int digit; @@ -49,30 +42,18 @@ static inline char *num_to_str(unsigned long num, char *buf, int len) return buf; } -static int print_num(unsigned long num) -{ - char num_buf[30]; - - return print(num_to_str(num, num_buf, sizeof(num_buf))); -} - static int print_k_value(const char *s, unsigned long num, unsigned long units) { unsigned long long temp; - int ccode; - - print(s); temp = num; temp = (temp * units)/1024; num = temp; - ccode = print_num(num); - print("\n"); - return ccode; + return printf("%s%d\n", s, num); } /* this program has no main(), as startup libraries are not used */ -void _start(void) +int main(void) { int ccode; struct sysinfo info; @@ -80,28 +61,28 @@ void _start(void) static const char *test_name = " get runtime memory use\n"; ksft_print_header(); - print("# Testing system size.\n"); + printf("# Testing system size.\n"); ccode = sysinfo(&info); if (ccode < 0) { - print("not ok 1"); - print(test_name); - print(" ---\n reason: \"could not get sysinfo\"\n ...\n"); - _exit(ccode); + printf("not ok 1"); + printf(test_name); + printf(" ---\n reason: \"could not get sysinfo\"\n ...\n"); + return 1; } - print("ok 1"); - print(test_name); + printf("ok 1"); + printf(test_name); /* ignore cache complexities for now */ used = info.totalram - info.freeram - info.bufferram; - print("# System runtime memory report (units in Kilobytes):\n"); - print(" ---\n"); + printf("# System runtime memory report (units in Kilobytes):\n"); + printf(" ---\n"); print_k_value(" Total: ", info.totalram, info.mem_unit); print_k_value(" Free: ", info.freeram, info.mem_unit); print_k_value(" Buffer: ", info.bufferram, info.mem_unit); print_k_value(" In use: ", used, info.mem_unit); - print(" ...\n"); - print("1..1\n"); + printf(" ...\n"); + printf("1..1\n"); - _exit(0); + return 0; } -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 9 months

2
2
0 0

[PATCH v2] selftests: futex Makefile add top level TAP header echo to RUN_TESTS

by Shuah Khan

Add top level TAP header echo, testname and separator line to make the output consistent with the common run_tests target. This change prevents nested TAP13 headers output from individual tests. Nested TAP13 headers could cause problems for some parsers. Signed-off-by: Shuah Khan <shuahkh(a)osg.samsung.com> --- Changes since v1: - Add export KSFT_TAP_LEVEL to fix nested TAP header problem for "make -C" usecase - Update commit log with details on nested TAP headers. tools/testing/selftests/futex/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile index cea4adcd42b8..3006febb59fe 100644 --- a/tools/testing/selftests/futex/Makefile +++ b/tools/testing/selftests/futex/Makefile @@ -18,6 +18,10 @@ all: done override define RUN_TESTS + @export KSFT_TAP_LEVEL=`echo 1`; + @echo "TAP version 13"; + @echo "selftests: futex"; + @echo "========================================"; @cd $(OUTPUT); ./run.sh endef -- 2.14.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 9 months

2
2
0 0

[PATCH 0/5] Handling for TAP header level

by Shuah Khan

This patch series is a result discussion with Tim Bird about nested TAP header handling. Based on the discussion, I am introducing a environment variable to prevent nested TAP headers. These patches improve the run_tests output and the output from the script generated by emit_tests. This first patch in this series adds environment variable KSFT_TAP_LEVEL to avoid printing nested TAP headers for each test. lib.mk run_tests target prints TAP header before invoking the test program or test script. Tests need a way to suppress TAP headers if it is already printed out. This new environment variable adds a way for ksft_print_header() print TAP header only when KSFT_TAP_LEVEL isn't set. The second patch in this series changes lib.mk run_tests target to set KSFT_TAP_LEVEL before running tests. The third patch changes Makefile to export KSFT_TAP_LEVEL and adds TAP and KSFT_TAP_LEVEL handling to emit_tests target. Forth and fifth patches make changes to size and futex tests to prevent nested TAP headers to take advantage of the framework change in the first patch. Shuah Khan (5): selftests: kselftest framework: add handling for TAP header level selftests: lib.mk set KSFT_TAP_LEVEL to prevent nested TAP headers selftests: Makefile set KSFT_TAP_LEVEL to prevent nested TAP headers selftests: size call ksft_print_header() to print TAP header selftests: futex Makefile add top level TAP header echo to RUN_TESTS tools/testing/selftests/Makefile | 10 +++++++++- tools/testing/selftests/futex/Makefile | 3 +++ tools/testing/selftests/kselftest.h | 3 ++- tools/testing/selftests/lib.mk | 1 + tools/testing/selftests/size/get_size.c | 4 +++- 5 files changed, 18 insertions(+), 3 deletions(-) -- 2.14.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 9 months

3
9
0 0

[GIT PULL] kselftest fixes update for 4.16-5

by Shuah Khan

Hi Linus, Please pull the following Kselftest update for 4.16-rc5. This kselftest fixes update has a fix for regression in memory-hotplug install script that prevents the test from running on the target. Diff for the update is attached. thanks, -- Shuah ----------------------------------------------------------------------------------- The following changes since commit f6869826de700bce59e2cef14974f99836e34e4f: selftests: vm: update .gitignore with new test (2018-02-26 16:09:50 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest tags/linux-kselftest-4.16-rc5 for you to fetch changes up to ba004a2955f759946d8c98ca1a9c8d09818b1223: selftests: memory-hotplug: fix emit_tests regression (2018-03-02 10:12:59 -0700) ---------------------------------------------------------------- linux-kselftest-4.16-rc5 This kselftest fixes update has a fix for regression in memory-hotplug install script that prevents the test from running on the target. ---------------------------------------------------------------- Shuah Khan (1): selftests: memory-hotplug: fix emit_tests regression tools/testing/selftests/memory-hotplug/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -----------------------------------------------------------------------------------

6 years, 9 months

1
0
0 0

[PATCH v4 00/19] tracing: probeevent: Improve fetcharg features

by Masami Hiramatsu

Hi, This is the 4th version of the fetch-arg improvement series. This includes variable changes on fetcharg framework like, - Add fetcharg testcases (syntax, argN, symbol, string and array) and probepoint testcase. - Rewrite fetcharg framework with fetch_insn, switch-case based instead of function pointer. - Add "symbol" type support, which shows symbol+offset instead of address value. - Add "$argN" fetcharg, which fetches function parameters. (currently only for x86-64) - Add array type support (including string arrary :) ) , which enables to get fixed length array from probe-events. V3 is here: https://lkml.org/lkml/2018/2/24/3 Changes from the v3 are here: - [1/19] Fix to pass a sign to kstrtol (Thanks Namhyung!) and check UINT_MAX for kprobe's offset. - [4/19] Add new testcase for checking probepoint syntax. - [16/19] Fix to use calculated size correctly for field definition. (Thank you Namhyung!). - [19/19] Add format field tests. Here are examples: o 'symbol' type # echo 'p vfs_read $stack0:symbol' > kprobe_events # echo 1 > events/kprobes/p_vfs_read_0/enable # tail -n 3 trace sh-729 [007] ...2 105.753637: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=SyS_read+0x42/0x90 tail-736 [000] ...2 105.754904: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=kernel_read+0x2c/0x40 tail-736 [000] ...2 105.754929: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=kernel_read+0x2c/0x40 o $argN # echo 'p vfs_read $arg0 $arg1 $arg2' > kprobe_events # echo 1 > events/kprobes/p_vfs_read_0/enable # tail -n 3 trace sh-726 [007] ...2 134.288973: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=0xffff88001d98ec00 arg2=0x7ffeb4330f79 arg3=0x1 tail-731 [000] ...2 134.289987: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=0xffff88001d9dd200 arg2=0xffff88001d8a0a00 arg3=0x80 tail-731 [000] ...2 134.290016: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=0xffff88001d9dd200 arg2=0xffff88001faf4a00 arg3=0x150 o Array type # echo 'p vfs_read +0($stack):x64 +0($stack):x8[8]' > kprobe_events # echo 1 > events/kprobes/p_vfs_read_0/enable # tail -n 3 trace sh-729 [007] ...2 91.701664: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=0xffffffff811b1252 arg2={0x52,0x12,0x1b,0x81,0xff,0xff,0xff,0xff} tail-734 [000] ...2 91.702366: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=0xffffffff811b0dec arg2={0xec,0xd,0x1b,0x81,0xff,0xff,0xff,0xff} tail-734 [000] ...2 91.702386: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=0xffffffff811b0dec arg2={0xec,0xd,0x1b,0x81,0xff,0xff,0xff,0xff} # # cat events/kprobes/p_vfs_read_0/format name: p_vfs_read_0 ID: 1069 format: field:unsigned short common_type; offset:0; size:2; signed:0; field:unsigned char common_flags; offset:2; size:1; signed:0; field:unsigned char common_preempt_count; offset:3; size:1; signed:0; field:int common_pid; offset:4; size:4; signed:1; field:unsigned long __probe_ip; offset:8; size:8; signed:0; field:u64 arg1; offset:16; size:0; signed:0; field:u8 arg2[8]; offset:24; size:8; signed:0; print fmt: "(%lx) arg1=0x%Lx arg2={0x%x,0x%x,0x%x,0x%x,0x%x,0x%x,0x%x,0x%x}", REC->__probe_ip, REC->arg1, REC->arg2[0], REC->arg2[1], REC->arg2[2], REC->arg2[3], REC->arg2[4], REC->arg2[5], REC->arg2[6], REC->arg2[7] o String Array type # echo "p create_trace_kprobe arg1=+0(%si):string[3]" > kprobe_events # echo test1 test2 test3 >> kprobe_events sh: write error: Invalid argument # echo 'p vfs_read $stack' >> kprobe_events # tail -n 2 trace sh-744 [007] ...1 183.382407: p_create_trace_kprobe_0: (create_trace_kprobe+0x0/0x890) arg1={"test1","test2","test3"} sh-744 [007] ...1 230.487809: p_create_trace_kprobe_0: (create_trace_kprobe+0x0/0x890) arg1={"p","vfs_read","$stack"} Thank you, --- Masami Hiramatsu (19): [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol selftests: ftrace: Add probe event argument syntax testcase selftests: ftrace: Add a testcase for string type with kprobe_event selftests: ftrace: Add a testcase for probepoint tracing: probeevent: Cleanup print argument functions tracing: probeevent: Cleanup argument field definition tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions tracing: probeevent: Introduce new argument fetching code tracing: probeevent: Unify fetch type tables tracing: probeevent: Return consumed bytes of dynamic area tracing: probeevent: Append traceprobe_ for exported function tracing: probeevent: Unify fetch_insn processing common part tracing: probeevent: Add symbol type x86: ptrace: Add function argument access API tracing: probeevent: Add $argN for accessing function args tracing: probeevent: Add array type support selftests: ftrace: Add a testcase for symbol type selftests: ftrace: Add a testcase for $argN with kprobe_event selftests: ftrace: Add a testcase for array type with kprobe_event Documentation/trace/kprobetrace.txt | 26 + arch/Kconfig | 7 arch/x86/Kconfig | 1 arch/x86/include/asm/ptrace.h | 38 + kernel/trace/trace.c | 9 kernel/trace/trace_kprobe.c | 366 ++++-------- kernel/trace/trace_probe.c | 628 +++++++++----------- kernel/trace/trace_probe.h | 284 +++------ kernel/trace/trace_probe_tmpl.h | 214 +++++++ kernel/trace/trace_uprobe.c | 168 ++--- .../ftrace/test.d/kprobe/kprobe_args_argN.tc | 25 + .../ftrace/test.d/kprobe/kprobe_args_array.tc | 92 +++ .../ftrace/test.d/kprobe/kprobe_args_string.tc | 46 + .../ftrace/test.d/kprobe/kprobe_args_symbol.tc | 77 ++ .../ftrace/test.d/kprobe/kprobe_args_syntax.tc | 97 +++ .../selftests/ftrace/test.d/kprobe/probepoint.tc | 43 + 16 files changed, 1230 insertions(+), 891 deletions(-) create mode 100644 kernel/trace/trace_probe_tmpl.h create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_argN.tc create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_array.tc create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_symbol.tc create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/probepoint.tc -- Masami Hiramatsu (Linaro) <mhiramat(a)kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 9 months

2
25
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror