Y2038 July 2015

y2038@lists.linaro.org

10 participants
15 discussions

by FedEx 2Day A.M.

Dear Customer, This is to confirm that one or more of your parcels has been shipped. Please, open email attachment to print shipment label. Regards, David Mathis, Sr. Station Manager.

8 years, 9 months

Re: [Y2038] [RFC PATCH v2 4/4] y2038: convert ppdev to 2038 safe

by Arnd Bergmann

On Monday 29 June 2015 22:23:27 Bamvor Zhang Jian wrote: > diff --git a/include/uapi/linux/ppdev.h b/include/uapi/linux/ppdev.h > index dc18c5d..d62a47d 100644 > --- a/include/uapi/linux/ppdev.h > +++ b/include/uapi/linux/ppdev.h > @@ -74,8 +74,18 @@ struct ppdev_frob_struct { > #define PPSETPHASE _IOW(PP_IOCTL, 0x94, int) > > /* Set and get port timeout (struct timeval's) */ > -#define PPGETTIME _IOR(PP_IOCTL, 0x95, struct timeval) > -#define PPSETTIME _IOW(PP_IOCTL, 0x96, struct timeval) > +/* Force application use 64 time_t ioctl */ > +/* TODO: It is an open question about we should use a __xxx_timeval or an > + * implicit array. > + * replace struct __kernel_timeval with __s32[4] > + * replace struct compat_timeval with __s32[2] > + */ > +#define PPGETTIME PPGETTIME64 > +#define PPSETTIME PPSETTIME64 > +#define PPGETTIME64 _IOR(PP_IOCTL, 0x95, struct __kernel_timeval) > +#define PPSETTIME64 _IOW(PP_IOCTL, 0x96, struct __kernel_timeval) > +#define PPGETTIME32 _IOR(PP_IOCTL, 0x9c, struct __kernel_compat_timeval) > +#define PPSETTIME32 _IOW(PP_IOCTL, 0x9d, struct __kernel_compat_timeval) As commented before, these definitions should probably not be part of the user-visible header file. The main reason for using an __s64[2] array instead of struct __kernel_timeval is to avoid adding __kernel_timeval: 'timeval' is thoroughly deprecated and we don't want to establish new interfaces with that. In case of this driver, nobody would ever want to change their user space to use a 64-bit __kernel_timeval instead of timeval and explicitly call PPGETTIME64 instead of PPGETTIME, because we are only dealing with an interval here, and a 32-bit second value is sufficient to represent that. Instead, the purpose of your patch is to make the kernel cope with user space that happens to use a 64-bit time_t based definition of 'struct timeval' and passes that to the ioctl. Arnd [re-sent with fixed y2038 list]

8 years, 9 months

Re: [Y2038] [RFC PATCH v2 3/4] ppdev: add compat ioctl

by John Stultz

On Mon, Jun 29, 2015 at 7:23 AM, Bamvor Zhang Jian <bamvor.zhangjian(a)linaro.org> wrote: > Add compat ioctl in ppdev in order to solve the y2038 issue in > later patch. > This patch simply add pp_do_ioctl to compat_ioctl, because I found > that all the ioctl access the arg as a pointer. > > Signed-off-by: Bamvor Zhang Jian <bamvor.zhangjian(a)linaro.org> > --- > drivers/char/ppdev.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c > index ae0b42b..9207658 100644 > --- a/drivers/char/ppdev.c > +++ b/drivers/char/ppdev.c > @@ -69,6 +69,7 @@ > #include <linux/ppdev.h> > #include <linux/mutex.h> > #include <linux/uaccess.h> > +#include <linux/compat.h> > > #define PP_VERSION "ppdev: user-space parallel port driver" > #define CHRDEV "ppdev" > @@ -635,6 +636,11 @@ static long pp_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > return ret; > } > > +static long pp_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > +{ > + return pp_ioctl(file, cmd, (unsigned long)compat_ptr(arg)); > +} > + > static int pp_open (struct inode * inode, struct file * file) > { > unsigned int minor = iminor(inode); > @@ -744,6 +750,9 @@ static const struct file_operations pp_fops = { > .write = pp_write, > .poll = pp_poll, > .unlocked_ioctl = pp_ioctl, > +#ifdef CONFIG_COMPAT > + .compat_ioctl = pp_compat_ioctl, > +#endif Does adding this patch w/o the following patch break 32bit apps using this on 64bit kernels? thanks -john

8 years, 9 months

Notice to Appear

by District Court

Notice to Appear, You have to appear in the Court on the July 15. Please, prepare all the documents relating to the case and bring them to Court on the specified date. Note: If you do not come, the case will be heard in your absence. You can review complete details of the Court Notice in the attachment. Sincerely, Thomas Dunlap, Court Secretary.

8 years, 9 months

Courier was unable to deliver the parcel, ID0000743685

by FedEx International MailService

Dear Customer, Your parcel has arrived at June 29. Courier was unable to deliver the parcel to you. Shipment Label is attached to email. Thank you for choosing FedEx, Fred Huber, FedEx Support Agent.

8 years, 9 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

Y2038 July 2015