Y2038

y2038@lists.linaro.org

1 participants
1124 discussions

Re: [Y2038] [PATCH v3 06/10] time/alarmtimer:Introduce the new methods with timespec64 type for k_clock structure

by Arnd Bergmann

On Saturday 11 April 2015 18:46:52 Baolin Wang wrote: > This patch introduces the new methods with timespec64 type of k_clock > structure, and converts the timespec type to timespec64 type in alarmtimer.c > > Signed-off-by: Baolin Wang <baolin.wang(a)linaro.org> > --- > kernel/time/alarmtimer.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) Looks good. > diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c > index 1b001ed..7aefb7f 100644 > --- a/kernel/time/alarmtimer.c > +++ b/kernel/time/alarmtimer.c > @@ -489,35 +489,36 @@ static enum alarmtimer_restart alarm_handle_timer(struct alarm *alarm, > /** > * alarm_clock_getres - posix getres interface > * @which_clock: clockid > - * @tp: timespec to fill > + * @tp: timespec64 to fill > * > * Returns the granularity of underlying alarm base clock > */ > -static int alarm_clock_getres(const clockid_t which_clock, struct timespec *tp) > +static int alarm_clock_getres(const clockid_t which_clock, > + struct timespec64 *tp) > { > clockid_t baseid = alarm_bases[clock2alarm(which_clock)].base_clockid; > > if (!alarmtimer_get_rtcdev()) > return -EINVAL; > > - return hrtimer_get_res(baseid, tp); > + return hrtimer_get_res64(baseid, tp); > } > > /** > * alarm_clock_get - posix clock_get interface > * @which_clock: clockid > - * @tp: timespec to fill. > + * @tp: timespec64 to fill. > * > * Provides the underlying alarm base time. > */ > -static int alarm_clock_get(clockid_t which_clock, struct timespec *tp) > +static int alarm_clock_get(clockid_t which_clock, struct timespec64 *tp) > { > struct alarm_base *base = &alarm_bases[clock2alarm(which_clock)]; > > if (!alarmtimer_get_rtcdev()) > return -EINVAL; > > - *tp = ktime_to_timespec(base->gettime()); > + *tp = ktime_to_timespec64(base->gettime()); > return 0; > } > > @@ -670,7 +671,7 @@ static int alarmtimer_do_nsleep(struct alarm *alarm, ktime_t absexp) > > > /** > - * update_rmtp - Update remaining timespec value > + * update_rmtp - Update remaining timespec64 value > * @exp: expiration time > * @type: timer type > * @rmtp: user pointer to remaining timepsec value > @@ -824,8 +825,8 @@ static int __init alarmtimer_init(void) > int error = 0; > int i; > struct k_clock alarm_clock = { > - .clock_getres = alarm_clock_getres, > - .clock_get = alarm_clock_get, > + .clock_getres64 = alarm_clock_getres, > + .clock_get64 = alarm_clock_get, > .timer_create = alarm_timer_create, > .timer_set = alarm_timer_set, > .timer_del = alarm_timer_del, >

9 years, 5 months

Re: [Y2038] [PATCH v3 04/10] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

by Arnd Bergmann

On Saturday 11 April 2015 18:46:50 Baolin Wang wrote: > This patch introduces the new methods with timespec64 type for k_clcok structure, > converts the timepsec type to timespec64 type in k_clock structure and implements > some callback function. > > This patch also converts the timespec type to timespec64 type for timekeeping_clocktai > function which is used only in the posix-timers.c file. > > Next step will migrate all the k_clock users to use the new methods with timespec64 type, > and it contains the files of mmtimer.c, alarmtimer.c, posix-clock.c and > posix-cpu-timers.c. > > Signed-off-by: Baolin Wang <baolin.wang(a)linaro.org> The changes in this patch all look good, but as I mentioned, I would separate the two things you do here: > struct k_clock { > int (*clock_getres) (const clockid_t which_clock, struct timespec *tp); > + int (*clock_getres64) (const clockid_t which_clock, > + struct timespec64 *tp); > int (*clock_set) (const clockid_t which_clock, > const struct timespec *tp); > + int (*clock_set64) (const clockid_t which_clock, > + const struct timespec64 *tp); > int (*clock_get) (const clockid_t which_clock, struct timespec * tp); > + int (*clock_get64) (const clockid_t which_clock, struct timespec64 *tp); > int (*clock_adj) (const clockid_t which_clock, struct timex *tx); > int (*timer_create) (struct k_itimer *timer); > int (*nsleep) (const clockid_t which_clock, int flags, a) introducing and using the function pointers > @@ -278,9 +284,9 @@ static int posix_get_tai(clockid_t which_clock, struct timespec *tp) > static __init int init_posix_timers(void) > { > struct k_clock clock_realtime = { > - .clock_getres = hrtimer_get_res, > - .clock_get = posix_clock_realtime_get, > - .clock_set = posix_clock_realtime_set, > + .clock_getres64 = hrtimer_get_res64, > + .clock_get64 = posix_clock_realtime_get, > + .clock_set64 = posix_clock_realtime_set, > .clock_adj = posix_clock_realtime_adj, > .nsleep = common_nsleep, and b) converting some of the k_clock definitions. Arnd

9 years, 5 months

Re: [Y2038] [PATCH v3 03/10] time/hrtimer:Introduce hrtimer_get_res64() for getting the timer resolution

by Arnd Bergmann

On Saturday 11 April 2015 18:46:49 Baolin Wang wrote: > This patch introduces hrtimer_get_res64() function to get the timer resolution > with timespec64 type, and moves the hrtimer_get_res() function into > include/linux/hrtimer.h as a 'static inline' helper that just calls hrtimer_get_res64. > > Signed-off-by: Baolin Wang <baolin.wang(a)linaro.org> > Looks good. Arnd

9 years, 5 months

Re: [Y2038] [PATCH v3 02/10] timekeeping:Introduce the current_kernel_time64() with timespec64 type

by Arnd Bergmann

On Saturday 11 April 2015 18:46:48 Baolin Wang wrote: > This patch adds current_kernel_time64() function with timespec64 type, > and makes current_kernel_time 'static inline' and moves it to timekeeping.h > file. > > Signed-off-by: Baolin Wang <baolin.wang(a)linaro.org> Looks good to me. Arnd > diff --git a/include/linux/timekeeping.h b/include/linux/timekeeping.h > index 3eaae47..c6d5ae9 100644 > --- a/include/linux/timekeeping.h > +++ b/include/linux/timekeeping.h > @@ -18,10 +18,18 @@ extern int do_sys_settimeofday(const struct timespec *tv, > * Kernel time accessors > */ > unsigned long get_seconds(void); > -struct timespec current_kernel_time(void); > +struct timespec64 current_kernel_time64(void); > /* does not take xtime_lock */ > struct timespec __current_kernel_time(void); > > +static inline struct timespec current_kernel_time(void) > +{ > + struct timespec64 now; > + > + now = current_kernel_time64(); > + return timespec64_to_timespec(now); > +} > + > /* > * timespec based interfaces > */ > diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c > index 91db941..8ccc02c 100644 > --- a/kernel/time/timekeeping.c > +++ b/kernel/time/timekeeping.c > @@ -1721,7 +1721,7 @@ struct timespec __current_kernel_time(void) > return timespec64_to_timespec(tk_xtime(tk)); > } > > -struct timespec current_kernel_time(void) > +struct timespec64 current_kernel_time64(void) > { > struct timekeeper *tk = &tk_core.timekeeper; > struct timespec64 now; > @@ -1733,9 +1733,9 @@ struct timespec current_kernel_time(void) > now = tk_xtime(tk); > } while (read_seqcount_retry(&tk_core.seq, seq)); > > - return timespec64_to_timespec(now); > + return now; > } > -EXPORT_SYMBOL(current_kernel_time); > +EXPORT_SYMBOL(current_kernel_time64); > > struct timespec64 get_monotonic_coarse64(void) > { >

9 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

Y2038