Re: [Y2038] [PATCH 6/8] socket: Add struct sock_timeval

From: Willem de Bruijn willemdebruijn.kernel@gmail.com Date: Sat, 24 Nov 2018 14:37:42 -0500

On Sat, Nov 24, 2018 at 4:00 AM Deepa Dinamani deepa.kernel@gmail.com wrote:

...

diff --git a/include/uapi/linux/time.h b/include/uapi/linux/time.h index 04d5587f30d3..106f9398c285 100644 --- a/include/uapi/linux/time.h +++ b/include/uapi/linux/time.h @@ -70,6 +70,11 @@ struct __kernel_old_timeval { }; #endif

+struct sock_timeval {

•   long long tv_sec;
  

•   long long tv_usec;
  

should these use fixed-width type __u64?

even if all data models define long long as 64-bit, that might be more descriptive.

Agreed.