Re: [PATCH 1/2] arm64: dts: qcom: sc7180: Support ETMv4 power management

On Fri 15 May 03:55 PDT 2020, Sai Prakash Ranjan wrote:

Hi Bjorn,

Hi Sai,

On 2020-05-15 16:21, Sai Prakash Ranjan wrote:

...

Now that deep idle states are properly supported on SC7180, we need to add "coresight-loses-context-with-cpu" property to avoid failure of trace session because of losing context on entering deep idle states.

Reviewed-by: Stephen Boyd swboyd@chromium.org Signed-off-by: Sai Prakash Ranjan saiprakash.ranjan@codeaurora.org

---

Resending this because the last patch sent here - https://lore.kernel.org/patchwork/patch/1230367/ seems to have added "coresight-loses-context-with-cpu" to replicator node instead of etm7 node.

---

arch/arm64/boot/dts/qcom/sc7180.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 4069bb1c93af..8b3707347547 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1656,6 +1656,7 @@

	clocks = <&aoss_qmp>;
	clock-names = "apb_pclk";

• 	arm,coresight-loses-context-with-cpu;
  
  out-ports {
  	port {
  

@@ -1674,6 +1675,7 @@

	clocks = <&aoss_qmp>;
	clock-names = "apb_pclk";

• 	arm,coresight-loses-context-with-cpu;
  
  out-ports {
  	port {
  

@@ -1692,6 +1694,7 @@

	clocks = <&aoss_qmp>;
	clock-names = "apb_pclk";

• 	arm,coresight-loses-context-with-cpu;
  
  out-ports {
  	port {
  

@@ -1710,6 +1713,7 @@

	clocks = <&aoss_qmp>;
	clock-names = "apb_pclk";

• 	arm,coresight-loses-context-with-cpu;
  
  out-ports {
  	port {
  

@@ -1728,6 +1732,7 @@

	clocks = <&aoss_qmp>;
	clock-names = "apb_pclk";

• 	arm,coresight-loses-context-with-cpu;
  
  out-ports {
  	port {
  

@@ -1746,6 +1751,7 @@

	clocks = <&aoss_qmp>;
	clock-names = "apb_pclk";

• 	arm,coresight-loses-context-with-cpu;
  
  out-ports {
  	port {
  

@@ -1764,6 +1770,7 @@

	clocks = <&aoss_qmp>;
	clock-names = "apb_pclk";

• 	arm,coresight-loses-context-with-cpu;
  
  out-ports {
  	port {
  

@@ -1782,6 +1789,7 @@

	clocks = <&aoss_qmp>;
	clock-names = "apb_pclk";

• 	arm,coresight-loses-context-with-cpu;
  
  out-ports {
  	port {
  

The previous version of this patch in QCOM tree seems to have added the property to replicator node instead of etm7 node, can you please drop that from the tree and apply this one?

I'm not able to replace the old commit without rewriting the history of the branch. So I've applied a patch ontop of the branch to fix this up instead.

Please review the branch and let me know if there's any issues.

Regards, Bjorn