On 03/08/2021 15:01, Leo Yan wrote:
one can also use debuginfod-client, which, as time passes, probably will be the main way of finding DSOs now that we have build-ids in PERF_RECORD_MMAP2 and debuginfod servers such as:
export DEBUGINFOD_URLS=https://debuginfod.fedoraproject.org/
If so, maybe should use more general description for missing DSO.
https://fedoraproject.org/wiki/Debuginfod
With this improvement, the patch looks good to me:
Reviewed-by: Leo Yan leo.yan@linaro.org
Does this apply to the other 5 patches in this series?
I finished to reivew patches 01, 04, 05, 06/06, so my review tag can apply on these patches. Current patch 06/06 needs James to improve for the comments.
Thanks for the reviews, I've submitted v2.
I also had a play around with debuginfod, it looks promising. Especially if it's integrated with perf report, which I assume is the plan?
Thanks James