Re: [PATCH v2 0/9] Support ETE decoding

On 24/08/2021 09:47, Leo Yan wrote:

Hi Mathieu, Suzuki, Mike,

On Fri, Aug 06, 2021 at 02:41:00PM +0100, James Clark wrote:

...

Changes since v1:

• Re-implement with a new magic number instead of piggybacking on ETMv4
• Improve comments and function name around cs_etm_decoder__get_etmv4_arch_ver()
• Add a warning for unrecognised magic numbers
• Split typo fix into new commit
• Add Leo's reviewed-by tags
• Create a new struct for ETE config (cs_ete_trace_params) instead of re-using ETMv4 config

Applies to perf/core f3c33cbd922 Also available at https://gitlab.arm.com/linux-arm/linux-jc/-/tree/james-ete-v2

I have finished the review for this patch series and it's good form for me. Since this patch series is to enable new feature for ETE, it's good if any of you could review as well before merging.

Thanks for the reviews Leo!

Thanks, Leo