Re: [PATCH v4 02/25] coresight: etm4x: Skip accessing TRCPDCR in save/restore

Hi Suzuki,

On 2020-11-19 22:15, Suzuki K Poulose wrote:

When the ETM is affected by Qualcomm errata, modifying the TRCPDCR could cause the system hang. Even though this is taken care of during enable/disable ETM, the ETM state save/restore could still access the TRCPDCR. Make sure we skip the access during the save/restore.

Found by code inspection.

Thanks for the patch, I did test at the time if these accesses in save and restore cause any hang and they do not. But this patch doesn't leave anything to chances, so its good.

Reviewed-by: Sai Prakash Ranjan saiprakash.ranjan@codeaurora.org Tested-by: Sai Prakash Ranjan saiprakash.ranjan@codeaurora.org

Thanks, Sai