On 14/02/2024 16:03, Rob Herring wrote:
On Wed, Feb 14, 2024 at 9:56 AM Suzuki K Poulose suzuki.poulose@arm.com wrote:
On 13/02/2024 22:29, Rob Herring wrote:
On Tue, Feb 13, 2024 at 08:05:17AM -0800, Mao Jinlong wrote:
Change qcom,dsb-element-size to qcom,dsb-element-bits as the unit is bit.
That may be, but this is an ABI and you are stuck with it. Unless, you can justify why that doesn't matter. (IIRC, this is new, so maybe no users yet?)
This was added and support queued in v6.8. This change won't make it to v6.8 (given it has to go via two levels and is technically not a fix).
I'd argue it is a fix. But given no users yet, delaying is fine.
I agree it is a fix, but not something that maintainers would like to pull it during an rc cycle. As you said, since there are no real users for this yet (and given it is all under a single vendor), it may be fine to queue this if the DT maintainers are OK with this.
As James also pointed out, it doesn't matter what the name is (now that it has been published).
v6.8 final is what we consider published.
I can't send this to Greg as a fix. For v6.8. We can fix it for v6.9 cycle.
Suzuki
Rob
On 2/15/2024 12:18 AM, Suzuki K Poulose wrote:
On 14/02/2024 16:03, Rob Herring wrote:
On Wed, Feb 14, 2024 at 9:56 AM Suzuki K Poulose suzuki.poulose@arm.com wrote:
On 13/02/2024 22:29, Rob Herring wrote:
On Tue, Feb 13, 2024 at 08:05:17AM -0800, Mao Jinlong wrote:
Change qcom,dsb-element-size to qcom,dsb-element-bits as the unit is bit.
That may be, but this is an ABI and you are stuck with it. Unless, you can justify why that doesn't matter. (IIRC, this is new, so maybe no users yet?)
This was added and support queued in v6.8. This change won't make it to v6.8 (given it has to go via two levels and is technically not a fix).
I'd argue it is a fix. But given no users yet, delaying is fine.
I agree it is a fix, but not something that maintainers would like to pull it during an rc cycle. As you said, since there are no real users for this yet (and given it is all under a single vendor), it may be fine to queue this if the DT maintainers are OK with this.
As James also pointed out, it doesn't matter what the name is (now that it has been published).
v6.8 final is what we consider published.
I can't send this to Greg as a fix. For v6.8. We can fix it for v6.9 cycle.
Suzuki
Thanks all for the comments. I will update the commit message and fix the warning.
Thanks Jinlong Mao
Rob
-
Jinlong Mao -
Suzuki K Poulose