On Tue, Dec 16, 2025 at 01:00:32PM -0800, Ian Rogers wrote:

On Fri, Dec 12, 2025 at 7:32 AM James Clark james.clark@linaro.org wrote:

...

The specific config field that an event format attribute is in is consistently hard coded, even though the API is supposed to be that the driver publishes the config field name. To stop this pattern from being copy pasted and causing problems in the future, replace them all with calls to a new helper that returns the value that a user set.

This reveals some issues in evsel__set_config_if_unset(). It doesn't work with sparse bitfields, which are an unused but documented feature. And it also only writes to the attr.config field. To fix it we need to start tracking user changes for all config fields and then use existing helper functions that support sparse bitfields. Some other refactoring was also required and a test was added.

Signed-off-by: James Clark james.clark@linaro.org

Outside of some nits, for the series: Reviewed-by: Ian Rogers irogers@google.com

Are you ok with v4?

- Arnaldo